[MLIR] Add missing MLIRFuncDialect dep to MLIRNVVMToLLVM

[RoboTux]

This fixes the following failure when doing a clean build (in particular
no .ninja* lying around) of lib/libMLIRNVVMToLLVM.a only:

In file included from mlir/lib/Conversion/NVVMToLLVM/NVVMToLLVM.cpp:18:
mlir/include/mlir/Dialect/Func/IR/FuncOps.h:29:10: fatal error: mlir/Dialect/Func/IR/FuncOps.h.inc: No such file or directory

[llvmbot]

@llvm/pr-subscribers-mlir

Author: Thomas Preud'homme (RoboTux)

Changes

This fixes a failure when doing a clean build of
lib/libMLIRNVVMToLLVM.a only.

---

Full diff: https://github.com/llvm/llvm-project/pull/84548.diff

1 Files Affected:

• (modified) mlir/lib/Conversion/NVVMToLLVM/CMakeLists.txt (+1)

diff --git a/mlir/lib/Conversion/NVVMToLLVM/CMakeLists.txt b/mlir/lib/Conversion/NVVMToLLVM/CMakeLists.txt
index 2afff1a4e5f169..23174d11287199 100644
--- a/mlir/lib/Conversion/NVVMToLLVM/CMakeLists.txt
+++ b/mlir/lib/Conversion/NVVMToLLVM/CMakeLists.txt
@@ -11,6 +11,7 @@ add_mlir_conversion_library(MLIRNVVMToLLVM
   Core
 
   LINK_LIBS PUBLIC
+  MLIRFuncDialect
   MLIRGPUDialect
   MLIRLLVMCommonConversion
   MLIRLLVMDialect

[grypp]

Thanks, good catch

[joker-eph]

Same comment as the other: if you can put the error in the description (I can't reproduce annoyingly).

[RoboTux]

Same comment as the other: if you can put the error in the description (I can't reproduce annoyingly).

I don't seem to be able to anymore, but ninja shows the problem if you run cmake and then do ninja -t missingdeps lib/libMLIRNVVMToLLVM.a

[RoboTux]

Same comment as the other: if you can put the error in the description (I can't reproduce annoyingly).

I don't seem to be able to anymore, but ninja shows the problem if you run cmake and then do ninja -t missingdeps lib/libMLIRNVVMToLLVM.a

As pointed by @zero9178 in another similar PR, it can be reproduced if building in a totally empty directory (in particular no .ninja* file). I've updated the description accordingly.