[MLIR] Add missing MLIRFuncDialect dep to MLIRAMDGPUTransforms #84550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a failure when doing a clean build of lib/libMLIRAMDGPUTransform.a only.
|
@llvm/pr-subscribers-mlir-gpu @llvm/pr-subscribers-mlir Author: Thomas Preud'homme (RoboTux) ChangesThis fixes a failure when doing a clean build of Full diff: https://github.com/llvm/llvm-project/pull/84550.diff 1 Files Affected:
diff --git a/mlir/lib/Dialect/AMDGPU/Transforms/CMakeLists.txt b/mlir/lib/Dialect/AMDGPU/Transforms/CMakeLists.txt
index 2274656e84a5c1..a955d585b9a1dc 100644
--- a/mlir/lib/Dialect/AMDGPU/Transforms/CMakeLists.txt
+++ b/mlir/lib/Dialect/AMDGPU/Transforms/CMakeLists.txt
@@ -14,6 +14,7 @@ add_mlir_dialect_library(MLIRAMDGPUTransforms
MLIRAMDGPUUtils
MLIRArithDialect
MLIRControlFlowDialect
+ MLIRFuncDialect
MLIRIR
MLIRPass
MLIRTransforms
|
krzysz00
approved these changes
Mar 8, 2024
I've modified the description as suggested by Mehdi to show the error. As you can see the problem is OptimiseSharedMemory transform including FuncOps.h which includes tablegen'd FuncOps.h.inc |
|
Do I need to land this for you? |
No I just wanted to see if you change your mind with a longer explanation. I'll land this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following failure when doing a clean build (in particular
no .ninja* lying around) of lib/libMLIRAMDGPUTransforms.a only: