Skip to content

[NFC] Corrected data type #84880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2024
Merged

[NFC] Corrected data type #84880

merged 1 commit into from
Mar 13, 2024

Conversation

ChengChen002
Copy link
Contributor

@ChengChen002 ChengChen002 commented Mar 12, 2024 •
edited
Loading

On windows, "&Method.first" is of type "unsigned long long *", and a type conversion error occurs.

@ChengChen002
Copy link
Contributor Author

@yugier Could you help review the PR?

@haonanya
Copy link

haonanya commented Mar 13, 2024 •
edited
Loading

@lhames and @MaskRay, can you please take a look as well? Thanks very much.

hongyu-dev
hongyu-dev approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@hongyu-dev hongyu-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lhames
lhames approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@lhames lhames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too.

@lhames lhames merged commit 35f5cae into llvm:main Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhames lhames lhames approved these changes

@hongyu-dev hongyu-dev hongyu-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChengChen002 @haonanya @lhames @hongyu-dev