Skip to content

[ARM][AArch64] Add missing Arm CPU part-ids to enable -mcpu=native #84899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

jthackray
Copy link
Contributor

@jthackray jthackray commented Mar 12, 2024

Update Host.cpp with some missing Arm CPU part identifiers,
to enable -mcpu=native on these processors. These are found in
the Technical Reference Manuals listed under "part num" or "part no"

Update Host.cpp with some missing Arm CPU part identifiers,
to enable -mcpu=native on these processors. These are found in
the Technical Reference Manuals listed under "part num" or "part no"
Copy link
Collaborator

@davemgreen davemgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds good. Maybe they are not super helpful, but there are some tests in TEST(getLinuxHostCPUName, AArch64) if you wanted to check some of the ones that are more likely to run with -mcpu=native.

Copy link
Collaborator

@davemgreen davemgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I'm not sure it's very useful to compare numbers against themselves. Up to you whether you wanted to add them.

I checked this mostly against GCC from https://sourcegraph.com/github.com/gcc-mirror/gcc@ad860cc27b3312f9119c7fecb8638a7c1f6d77c9/-/blob/gcc/config/aarch64/aarch64-cores.def. The values LGTM.

@jthackray jthackray merged commit 99be387 into llvm:main Mar 13, 2024
Copy link
Contributor

@rgwott rgwott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented here that it LGTM, but nevermind, it is already merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants