Skip to content

Fix typo #86319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Mar 22, 2024
Merged

Fix typo #86319

merged 1 commit into from Mar 22, 2024

Conversation

ghost
Copy link

@ghost ghost commented Mar 22, 2024

Im working on the floating point fmaximum and fminimum functions right now in a different pr and I ran the individual tests by doing

ninja libc.test.src.math.smoke.<func>_test.__unit__

Im working on the floating point fmaximum and fminimum functions right now and I ran the individual tests by doing

```
ninja libc.test.src.math.smoke.<func>_test.__unit__
```
@llvmbot llvmbot added the libc label Mar 22, 2024
@llvmbot
Copy link
Member

llvmbot commented Mar 22, 2024

@llvm/pr-subscribers-libc

Author: Job Henandez Lara (Jobhdez)

Changes

Im working on the floating point fmaximum and fminimum functions right now in a different pr and I ran the individual tests by doing

ninja libc.test.src.math.smoke.&lt;func&gt;_test.__unit__

Full diff: https://github.com/llvm/llvm-project/pull/86319.diff

1 Files Affected:

  • (modified) libc/src/math/docs/add_math_function.md (+1-1)
diff --git a/libc/src/math/docs/add_math_function.md b/libc/src/math/docs/add_math_function.md
index f8bc8a3bdd8b1d..d1bca222b4286b 100644
--- a/libc/src/math/docs/add_math_function.md
+++ b/libc/src/math/docs/add_math_function.md
@@ -177,7 +177,7 @@ implementation (which is very often glibc).
 
 - Build and Run a specific unit test:
 ```
-  $ ninja libc.test.src.math.<func>_test
+  $ ninja libc.test.src.math.<func>_test.__unit__
   $ projects/libc/test/src/math/libc.test.src.math.<func>_test
 ```
 

Copy link
Contributor

@michaelrj-google michaelrj-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Technically, this isn't really a typo, more a piece of documentation that hasn't been updated. Regardless, updating it is good.

@ghost
Copy link
Author

ghost commented Mar 22, 2024

LGTM

Technically, this isn't really a typo, more a piece of documentation that hasn't been updated. Regardless, updating it is good.
Thanks

@michaelrj-google michaelrj-google merged commit 721f149 into llvm:main Mar 22, 2024
chencha3 pushed a commit to chencha3/llvm-project that referenced this pull request Mar 23, 2024
Im working on the floating point fmaximum and fminimum functions right
now in a different pr and I ran the individual tests by doing

```
ninja libc.test.src.math.smoke.<func>_test.__unit__
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants