Skip to content

[NFC][BP] Remove unused parameter from function #86333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2024
Merged

[NFC][BP] Remove unused parameter from function #86333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions llvm/include/llvm/Support/BalancedPartitioning.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,8 @@ class BalancedPartitioning {
std::optional<BPThreadPool> &TP) const;

/// Run bisection iterations
void runIterations(const FunctionNodeRange Nodes, unsigned RecDepth,
unsigned LeftBucket, unsigned RightBucket,
std::mt19937 &RNG) const;
void runIterations(const FunctionNodeRange Nodes, unsigned LeftBucket,
unsigned RightBucket, std::mt19937 &RNG) const;

/// Run a bisection iteration to improve the optimization goal
/// \returns the total number of moved FunctionNodes
Expand Down
4 changes: 2 additions & 2 deletions llvm/lib/Support/BalancedPartitioning.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ void BalancedPartitioning::bisect(const FunctionNodeRange Nodes,
// Split into two and assign to the left and right buckets
split(Nodes, LeftBucket);

runIterations(Nodes, RecDepth, LeftBucket, RightBucket, RNG);
runIterations(Nodes, LeftBucket, RightBucket, RNG);

// Split nodes wrt the resulting buckets
auto NodesMid =
Expand All @@ -163,7 +163,7 @@ void BalancedPartitioning::bisect(const FunctionNodeRange Nodes,
}

void BalancedPartitioning::runIterations(const FunctionNodeRange Nodes,
unsigned RecDepth, unsigned LeftBucket,
unsigned LeftBucket,
unsigned RightBucket,
std::mt19937 &RNG) const {
unsigned NumNodes = std::distance(Nodes.begin(), Nodes.end());
Expand Down