[ARM][NFC] Use addLiveIns method instead of manually adding live-ins #87560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-backend-systemz @llvm/pr-subscribers-backend-arm Author: AtariDreams (AtariDreams) ChangesFull diff: https://github.com/llvm/llvm-project/pull/87560.diff 1 Files Affected:
diff --git a/llvm/lib/Target/ARM/ARMConstantIslandPass.cpp b/llvm/lib/Target/ARM/ARMConstantIslandPass.cpp
index 7a3ba5870bc6df..c9b25a9d629743 100644
--- a/llvm/lib/Target/ARM/ARMConstantIslandPass.cpp
+++ b/llvm/lib/Target/ARM/ARMConstantIslandPass.cpp
@@ -1025,10 +1025,7 @@ MachineBasicBlock *ARMConstantIslands::splitBlockBeforeInstr(MachineInstr *MI) {
OrigBB->addSuccessor(NewBB);
// Update live-in information in the new block.
- MachineRegisterInfo &MRI = MF->getRegInfo();
- for (MCPhysReg L : LRs)
- if (!MRI.isReserved(L))
- NewBB->addLiveIn(L);
+ addLiveIns(*NewBB, LRs);
// Update internal data structures to account for the newly inserted MBB.
// This is almost the same as updateForInsertedWaterBlock, except that
|
AZero13
changed the title
AZero13
force-pushed
the
liveins
branch
3 times, most recently
from
6d4d22e to
58522f3
Compare
AZero13
changed the title
AZero13
changed the title
AZero13
force-pushed
the
liveins
branch
6 times, most recently
from
7fd6a74 to
c72549f
Compare
AZero13
changed the title
AZero13
force-pushed
the
liveins
branch
3 times, most recently
from
7fb09d5 to
8f5703d
Compare
AZero13
added a commit
to AZero13/llvm-project
that referenced
this pull request
Jun 24, 2024
…live-ins (llvm#87560)" This reverts commit 9378d74.
AZero13
added a commit
to AZero13/llvm-project
that referenced
this pull request
Jun 24, 2024
…live-ins (llvm#87560)" This reverts commit 9378d74.
AZero13
added a commit
to AZero13/llvm-project
that referenced
this pull request
Jun 26, 2024
…live-ins (llvm#87560)" This reverts commit 9378d74.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.