-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[libc][pthreads] pthread_cond_{destroy|init|signal|wait} #88583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nickdesaulniers
wants to merge
1
commit into
llvm:main
Choose a base branch
from
nickdesaulniers:pthread_cnd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
//===-- Definition of pthread_cond_t type ---------------------------------===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
#ifndef LLVM_LIBC_TYPES_PTHREAD_COND_T_H | ||
#define LLVM_LIBC_TYPES_PTHREAD_COND_T_H | ||
|
||
#include "pthread_mutex_t.h" | ||
|
||
typedef struct { | ||
void *__qfront; | ||
void *__qback; | ||
pthread_mutex_t __mtx; | ||
} pthread_cond_t; | ||
|
||
#endif // LLVM_LIBC_TYPES_PTHREAD_COND_T_H |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
//===-- Definition of pthread_condattr_t type -----------------------------===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
#ifndef LLVM_LIBC_TYPES_PTHREAD_CONDATTR_T_H | ||
#define LLVM_LIBC_TYPES_PTHREAD_CONDATTR_T_H | ||
|
||
typedef struct { | ||
int pshared; | ||
} pthread_condattr_t; | ||
|
||
#endif // LLVM_LIBC_TYPES_PTHREAD_CONDATTR_T_H |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
//===-- Linux implementation of the pthread_cond_wait function ------------===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#include "pthread_cond_destroy.h" | ||
|
||
#include "include/llvm-libc-macros/generic-error-number-macros.h" // EINVAL | ||
#include "src/__support/common.h" | ||
#include "src/threads/linux/CndVar.h" | ||
|
||
#include <pthread.h> // pthread_cond_t | ||
// TODO: https://github.com/llvm/llvm-project/issues/88580 | ||
#include <threads.h> // thrd_success | ||
Comment on lines
+16
to
+17
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. unused? |
||
|
||
namespace LIBC_NAMESPACE { | ||
|
||
LLVM_LIBC_FUNCTION(int, pthread_cond_destroy, (pthread_cond_t * cond)) { | ||
if (!cond) | ||
return EINVAL; | ||
|
||
CndVar *C = reinterpret_cast<CndVar *>(cond); | ||
CndVar::destroy(C); | ||
return 0; | ||
} | ||
|
||
} // namespace LIBC_NAMESPACE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
//===-- Implementation header for pthread_cond_destroy function -*- C++ -*-===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#ifndef LLVM_LIBC_SRC_PTHREAD_PTHREAD_COND_DESTROY_H | ||
#define LLVM_LIBC_SRC_PTHREAD_PTHREAD_COND_DESTROY_H | ||
|
||
#include <pthread.h> | ||
|
||
namespace LIBC_NAMESPACE { | ||
|
||
int pthread_cond_destroy(pthread_cond_t *cond); | ||
|
||
} // namespace LIBC_NAMESPACE | ||
|
||
#endif // LLVM_LIBC_SRC_PTHREAD_PTHREAD_COND_DESTROY_H |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
//===-- Linux implementation of the pthread_cond_init function ------------===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#include "pthread_cond_init.h" | ||
|
||
#include "include/llvm-libc-macros/generic-error-number-macros.h" // EINVAL | ||
#include "src/__support/common.h" | ||
#include "src/threads/linux/CndVar.h" | ||
|
||
#include <pthread.h> // pthread_cond_t, pthread_condattr_t | ||
// TODO: https://github.com/llvm/llvm-project/issues/88580 | ||
#include <threads.h> // thrd_succes | ||
|
||
namespace LIBC_NAMESPACE { | ||
|
||
LLVM_LIBC_FUNCTION(int, pthread_cond_init, | ||
(pthread_cond_t * cond, const pthread_condattr_t *attr)) { | ||
// TODO: properly support pthread_condattr_t. | ||
// https://github.com/llvm/llvm-project/issues/88582 | ||
if (attr) | ||
return EINVAL; | ||
|
||
CndVar *C = reinterpret_cast<CndVar *>(cond); | ||
int ret = CndVar::init(C); | ||
if (ret == thrd_success) | ||
return 0; | ||
|
||
// TODO: translate error codes? | ||
return -1; | ||
} | ||
|
||
} // namespace LIBC_NAMESPACE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
//===-- Implementation header for pthread_cond_init function ----*- C++ -*-===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#ifndef LLVM_LIBC_SRC_PTHREAD_PTHREAD_COND_INIT_H | ||
#define LLVM_LIBC_SRC_PTHREAD_PTHREAD_COND_INIT_H | ||
|
||
#include <pthread.h> | ||
|
||
namespace LIBC_NAMESPACE { | ||
|
||
int pthread_cond_init(pthread_cond_t *cond, const pthread_condattr_t *attr); | ||
|
||
} // namespace LIBC_NAMESPACE | ||
|
||
#endif // LLVM_LIBC_SRC_PTHREAD_PTHREAD_COND_INIT_H |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
//===-- Linux implementation of the pthread_cond_signal function ----------===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#include "pthread_cond_signal.h" | ||
|
||
#include "include/llvm-libc-macros/generic-error-number-macros.h" // EINVAL | ||
#include "src/__support/common.h" | ||
#include "src/threads/linux/CndVar.h" | ||
|
||
#include <pthread.h> // pthread_cond_t | ||
// TODO: https://github.com/llvm/llvm-project/issues/88580 | ||
#include <threads.h> // thrd_success | ||
|
||
namespace LIBC_NAMESPACE { | ||
|
||
LLVM_LIBC_FUNCTION(int, pthread_cond_signal, (pthread_cond_t * cond)) { | ||
if (!cond) | ||
return EINVAL; | ||
Comment on lines
+22
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Interestingly, bionic does not check for nullptr args. https://android-review.googlesource.com/c/platform/bionic/+/84016 |
||
|
||
CndVar *C = reinterpret_cast<CndVar *>(cond); | ||
int ret = C->notify_one(); | ||
|
||
if (ret == thrd_success) | ||
return 0; | ||
|
||
// TODO: translate error codes. | ||
return -1; | ||
} | ||
|
||
} // namespace LIBC_NAMESPACE |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be nice to land #88987 then rebase this PR on top of that. Marking this as draft for now.