Skip to content

[DAGCombiner][AArch64] Make combineCarryDiamond avoid creating UADDO_CARRY with carry in larger than setcc result type. #89121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2024
Merged

[DAGCombiner][AArch64] Make combineCarryDiamond avoid creating UADDO_CARRY with carry in larger than setcc result type. #89121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3520,6 +3520,8 @@ static SDValue combineCarryDiamond(SelectionDAG &DAG, const TargetLowering &TLI,
return SDValue();

SDLoc DL(N);
CarryIn = DAG.getBoolExtOrTrunc(CarryIn, DL, Carry1->getValueType(1),
Carry1->getValueType(0));
SDValue Merged =
DAG.getNode(NewOp, DL, Carry1->getVTList(), Carry0.getOperand(0),
Carry0.getOperand(1), CarryIn);
Expand Down
29 changes: 29 additions & 0 deletions llvm/test/CodeGen/AArch64/pr88966.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 4
; RUN: llc < %s -mtriple=aarch64 | FileCheck %s

define i32 @f(ptr %arg, i41 %arg1, ptr %arg2) {
; CHECK-LABEL: f:
; CHECK: // %bb.0: // %bb
; CHECK-NEXT: and w9, w1, #0x1
; CHECK-NEXT: mov w10, #1 // =0x1
; CHECK-NEXT: mov x8, x0
; CHECK-NEXT: cmp w9, #1
; CHECK-NEXT: mov w0, wzr
; CHECK-NEXT: adc x9, xzr, x10
; CHECK-NEXT: str x9, [x2]
; CHECK-NEXT: str xzr, [x8]
; CHECK-NEXT: ret
bb:
%new0 = and i41 %arg1, 1
%last = trunc i41 %new0 to i1
%i = add i64 0, 1
%i3 = zext i1 %last to i64
%i4 = add i64 %i, %i3
%i5 = icmp ult i64 %i, 0
%i6 = icmp ult i64 %i4, %i
%i7 = and i1 %i5, %i6
%i8 = zext i1 %i7 to i64
store i64 %i4, ptr %arg2, align 8
store i64 %i8, ptr %arg, align 8
ret i32 0
}