[clang] MangledSymbol: remove pointless copy of vector

[sookach]

This pr addresses #87255 adds a std::move call to the names in MangledSymbol's constructor.

[github-actions]

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

[llvmbot]

@llvm/pr-subscribers-clang

Author: Andrew Sukach (soukatch)

Changes

This pr addresses #87255 adds a std::move call to the names in MangledSymbol's constructor.

---

Full diff: https://github.com/llvm/llvm-project/pull/90012.diff

1 Files Affected:

• (modified) clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp (+2-1)

diff --git a/clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp b/clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp
index d58f5bb0919906..81a827dba26b90 100644
--- a/clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp
+++ b/clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp
@@ -33,7 +33,8 @@ class InterfaceStubFunctionsConsumer : public ASTConsumer {
 
     MangledSymbol(const std::string &ParentName, uint8_t Type, uint8_t Binding,
                   std::vector<std::string> Names)
-        : ParentName(ParentName), Type(Type), Binding(Binding), Names(Names) {}
+        : ParentName(ParentName), Type(Type), Binding(Binding),
+          Names(std::move(Names)) {}
   };
   using MangledSymbols = std::map<const NamedDecl *, MangledSymbol>;
 

[sookach]

@dcb314 @shafik @EugeneZelenko Please let me know if this change looks good. Thanks!

[shafik]

LGTM

[sookach]

Looking at the logs, and the error seems to be unrelated to the changes made
https://buildkite.com/llvm-project/clang-ci/builds/16430#018f132d-506e-440c-b18b-fed98237def9/54-5446

[shafik]

Looking at the logs, and the error seems to be unrelated to the changes made https://buildkite.com/llvm-project/clang-ci/builds/16430#018f132d-506e-440c-b18b-fed98237def9/54-5446

You can try using --allow-empty to do an empty commit to kick off the build again.

[Endilll]

@shafik I wonder how checking size of a vector is now considered an expensive check.
(I stumbled upon it while reviewing)

llvm-project/clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp

Lines 99 to 101 in 47682e4

	#ifdef EXPENSIVE_CHECKS
	assert(MangledNames.size() <= 1 && "Expected only one name mangling.");
	#endif

[Endilll]

Thank you for spotting and fixing this!

[sookach]

@AaronBallman would it be possible to get an approval while all the checks are green? Thanks!

[AaronBallman]

LGTM!

[github-actions]

@soukatch Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested
by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as
the builds can include changes from many authors. It is not uncommon for your
change to be included in a build that fails due to someone else's changes, or
infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself.
This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

[sookach]

Thank you everyone for the reviews!

[AaronBallman]

Thank you everyone for the reviews!

Thank you for the improvement!