Skip to content

[lldb] Fixed the test TestDyldLaunchLinux #92080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2024

Conversation

slydiman
Copy link
Contributor

Install a.out and libsignal_file.so to the remote target if necessary.

Install a.out and libsignal_file.so to the remote target if necessary.
@slydiman slydiman requested a review from JDevlieghere as a code owner May 14, 2024 08:11
@llvmbot llvmbot added the lldb label May 14, 2024
@llvmbot
Copy link
Member

llvmbot commented May 14, 2024

@llvm/pr-subscribers-lldb

Author: Dmitry Vasilyev (slydiman)

Changes

Install a.out and libsignal_file.so to the remote target if necessary.


Full diff: https://github.com/llvm/llvm-project/pull/92080.diff

1 Files Affected:

  • (modified) lldb/test/API/functionalities/dyld-launch-linux/TestDyldLaunchLinux.py (+5-1)
diff --git a/lldb/test/API/functionalities/dyld-launch-linux/TestDyldLaunchLinux.py b/lldb/test/API/functionalities/dyld-launch-linux/TestDyldLaunchLinux.py
index 26360c20db1e2..016b60ec88111 100644
--- a/lldb/test/API/functionalities/dyld-launch-linux/TestDyldLaunchLinux.py
+++ b/lldb/test/API/functionalities/dyld-launch-linux/TestDyldLaunchLinux.py
@@ -7,6 +7,7 @@
 
 from lldbsuite.test.decorators import *
 from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
 
 
 class TestLinux64LaunchingViaDynamicLoader(TestBase):
@@ -39,11 +40,14 @@ def test(self):
         breakpoint_shared_library = target.BreakpointCreateBySourceRegex(
             "get_signal_crash", lldb.SBFileSpec("signal_file.cpp")
         )
+        inferior_exe_path = lldbutil.install_to_target(self, self.getBuildArtifact("a.out"))
+        lldbutil.install_to_target(self, self.getBuildArtifact("libsignal_file.so"))
+        
         launch_info = lldb.SBLaunchInfo(
             [
                 "--library-path",
                 self.get_process_working_directory(),
-                self.getBuildArtifact("a.out"),
+                inferior_exe_path,
             ]
         )
         launch_info.SetWorkingDirectory(self.get_process_working_directory())

Copy link

github-actions bot commented May 14, 2024

✅ With the latest revision this PR passed the Python code formatter.

@slydiman slydiman merged commit ac42f76 into llvm:main May 14, 2024
4 checks passed
@slydiman slydiman deleted the fix-lldb-test-TestDyldLaunchLinux branch July 25, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants