[lldb] Fixed the test TestThreadStates when run with a remote target

[slydiman]

self.wait_for_running_event(process) is always called after self.runCmd("continue"). It is strange to expect eStateConnected here. This test failed in case of a remote target. The correct state is eStateRunning. Removed incorrect checking.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: Dmitry Vasilyev (slydiman)

Changes

self.wait_for_running_event(process) is always called after self.runCmd("continue"). It is strange to expect eStateConnected here. This test failed in case of a remote target. The correct state is eStateRunning. Removed incorrect checking.

---

Full diff: https://github.com/llvm/llvm-project/pull/92086.diff

1 Files Affected:

• (modified) lldb/test/API/functionalities/thread/state/TestThreadStates.py (-4)

diff --git a/lldb/test/API/functionalities/thread/state/TestThreadStates.py b/lldb/test/API/functionalities/thread/state/TestThreadStates.py
index f4c17df523382..4dbe230c0ce85 100644
--- a/lldb/test/API/functionalities/thread/state/TestThreadStates.py
+++ b/lldb/test/API/functionalities/thread/state/TestThreadStates.py
@@ -102,10 +102,6 @@ def thread_state_after_breakpoint_test(self):
 
     def wait_for_running_event(self, process):
         listener = self.dbg.GetListener()
-        if lldb.remote_platform:
-            lldbutil.expect_state_changes(
-                self, listener, process, [lldb.eStateConnected]
-            )
         lldbutil.expect_state_changes(self, listener, process, [lldb.eStateRunning])
 
     def thread_state_after_continue_test(self):

[labath]

I'm pretty sure lldb was sending these events at some point, but that could have change since then. I slightly surprised that this wasn't caught before as that would mean noone is running these tests remotely.

Jonas, are you running lldb tests in remote configurations?

[JDevlieghere]

I'm pretty sure lldb was sending these events at some point, but that could have change since then. I slightly surprised that this wasn't caught before as that would mean noone is running these tests remotely.

Jonas, are you running lldb tests in remote configurations?

Yup, I am. Looks like all these tests are marked as @skipIfDarwin so that would explain why it wasn't caught before.

[labath]

Ah, that explains it. Ship it then.