Skip to content

[lldb] Fix ThreadPlanStepOverRange name in log message #94611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

mariannems
Copy link
Contributor

No description provided.

@mariannems mariannems requested a review from JDevlieghere as a code owner June 6, 2024 13:02
@llvmbot llvmbot added the lldb label Jun 6, 2024
@llvmbot
Copy link
Member

llvmbot commented Jun 6, 2024

@llvm/pr-subscribers-lldb

Author: Marianne Mailhot-Sarrasin (mariannems)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/94611.diff

1 Files Affected:

  • (modified) lldb/source/Target/ThreadPlanStepOverRange.cpp (+1-1)
diff --git a/lldb/source/Target/ThreadPlanStepOverRange.cpp b/lldb/source/Target/ThreadPlanStepOverRange.cpp
index 84f282f1de520..3fe02e0bf4faf 100644
--- a/lldb/source/Target/ThreadPlanStepOverRange.cpp
+++ b/lldb/source/Target/ThreadPlanStepOverRange.cpp
@@ -355,7 +355,7 @@ bool ThreadPlanStepOverRange::DoPlanExplainsStop(Event *event_ptr) {
       return_value = NextRangeBreakpointExplainsStop(stop_info_sp);
     } else {
       if (log)
-        log->PutCString("ThreadPlanStepInRange got asked if it explains the "
+        log->PutCString("ThreadPlanStepOverRange got asked if it explains the "
                         "stop for some reason other than step.");
       return_value = false;
     }

Copy link
Collaborator

@DavidSpickett DavidSpickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there a LOG macro that adds the function name but I forget exactly what, this LGTM as is.

@DavidSpickett
Copy link
Collaborator

Ah ignore that, the function is in fact DoPlanExplainsStop, I was looking at the class name.

@DavidSpickett DavidSpickett merged commit d9e6a56 into llvm:main Jun 6, 2024
7 checks passed
@DavidSpickett
Copy link
Collaborator

Thanks for the fix! These small mistakes are always annoying when you're going through a complicated log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants