Skip to content

[ORC][MachO] Register objc protolist, protorefs, nlclslist metadata sections #95144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

benlangmuir
Copy link
Collaborator

Add missing __DATA sections that the objc runtime expects to register. This fixes running objc code that makes use of @protocol references and __attribute__((objc_nonlazy_class)) classes.

rdar://129368761

…ections

Add missing __DATA sections that the objc runtime expects to register.
This fixes running objc code that makes use of `@protocol` references and
`__attribute__((objc_nonlazy_class))` classes.

rdar://129368761
Copy link
Contributor

@lhames lhames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Ben!

@benlangmuir benlangmuir merged commit 0f286f8 into llvm:main Jun 11, 2024
7 of 8 checks passed
@benlangmuir benlangmuir deleted the orc-objc-missing-metadata branch June 11, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants