Skip to content

[lldb][test] Enable static linking with libcxx for import-std-module tests #98701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
USE_LIBCPP := 1
CXX_SOURCES := main.cpp

ifneq ($(OS),Darwin)
LD_EXTRAS := -Xlinker --whole-archive -Xlinker --allow-multiple-definition
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on why this is necessary? Example test failures would be great

endif

include Makefile.rules
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
USE_LIBCPP := 1
CXX_SOURCES := main.cpp

ifneq ($(OS),Darwin)
LD_EXTRAS := -Xlinker --whole-archive -Xlinker --allow-multiple-definition
endif

include Makefile.rules
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
USE_LIBCPP := 1
CXX_SOURCES := main.cpp

ifneq ($(OS),Darwin)
LD_EXTRAS := -Xlinker --whole-archive -Xlinker --allow-multiple-definition
endif

include Makefile.rules
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
USE_LIBCPP := 1
CXX_SOURCES := main.cpp

ifneq ($(OS),Darwin)
LD_EXTRAS := -Xlinker --whole-archive -Xlinker --allow-multiple-definition
endif

include Makefile.rules
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
USE_LIBCPP := 1
CXX_SOURCES := main.cpp

ifneq ($(OS),Darwin)
LD_EXTRAS := -Xlinker --whole-archive -Xlinker --allow-multiple-definition
endif

include Makefile.rules
Loading