Skip to content

[emacs] Fix autoloading for llvm-mir-mode #98984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

jian-lin
Copy link
Contributor

Without this patch, the autoloading of the major mode llvm-mir-mode is not generated, which breaks its autoloading functionality.

To test this patch, use the following command to generate an autoload file:

cd llvm/utils/emacs
emacs --quick --batch --load=package --eval='(package-generate-autoloads "llvm-mir-mode" ".")'

Diff of generated autoload files is as follows:

> (autoload 'llvm-mir-mode "llvm-mir-mode" "\
> A major mode for editing LLVM MIR files.
> 
> (fn)" t)

CC @bogner for review

Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@jian-lin
Copy link
Contributor Author

@goldsteinn @lukel97 tagging people who have touched some Emacs stuff to review this, apologies in advance if you aren't the right persons for this.

@lukel97 lukel97 requested review from bogner, lukel97 and goldsteinn July 17, 2024 09:47
Copy link
Contributor

@lukel97 lukel97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@goldsteinn
Copy link
Contributor

LGTM

@goldsteinn
Copy link
Contributor

Do you need someone to merge this for you?

@jian-lin
Copy link
Contributor Author

Do you need someone to merge this for you?

Yes. It's my first contribution to this project and I do not think I can merge things myself.

@goldsteinn goldsteinn merged commit d2bfc2b into llvm:main Jul 17, 2024
8 checks passed
Copy link

@jian-lin Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested
by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as
the builds can include changes from many authors. It is not uncommon for your
change to be included in a build that fails due to someone else's changes, or
infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself.
This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

@jian-lin jian-lin deleted the pr/fix-autoload branch July 17, 2024 11:21
yuxuanchen1997 pushed a commit that referenced this pull request Jul 25, 2024
Summary:
Without this patch, the autoloading of the major mode `llvm-mir-mode` is
not generated, which breaks its autoloading functionality.

To test this patch, use the following command to generate an autoload
file:

```console
cd llvm/utils/emacs
emacs --quick --batch --load=package --eval='(package-generate-autoloads "llvm-mir-mode" ".")'
```

Diff of generated autoload files is as follows:

```diff
> (autoload 'llvm-mir-mode "llvm-mir-mode" "\
> A major mode for editing LLVM MIR files.
> 
> (fn)" t)
```

CC @bogner for review

Test Plan: 

Reviewers: 

Subscribers: 

Tasks: 

Tags: 


Differential Revision: https://phabricator.intern.facebook.com/D60251703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants