-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[emacs] Fix autoloading for llvm-mir-mode #98984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write If you have received no comments on your PR for a week, you can request a review If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
@goldsteinn @lukel97 tagging people who have touched some Emacs stuff to review this, apologies in advance if you aren't the right persons for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
LGTM |
Do you need someone to merge this for you? |
Yes. It's my first contribution to this project and I do not think I can merge things myself. |
@jian-lin Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested Please check whether problems have been caused by your change specifically, as How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
Summary: Without this patch, the autoloading of the major mode `llvm-mir-mode` is not generated, which breaks its autoloading functionality. To test this patch, use the following command to generate an autoload file: ```console cd llvm/utils/emacs emacs --quick --batch --load=package --eval='(package-generate-autoloads "llvm-mir-mode" ".")' ``` Diff of generated autoload files is as follows: ```diff > (autoload 'llvm-mir-mode "llvm-mir-mode" "\ > A major mode for editing LLVM MIR files. > > (fn)" t) ``` CC @bogner for review Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60251703
Without this patch, the autoloading of the major mode
llvm-mir-mode
is not generated, which breaks its autoloading functionality.To test this patch, use the following command to generate an autoload file:
Diff of generated autoload files is as follows:
CC @bogner for review