[lit][NFC] Avoid unintended -EMPTY suffix in check prefix #99690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4
|
@llvm/pr-subscribers-testing-tools Author: Paul Kirth (ilovepi) ChangesFileCheck has special handline for the Full diff: https://github.com/llvm/llvm-project/pull/99690.diff 1 Files Affected:
diff --git a/llvm/utils/lit/tests/Inputs/shtest-env/env-calls-env.txt b/llvm/utils/lit/tests/Inputs/shtest-env/env-calls-env.txt
index e4997b1250ed3..26150c413dc03 100644
--- a/llvm/utils/lit/tests/Inputs/shtest-env/env-calls-env.txt
+++ b/llvm/utils/lit/tests/Inputs/shtest-env/env-calls-env.txt
@@ -1,10 +1,10 @@
# Check that internal env can call internal env.
# RUN: env env %{python} print_environment.py \
-# RUN: | FileCheck -check-prefix=CHECK-2-EMPTY %s
+# RUN: | FileCheck -check-prefix=CHECK-2-EMPTY-ARGS %s
#
-# CHECK-2-EMPTY: BAR = 2
-# CHECK-2-EMPTY: FOO = 1
+# CHECK-2-EMPTY-ARGS: BAR = 2
+# CHECK-2-EMPTY-ARGS: FOO = 1
# RUN: env FOO=2 env BAR=1 %{python} print_environment.py \
# RUN: | FileCheck -check-prefix=CHECK-2-VAL %s
|
|
CC: @Harini0924 |
ilovepi
deleted the
users/ilovepi/spr/litnfc-avoid-unintended-empty-suffix-in-check-prefix
branch
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
FileCheck has special handline for the `-EMPTY` suffix, that should match empty lines. Overloading the suffix can be a source of confusion when reading tests. Additionally, the current implementation seems to match the following expressions, which appears to be a bug in FileCheck.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileCheck has special handline for the
-EMPTYsuffix, that shouldmatch empty lines. Overloading the suffix can be a source of confusion
when reading tests. Additionally, the current implementation seems to
match the following expressions, which appears to be a bug in FileCheck.