Don't always add tools/test as this ignores TEST_SUITE_SUBDIRS.

Unconditionally adding tools/test breaks setups using
TEST_SUITE_SUBDIRS, including PGO builds which will try to build the
test binaries without collecting profile info for them.

Separately add tools/test when collecting test suite subdirs.

Author: fhahn

CMakeLists.txt

@@ -360,6 +360,8 @@ if(NOT TEST_SUITE_SUBDIRS)
   if(NOT TEST_SUITE_FORTRAN)
     list(REMOVE_ITEM TEST_SUITE_SUBDIRS Fortran)
   endif()
+  # Separately add tests for tools.
+  list(APPEND TEST_SUITE_SUBDIRS tools/test)
   set(TEST_SUITE_SUBDIRS "${TEST_SUITE_SUBDIRS}")
 endif()
 set(TEST_SUITE_SUBDIRS "${TEST_SUITE_SUBDIRS}" CACHE STRING

tools/CMakeLists.txt

@@ -41,7 +41,3 @@ else()
 endif()
 
 add_executable(not ${CMAKE_CURRENT_SOURCE_DIR}/not.cpp)
-
-# Always add the test subdirectory. After all, we really should test these
-# tools.
-add_subdirectory(test)