[Fortran/gfortran] Disable flaky test random_init_2.f90 (#153)

luporl · web-flow · commit e93f828c400e · 2024-08-22T10:02:12.000+01:00
The random_init_2.f90 test is flaky and may fail sometimes, even when no Fortran/Flang changes are made: - https://lab.llvm.org/buildbot/#/builders/143/builds/1236 - https://lab.llvm.org/buildbot/#/builders/17/builds/2058 Looking at the test source, it seems there is no guarantee that 2 distinct random numbers will never collide. This is made worse by multiplying them by 1e6 and converting them to integer, which could make distinct but close enough single-precision floating-point numbers give the same result and fail the test.
diff --git a/Fortran/gfortran/regression/DisabledFiles.cmake b/Fortran/gfortran/regression/DisabledFiles.cmake
@@ -1748,4 +1748,7 @@ file(GLOB FAILING_FILES CONFIGURE_DEPENDS
   # __trampoline_setup. This is probably an unrelated issue, but as a quick fix
   # for the buildbot, this is disabled.
   internal_dummy_2.f08
+
+  # These are flaky tests, which may fail sometimes.
+  random_init_2.f90
 )

Original file line number	Diff line number	Diff line change
`@@ -1748,4 +1748,7 @@ file(GLOB FAILING_FILES CONFIGURE_DEPENDS`
`1748`	`1748`	`# __trampoline_setup. This is probably an unrelated issue, but as a quick fix`
`1749`	`1749`	`# for the buildbot, this is disabled.`
`1750`	`1750`	`internal_dummy_2.f08`
	`1751`	`+`
	`1752`	`+ # These are flaky tests, which may fail sometimes.`
	`1753`	`+ random_init_2.f90`
`1751`	`1754`	`)`