[llvm-test-suite][tools] Fix not utility to avoid std::system #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarunprabhu
requested review from
jroelofs,
tblah,
jeanPerier,
AlexisPerry and
yiwu0b11
jroelofs
approved these changes
Jul 22, 2024
tools/not.cpp
Outdated
| #include <spawn.h> | ||
| #include <sys/wait.h> | ||
| #endif | ||
|
|
||
| #ifdef __APPLE__ | ||
| #include <TargetConditionals.h> |
There was a problem hiding this comment.
TargetConditionals.h is only needed for TARGET_OS_IPHONE, so I think we can drop this.
There was a problem hiding this comment.
Should the #ifdef be changed to TARGET_OS_IPHONE then?
Avoid using std::system on Unix systems. Some systems such as Ubuntu return a different error code from calls to std::system. Use posix_spawn to avoid having to special case these. std::system is now only used on Windows.
tarunprabhu
force-pushed
the
fix-not-for-ubuntu
branch
from
1e206b6 to
7acc1ea
Compare
jeanPerier
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Thank you @tarunprabhu. I am no expert in those if-def, but this patch ran OK on my Ubuntu machine.
jroelofs
reviewed
Jul 23, 2024
jroelofs
reviewed
Jul 23, 2024
jroelofs
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid using std::system on Unix systems. Some systems such as Ubuntu return a different error code from calls to std::system. Use posix_spawn to avoid having to special case these. std::system is now only used on Windows.
@jeanPerier identified this as an issue here
@jroelofs, could you check that this doesn't cause any issues on iOS.