Skip to content

Add a benchmark for aarch64's __init_cpu_features_resolver() #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

jroelofs
Copy link
Contributor

@jroelofs jroelofs commented Feb 4, 2024

No description provided.

@labrinea
Copy link
Contributor

Thanks for writing these tests. Do they need adaptation for other operating systems?

@jroelofs
Copy link
Contributor Author

Yes. There are some subtle differences in the signature of __init_cpu_features_resolver(), where on some platforms it takes a hwcap + __ifunc_arg_t*, and others it takes no arguments.

Copy link
Contributor

@labrinea labrinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I'll write the equivalent linux tests at some point.

@jroelofs jroelofs merged commit f234989 into llvm:main Feb 12, 2024
@jroelofs jroelofs deleted the jroelofs/init-cpu-features-benchmark branch February 12, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants