Use an early exit

DougGregor · DougGregor · commit 9e3e6e81433e · 2024-03-01T13:02:00.000-08:00
diff --git a/lib/Sema/TypeCheckAttr.cpp b/lib/Sema/TypeCheckAttr.cpp
@@ -7343,10 +7343,11 @@ void AttributeChecker::visitStaticExclusiveOnlyAttr(
 }
 
 void AttributeChecker::visitWeakLinkedAttr(WeakLinkedAttr *attr) {
-  if (Ctx.LangOpts.Target.isOSBinFormatCOFF()) {
-    diagnoseAndRemoveAttr(attr, diag::attr_unsupported_on_target,
-                          attr->getAttrName(), Ctx.LangOpts.Target.str());
-  }
+  if (!Ctx.LangOpts.Target.isOSBinFormatCOFF())
+    return;
+
+  diagnoseAndRemoveAttr(attr, diag::attr_unsupported_on_target,
+                        attr->getAttrName(), Ctx.LangOpts.Target.str());
 }
 
 namespace {

Original file line number	Diff line number	Diff line change
`@@ -7343,10 +7343,11 @@ void AttributeChecker::visitStaticExclusiveOnlyAttr(`
`7343`	`7343`	`}`
`7344`	`7344`
`7345`	`7345`	`void AttributeChecker::visitWeakLinkedAttr(WeakLinkedAttr *attr) {`
`7346`		`- if (Ctx.LangOpts.Target.isOSBinFormatCOFF()) {`
`7347`		`- diagnoseAndRemoveAttr(attr, diag::attr_unsupported_on_target,`
`7348`		`- attr->getAttrName(), Ctx.LangOpts.Target.str());`
`7349`		`- }`
	`7346`	`+ if (!Ctx.LangOpts.Target.isOSBinFormatCOFF())`
	`7347`	`+ return;`
	`7348`	`+`
	`7349`	`+ diagnoseAndRemoveAttr(attr, diag::attr_unsupported_on_target,`
	`7350`	`+ attr->getAttrName(), Ctx.LangOpts.Target.str());`
`7350`	`7351`	`}`
`7351`	`7352`
`7352`	`7353`	`namespace {`