[stdlib] Fix key path components hashing.

dmcyk · dmcyk · commit ef91e2ec4099 · 2018-06-25T00:26:33.000+02:00
Removes shadowed `hasher` argument in component hashing.
diff --git a/stdlib/public/core/KeyPath.swift b/stdlib/public/core/KeyPath.swift
@@ -597,7 +597,6 @@ internal enum KeyPathComponent: Hashable {
 
   @_effects(releasenone)
   internal func hash(into hasher: inout Hasher) {
-    var hasher = hasher
     func appendHashFromArgument(
       _ argument: KeyPathComponent.ArgumentRef?
     ) {
diff --git a/test/stdlib/KeyPathImplementation.swift b/test/stdlib/KeyPathImplementation.swift
@@ -657,7 +657,10 @@ keyPathImpl.test("equality") {
     }
 
   expectNotEqual(s_c_z_p_x, s_c_z_p_y)
+  expectNotEqual(s_c_z_p_x.hashValue, s_c_z_p_y.hashValue)
+
   expectNotEqual(s_c_z_p_y, s_c_z_p_x)
+  expectNotEqual(s_c_z_p_y.hashValue, s_c_z_p_x.hashValue)
 
   // Different path type
   let s_c_z_p = ReferenceWritableKeyPath<S<S<String>>, Point>

Original file line number	Diff line number	Diff line change
`@@ -657,7 +657,10 @@ keyPathImpl.test("equality") {`
`657`	`657`	`}`
`658`	`658`
`659`	`659`	`expectNotEqual(s_c_z_p_x, s_c_z_p_y)`
	`660`	`+ expectNotEqual(s_c_z_p_x.hashValue, s_c_z_p_y.hashValue)`
	`661`	`+`
`660`	`662`	`expectNotEqual(s_c_z_p_y, s_c_z_p_x)`
	`663`	`+ expectNotEqual(s_c_z_p_y.hashValue, s_c_z_p_x.hashValue)`
`661`	`664`
`662`	`665`	`// Different path type`
`663`	`666`	`let s_c_z_p = ReferenceWritableKeyPath<S<S<String>>, Point>`