API should follow RequireSignInView (go-gitea#8654)

lunny · lunny · commit 1cc00d1e4bea · 2019-10-24T14:04:30.000+08:00
diff --git a/routers/api/v1/api.go b/routers/api/v1/api.go
@@ -860,7 +860,7 @@ func RegisterRoutes(m *macaron.Macaron) {
 		m.Group("/topics", func() {
 			m.Get("/search", repo.TopicSearch)
 		})
-	}, securityHeaders(), context.APIContexter(), sudo())
+	}, securityHeaders(), reqTokenBySetting(), context.APIContexter(), sudo())
 }
 
 func securityHeaders() macaron.Handler {
@@ -872,3 +872,10 @@ func securityHeaders() macaron.Handler {
 		})
 	}
 }
+
+func reqTokenBySetting() macaron.Handler {
+	if setting.Service.RequireSignInView {
+		return reqToken()
+	}
+	return func(ctx *macaron.Context) {}
+}

Original file line number	Diff line number	Diff line change
`@@ -860,7 +860,7 @@ func RegisterRoutes(m *macaron.Macaron) {`
`860`	`860`	`m.Group("/topics", func() {`
`861`	`861`	`m.Get("/search", repo.TopicSearch)`
`862`	`862`	`})`
`863`		`- }, securityHeaders(), context.APIContexter(), sudo())`
	`863`	`+ }, securityHeaders(), reqTokenBySetting(), context.APIContexter(), sudo())`
`864`	`864`	`}`
`865`	`865`
`866`	`866`	`func securityHeaders() macaron.Handler {`
`@@ -872,3 +872,10 @@ func securityHeaders() macaron.Handler {`
`872`	`872`	`})`
`873`	`873`	`}`
`874`	`874`	`}`
	`875`	`+`
	`876`	`+func reqTokenBySetting() macaron.Handler {`
	`877`	`+ if setting.Service.RequireSignInView {`
	`878`	`+ return reqToken()`
	`879`	`+ }`
	`880`	`+ return func(ctx *macaron.Context) {}`
	`881`	`+}`