Skip to content

Commit 109f5ca

Browse files
MiYanniMiYanni
authored
Merge pull request #4 from MiYanni/NetCoreWarningsV2
Net core warnings v2
2 parents 2e1624d + 928555c commit 109f5ca

File tree

225 files changed

+1066
-814
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

225 files changed

+1066
-814
lines changed

‎Azure.PowerShell.Netcore.sln

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Commands.Aks.Netcore", "src
4545
EndProject
4646
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Common.Strategies.Netcore", "src\ResourceManager\Common\Commands.Common.Strategies\Common.Strategies.Netcore.csproj", "{77492655-0086-49E8-B941-7C3E9D5448E9}"
4747
EndProject
48-
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Commands.Common.Compute.Netcore", "src\Common\Commands.Common.Compute\Commands.Common.Compute.Netcore.csproj", "{5E5D1F8E-92C8-40EB-AABA-DFD12AFD6D0A}"
48+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Common.Compute.Netcore", "src\Common\Commands.Common.Compute\Common.Compute.Netcore.csproj", "{5E5D1F8E-92C8-40EB-AABA-DFD12AFD6D0A}"
4949
EndProject
5050
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Commands.AnalysisServices.Netcore", "src\ResourceManager\AnalysisServices\Commands.AnalysisServices\Commands.AnalysisServices.Netcore.csproj", "{C348F9F1-3CF4-4B98-91C7-C13C0386DBC7}"
5151
EndProject

‎src/Azure.PowerShell.Netcore.Test.sln

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Commands.Profile.Test.Netco
77
EndProject
88
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Common.ResourceManager.ScenarioTests.Netcore", "ResourceManager\Common\Commands.ScenarioTests.ResourceManager.Common\Common.ResourceManager.ScenarioTests.Netcore.csproj", "{624FE5CE-0F46-4A0A-9A1B-54D5724B7F96}"
99
EndProject
10-
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Commands.Common.Tests.Netcore", "Common\Commands.Common.Tests\Commands.Common.Tests.Netcore.csproj", "{B0EF35E9-2D7A-4AAE-8A1A-728B6CC8524B}"
10+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Common.Tests.Netcore", "Common\Commands.Common.Tests\Common.Tests.Netcore.csproj", "{B0EF35E9-2D7A-4AAE-8A1A-728B6CC8524B}"
1111
EndProject
1212
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Common.Authentication.Abstractions.Netcore", "Common\Commands.Common.Authentication.Abstractions\Common.Authentication.Abstractions.Netcore.csproj", "{5C1894D4-47AA-4B77-AF92-33B40CC28C31}"
1313
EndProject

‎src/Common/Commands.Common.Authentication.Abstractions/Common.Authentication.Abstractions.Netcore.csproj

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -9,32 +9,30 @@
99
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
1010
</PropertyGroup>
1111

12+
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
13+
<DelaySign>false</DelaySign>
14+
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
15+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
16+
<WarningsAsErrors />
17+
</PropertyGroup>
18+
1219
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
13-
<SignAssembly>True</SignAssembly>
14-
<DelaySign>True</DelaySign>
20+
<SignAssembly>true</SignAssembly>
21+
<DelaySign>true</DelaySign>
1522
<AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile>
1623
<DefineConstants>TRACE;RELEASE;NETSTANDARD;SIGN</DefineConstants>
17-
</PropertyGroup>
18-
19-
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
20-
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
21-
<DelaySign>false</DelaySign>
24+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
25+
<WarningsAsErrors />
2226
</PropertyGroup>
2327

2428
<ItemGroup>
2529
<PackageReference Include="Microsoft.Rest.ClientRuntime.Azure.Authentication" Version="2.4.0" />
26-
<PackageReference Include="System.Collections.Specialized" Version="4.3.0" />
27-
<PackageReference Include="System.Reflection" Version="4.3.0" />
28-
<PackageReference Include="System.Security.SecureString" Version="4.3.0" />
29-
<PackageReference Include="System.Xml.XmlDocument" Version="4.3.0" />
30-
<PackageReference Include="System.Xml.XmlSerializer" Version="4.3.0" />
31-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.7.0" />
3230
</ItemGroup>
3331

3432
<ItemGroup>
3533
<Compile Update="Properties\Resources.Designer.cs">
36-
<DesignTime>True</DesignTime>
37-
<AutoGen>True</AutoGen>
34+
<DesignTime>true</DesignTime>
35+
<AutoGen>true</AutoGen>
3836
<DependentUpon>Resources.resx</DependentUpon>
3937
</Compile>
4038
</ItemGroup>

‎src/Common/Commands.Common.Authentication.Test/Commands.Common.Authentication.Test.Netcore.csproj

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,17 @@
1212
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
1313
<DelaySign>false</DelaySign>
1414
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
15+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
16+
<WarningsAsErrors />
1517
</PropertyGroup>
1618

1719
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
1820
<SignAssembly>true</SignAssembly>
1921
<DelaySign>true</DelaySign>
2022
<AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile>
2123
<DefineConstants>TRACE;RELEASE;NETSTANDARD;SIGN</DefineConstants>
24+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
25+
<WarningsAsErrors />
2226
</PropertyGroup>
2327

2428
<ItemGroup>

‎src/Common/Commands.Common.Authentication/Authentication/UserTokenProvider.Netcore.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@ namespace Microsoft.Azure.Commands.Common.Authentication
2929
/// </summary>
3030
internal class UserTokenProvider : ITokenProvider
3131
{
32-
Action<string> _promptAction = null;
33-
3432
public UserTokenProvider()
3533
{
3634
}

‎src/Common/Commands.Common.Authentication/Common.Authentication.Netcore.csproj

Lines changed: 13 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -9,26 +9,21 @@
99
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
1010
</PropertyGroup>
1111

12-
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
13-
<SignAssembly>True</SignAssembly>
14-
<DelaySign>True</DelaySign>
15-
<AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile>
16-
<DefineConstants>TRACE;RELEASE;NETSTANDARD;SIGN</DefineConstants>
17-
</PropertyGroup>
18-
1912
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
20-
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
2113
<DelaySign>false</DelaySign>
14+
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
15+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
16+
<WarningsAsErrors />
2217
</PropertyGroup>
2318

24-
<ItemGroup>
25-
<PackageReference Include="System.Collections.Specialized" Version="4.3.0" />
26-
<PackageReference Include="System.Reflection" Version="4.3.0" />
27-
<PackageReference Include="System.Security.SecureString" Version="4.3.0" />
28-
<PackageReference Include="System.Xml.XmlDocument" Version="4.3.0" />
29-
<PackageReference Include="System.Xml.XmlSerializer" Version="4.3.0" />
30-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.7.0" />
31-
</ItemGroup>
19+
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
20+
<SignAssembly>true</SignAssembly>
21+
<DelaySign>true</DelaySign>
22+
<AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile>
23+
<DefineConstants>TRACE;RELEASE;NETSTANDARD;SIGN</DefineConstants>
24+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
25+
<WarningsAsErrors />
26+
</PropertyGroup>
3227

3328
<ItemGroup>
3429
<Compile Remove="Authentication\ConsoleParentWindow.cs" />
@@ -45,8 +40,8 @@
4540

4641
<ItemGroup>
4742
<Compile Update="Properties\Resources.Designer.cs">
48-
<DesignTime>True</DesignTime>
49-
<AutoGen>True</AutoGen>
43+
<DesignTime>true</DesignTime>
44+
<AutoGen>true</AutoGen>
5045
<DependentUpon>Resources.resx</DependentUpon>
5146
</Compile>
5247
</ItemGroup>

‎src/Common/Commands.Common.Authorization/Common.Authorization.Netcore.csproj

Lines changed: 13 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -9,25 +9,21 @@
99
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
1010
</PropertyGroup>
1111

12-
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
13-
<SignAssembly>True</SignAssembly>
14-
<DelaySign>True</DelaySign>
15-
<AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile>
16-
<DefineConstants>TRACE;RELEASE;NETSTANDARD;SIGN</DefineConstants>
17-
</PropertyGroup>
18-
1912
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
20-
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
2113
<DelaySign>false</DelaySign>
14+
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
15+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
16+
<WarningsAsErrors />
2217
</PropertyGroup>
2318

24-
<ItemGroup>
25-
<PackageReference Include="System.Collections.Specialized" Version="4.3.0" />
26-
<PackageReference Include="System.Reflection" Version="4.3.0" />
27-
<PackageReference Include="System.Security.SecureString" Version="4.3.0" />
28-
<PackageReference Include="System.Xml.XmlDocument" Version="4.3.0" />
29-
<PackageReference Include="System.Xml.XmlSerializer" Version="4.3.0" />
30-
</ItemGroup>
19+
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
20+
<SignAssembly>true</SignAssembly>
21+
<DelaySign>true</DelaySign>
22+
<AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile>
23+
<DefineConstants>TRACE;RELEASE;NETSTANDARD;SIGN</DefineConstants>
24+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
25+
<WarningsAsErrors />
26+
</PropertyGroup>
3127

3228
<ItemGroup>
3329
<ProjectReference Include="..\Commands.Common\Common.Netcore.csproj" />
@@ -36,8 +32,8 @@
3632

3733
<ItemGroup>
3834
<Compile Update="Properties\Resources.Designer.cs">
39-
<DesignTime>True</DesignTime>
40-
<AutoGen>True</AutoGen>
35+
<DesignTime>true</DesignTime>
36+
<AutoGen>true</AutoGen>
4137
<DependentUpon>Resources.resx</DependentUpon>
4238
</Compile>
4339
</ItemGroup>

‎src/Common/Commands.Common.Compute.Tests/Commands.Common.Compute.Tests.Netcore.csproj renamed to ‎src/Common/Commands.Common.Compute.Tests/Common.Compute.Tests.Netcore.csproj

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,17 @@
1212
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
1313
<DelaySign>false</DelaySign>
1414
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
15+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
16+
<WarningsAsErrors />
1517
</PropertyGroup>
1618

1719
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
1820
<SignAssembly>true</SignAssembly>
1921
<DelaySign>true</DelaySign>
2022
<AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile>
2123
<DefineConstants>TRACE;RELEASE;NETSTANDARD;SIGN</DefineConstants>
24+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
25+
<WarningsAsErrors />
2226
</PropertyGroup>
2327

2428
<ItemGroup>

‎src/Common/Commands.Common.Compute/Commands.Common.Compute.Netcore.csproj renamed to ‎src/Common/Commands.Common.Compute/Common.Compute.Netcore.csproj

Lines changed: 11 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -9,25 +9,21 @@
99
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
1010
</PropertyGroup>
1111

12-
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
13-
<SignAssembly>True</SignAssembly>
14-
<DelaySign>True</DelaySign>
15-
<AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile>
16-
<DefineConstants>TRACE;RELEASE;NETSTANDARD;SIGN</DefineConstants>
17-
</PropertyGroup>
18-
1912
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
20-
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
2113
<DelaySign>false</DelaySign>
14+
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
15+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
16+
<WarningsAsErrors />
2217
</PropertyGroup>
2318

24-
<ItemGroup >
25-
<PackageReference Include="System.Collections.Specialized" Version="4.3.0" />
26-
<PackageReference Include="System.Reflection" Version="4.3.0" />
27-
<PackageReference Include="System.Security.SecureString" Version="4.3.0" />
28-
<PackageReference Include="System.Xml.XmlDocument" Version="4.3.0" />
29-
<PackageReference Include="System.Xml.XmlSerializer" Version="4.3.0" />
30-
</ItemGroup>
19+
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
20+
<SignAssembly>true</SignAssembly>
21+
<DelaySign>true</DelaySign>
22+
<AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile>
23+
<DefineConstants>TRACE;RELEASE;NETSTANDARD;SIGN</DefineConstants>
24+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
25+
<WarningsAsErrors />
26+
</PropertyGroup>
3127

3228
<ItemGroup>
3329
<ProjectReference Include="..\Commands.Common\Common.Netcore.csproj" />

‎src/Common/Commands.Common.Graph.RBAC/Common.Rbac.Netcore.csproj

Lines changed: 13 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -9,25 +9,21 @@
99
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
1010
</PropertyGroup>
1111

12-
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
13-
<SignAssembly>True</SignAssembly>
14-
<DelaySign>True</DelaySign>
15-
<AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile>
16-
<DefineConstants>TRACE;RELEASE;NETSTANDARD;SIGN</DefineConstants>
17-
</PropertyGroup>
18-
1912
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
20-
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
2113
<DelaySign>false</DelaySign>
14+
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
15+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
16+
<WarningsAsErrors />
2217
</PropertyGroup>
2318

24-
<ItemGroup >
25-
<PackageReference Include="System.Collections.Specialized" Version="4.3.0" />
26-
<PackageReference Include="System.Reflection" Version="4.3.0" />
27-
<PackageReference Include="System.Security.SecureString" Version="4.3.0" />
28-
<PackageReference Include="System.Xml.XmlDocument" Version="4.3.0" />
29-
<PackageReference Include="System.Xml.XmlSerializer" Version="4.3.0" />
30-
</ItemGroup>
19+
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
20+
<SignAssembly>true</SignAssembly>
21+
<DelaySign>true</DelaySign>
22+
<AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile>
23+
<DefineConstants>TRACE;RELEASE;NETSTANDARD;SIGN</DefineConstants>
24+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
25+
<WarningsAsErrors />
26+
</PropertyGroup>
3127

3228
<ItemGroup>
3329
<ProjectReference Include="..\Commands.Common\Common.Netcore.csproj" />
@@ -36,8 +32,8 @@
3632

3733
<ItemGroup>
3834
<Compile Update="Properties\Resources.Designer.cs">
39-
<DesignTime>True</DesignTime>
40-
<AutoGen>True</AutoGen>
35+
<DesignTime>true</DesignTime>
36+
<AutoGen>true</AutoGen>
4137
<DependentUpon>Resources.resx</DependentUpon>
4238
</Compile>
4339
</ItemGroup>

‎src/Common/Commands.Common.Network/Common.Network.Netcore.csproj

Lines changed: 13 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -9,35 +9,31 @@
99
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
1010
</PropertyGroup>
1111

12+
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
13+
<DelaySign>false</DelaySign>
14+
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
15+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
16+
<WarningsAsErrors />
17+
</PropertyGroup>
18+
1219
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
13-
<SignAssembly>True</SignAssembly>
14-
<DelaySign>True</DelaySign>
20+
<SignAssembly>true</SignAssembly>
21+
<DelaySign>true</DelaySign>
1522
<AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile>
1623
<DefineConstants>TRACE;RELEASE;NETSTANDARD;SIGN</DefineConstants>
24+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
25+
<WarningsAsErrors />
1726
</PropertyGroup>
1827

19-
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
20-
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
21-
<DelaySign>false</DelaySign>
22-
</PropertyGroup>
23-
24-
<ItemGroup >
25-
<PackageReference Include="System.Collections.Specialized" Version="4.3.0" />
26-
<PackageReference Include="System.Reflection" Version="4.3.0" />
27-
<PackageReference Include="System.Security.SecureString" Version="4.3.0" />
28-
<PackageReference Include="System.Xml.XmlDocument" Version="4.3.0" />
29-
<PackageReference Include="System.Xml.XmlSerializer" Version="4.3.0" />
30-
</ItemGroup>
31-
3228
<ItemGroup>
3329
<ProjectReference Include="..\Commands.Common\Common.Netcore.csproj" />
3430
<ProjectReference Include="..\..\ResourceManager\Common\Commands.ResourceManager.Common\Common.ResourceManager.Netcore.csproj" />
3531
</ItemGroup>
3632

3733
<ItemGroup>
3834
<Compile Update="Properties\Resources.Designer.cs">
39-
<DesignTime>True</DesignTime>
40-
<AutoGen>True</AutoGen>
35+
<DesignTime>true</DesignTime>
36+
<AutoGen>true</AutoGen>
4137
<DependentUpon>Resources.resx</DependentUpon>
4238
</Compile>
4339
</ItemGroup>

0 commit comments

Comments
 (0)