Skip to content

Commit 13fed1a

Browse files
authored
Merge pull request Azure#8657 from wastoresh/newskind
[Storage] Support new Storage Account Kind BlockBlobStorage
2 parents 0401cb6 + 2ea1c93 commit 13fed1a

File tree

7 files changed

+858
-2
lines changed

7 files changed

+858
-2
lines changed

src/Storage/Storage.Management.Test/ScenarioTests/StorageAccountTests.cs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,5 +127,12 @@ public void TestPipingNewUpdateAccount()
127127
{
128128
TestRunner.RunTestScript("Test-PipingNewUpdateAccount");
129129
}
130+
131+
[Fact]
132+
[Trait(Category.AcceptanceType, Category.CheckIn)]
133+
public void TestNewAzureStorageAccountBlockBlobStorage()
134+
{
135+
TestRunner.RunTestScript("Test-NewAzureStorageAccountBlockBlobStorage");
136+
}
130137
}
131138
}

src/Storage/Storage.Management.Test/ScenarioTests/StorageAccountTests.ps1

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -718,3 +718,41 @@ function Test-PipingNewUpdateAccount
718718
Clean-ResourceGroup $rgname
719719
}
720720
}
721+
722+
<#
723+
.SYNOPSIS
724+
Test New-AzureRmStorageAccountBlockBlobStorage
725+
.DESCRIPTION
726+
Smoke[Broken]Test
727+
#>
728+
function Test-NewAzureStorageAccountBlockBlobStorage
729+
{
730+
# Setup
731+
$rgname = Get-StorageManagementTestResourceName;
732+
733+
try
734+
{
735+
# Test
736+
$stoname = 'sto' + $rgname;
737+
$stotype = 'Premium_LRS';
738+
$kind = 'BlockBlobStorage'
739+
740+
$loc = Get-ProviderLocation ResourceManagement;
741+
New-AzureRmResourceGroup -Name $rgname -Location $loc;
742+
743+
New-AzureRmStorageAccount -ResourceGroupName $rgname -Name $stoname -Location $loc -Type $stotype -Kind $kind;
744+
$sto = Get-AzureRmStorageAccount -ResourceGroupName $rgname -Name $stoname;
745+
$stotype = 'PremiumLRS';
746+
Assert-AreEqual $stoname $sto.StorageAccountName;
747+
Assert-AreEqual $stotype $sto.Sku.Name;
748+
Assert-AreEqual $loc.ToLower().Replace(" ", "") $sto.Location;
749+
Assert-AreEqual $kind $sto.Kind;
750+
751+
Retry-IfException { Remove-AzureRmStorageAccount -Force -ResourceGroupName $rgname -Name $stoname; }
752+
}
753+
finally
754+
{
755+
# Cleanup
756+
Clean-ResourceGroup $rgname
757+
}
758+
}

src/Storage/Storage.Management.Test/SessionRecords/Microsoft.Azure.Commands.Management.Storage.Test.ScenarioTests.StorageAccountTests/TestNewAzureStorageAccountBlockBlobStorage.json

Lines changed: 807 additions & 0 deletions
Large diffs are not rendered by default.

src/Storage/Storage.Management/ChangeLog.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818
- Additional information about change #1
1919
-->
2020
## Upcoming Release
21+
* Support Kind BlockBlobStorage when create Storage account
22+
- New-AzStorageAccount
2123

2224
## Version 1.0.2
2325
* Update incorrect online help URLs

src/Storage/Storage.Management/StorageAccount/NewAzureStorageAccount.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ public class NewAzureStorageAccountCommand : StorageAccountBaseCmdlet
7474
[ValidateSet(AccountKind.Storage,
7575
AccountKind.StorageV2,
7676
AccountKind.BlobStorage,
77+
AccountKind.BlockBlobStorage,
7778
IgnoreCase = true)]
7879
public string Kind { get; set; }
7980

src/Storage/Storage.Management/StorageAccount/StorageAccountBaseCmdlet.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ protected struct AccountKind
6060
internal const string Storage = "Storage";
6161
internal const string StorageV2 = "StorageV2";
6262
internal const string BlobStorage = "BlobStorage";
63+
internal const string BlockBlobStorage = "BlockBlobStorage";
6364
}
6465
protected struct AccountAccessTier
6566
{

src/Storage/Storage.Management/help/New-AzStorageAccount.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
---
1+
---
22
external help file: Microsoft.Azure.PowerShell.Cmdlets.Storage.Management.dll-Help.xml
33
Module Name: Az.Storage
44
ms.assetid: A3DA1205-B8FB-4B4C-9C40-AD303D038EDF
@@ -191,7 +191,7 @@ The default value is Storage.
191191
Type: System.String
192192
Parameter Sets: (All)
193193
Aliases:
194-
Accepted values: Storage, StorageV2, BlobStorage
194+
Accepted values: Storage, StorageV2, BlobStorage, BlockBlobStorage
195195

196196
Required: False
197197
Position: Named

0 commit comments

Comments
 (0)