Skip to content

Commit 1ece5a6

Browse files
authored
Merge branch 'release-2019-10-15' into jyanand-fix-tests
2 parents 2cc82c3 + 20573b6 commit 1ece5a6

File tree

8 files changed

+2390
-2296
lines changed

8 files changed

+2390
-2296
lines changed

src/DataLakeStore/DataLakeStore.Test/ScenarioTests/AdlsAliasTests.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1012,7 +1012,7 @@ function Test-AdlsEnumerateAndRestoreDeletedItem
10121012
{
10131013
# Creating Account
10141014
$resourceGroupName = Get-ResourceGroupName
1015-
$accountName = Get-DataLakeStoreAccountName
1015+
$accountName = Get-DataLakeStoreAccountName + "-c12" # testing accountname validation
10161016
New-AzureRmResourceGroup -Name $resourceGroupName -Location $location
10171017
$accountCreated = New-AdlStore -ResourceGroupName $resourceGroupName -Name $accountName -Location $location
10181018
Assert-AreEqual $accountName $accountCreated.Name

src/DataLakeStore/DataLakeStore.Test/ScenarioTests/AdlsTests.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1012,7 +1012,7 @@ function Test-EnumerateAndRestoreDataLakeStoreDeletedItem
10121012
{
10131013
# Creating Account
10141014
$resourceGroupName = Get-ResourceGroupName
1015-
$accountName = Get-DataLakeStoreAccountName
1015+
$accountName = Get-DataLakeStoreAccountName + "-c12" # testing accountname validation
10161016
New-AzResourceGroup -Name $resourceGroupName -Location $location
10171017
$accountCreated = New-AzDataLakeStoreAccount -ResourceGroupName $resourceGroupName -Name $accountName -Location $location
10181018

src/DataLakeStore/DataLakeStore.Test/SessionRecords/Microsoft.Azure.Commands.DataLakeStore.Test.ScenarioTests.AdlsAliasTests/TestAdlsEnumerateAndRestoreDeletedItem.json

Lines changed: 298 additions & 355 deletions
Large diffs are not rendered by default.

src/DataLakeStore/DataLakeStore.Test/SessionRecords/Microsoft.Azure.Commands.DataLakeStore.Test.ScenarioTests.AdlsAliasTests/TestAdlsFileSystem.json

Lines changed: 808 additions & 808 deletions
Large diffs are not rendered by default.

src/DataLakeStore/DataLakeStore.Test/SessionRecords/Microsoft.Azure.Commands.DataLakeStore.Test.ScenarioTests.AdlsTests/TestAdlsEnumerateAndRestoreDeletedItem.json

Lines changed: 468 additions & 318 deletions
Large diffs are not rendered by default.

src/DataLakeStore/DataLakeStore.Test/SessionRecords/Microsoft.Azure.Commands.DataLakeStore.Test.ScenarioTests.AdlsTests/TestAdlsFileSystem.json

Lines changed: 812 additions & 812 deletions
Large diffs are not rendered by default.

src/DataLakeStore/DataLakeStore/ChangeLog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
- Additional information about change #1
1919
-->
2020
## Upcoming Release
21+
* Fix account validation so that accounts with "-" can be passed without domain
2122

2223
## Version 1.2.2
2324
* Fix hanging of Get-DataLakeStoreDeletedItem for any errors or remote exceptions.

src/DataLakeStore/DataLakeStore/DataPlaneModels/AdlsClientFactory.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public class AdlsClientFactory
2323
internal static ServiceClientCredentials MockCredentials = null;
2424
private static string HandleAccntName(string accnt,IAzureContext context)
2525
{
26-
if (Regex.IsMatch(accnt, @"^[a-zA-Z0-9]+$"))
26+
if (Regex.IsMatch(accnt, @"^[a-zA-Z0-9\-]+$"))
2727
{
2828
string domain = context.Environment.GetEndpoint(AzureEnvironment.Endpoint.AzureDataLakeStoreFileSystemEndpointSuffix);
2929
if (domain.EndsWith("/"))

0 commit comments

Comments
 (0)