Skip to content

Commit 29131bc

Browse files
sandipshsandipsh
committed
Addressed PR comments
1 parent a318179 commit 29131bc

File tree

3 files changed

+46
-45
lines changed

3 files changed

+46
-45
lines changed

‎src/Resources/ResourceManager/Implementation/Policy/NewAzurePolicyAssignment.cs

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,17 @@
1414

1515
namespace Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation
1616
{
17-
using Microsoft.Azure.Commands.ResourceManager.Cmdlets.Components;
18-
using Microsoft.Azure.Commands.ResourceManager.Cmdlets.Entities.Policy;
19-
using Microsoft.Azure.Commands.ResourceManager.Cmdlets.Extensions;
20-
using Newtonsoft.Json.Linq;
21-
using Policy;
2217
using System;
2318
using System.Collections;
2419
using System.Management.Automation;
25-
using Microsoft.Azure.Commands.ResourceManager.Cmdlets.Entities.Resources;
20+
2621
using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
22+
using Microsoft.Azure.Commands.ResourceManager.Cmdlets.Components;
23+
using Microsoft.Azure.Commands.ResourceManager.Cmdlets.Entities.Policy;
24+
using Microsoft.Azure.Commands.ResourceManager.Cmdlets.Entities.Resources;
25+
using Microsoft.Azure.Commands.ResourceManager.Cmdlets.Extensions;
26+
using Newtonsoft.Json.Linq;
27+
using Policy;
2728

2829
/// <summary>
2930
/// Creates a policy assignment.

‎src/Resources/ResourceManager/Implementation/Policy/SetAzurePolicyAssignment.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,19 +12,19 @@
1212
// limitations under the License.
1313
// ----------------------------------------------------------------------------------
1414

15-
using System;
16-
1715
namespace Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation
1816
{
19-
using Microsoft.Azure.Commands.ResourceManager.Cmdlets.Components;
20-
using Microsoft.Azure.Commands.ResourceManager.Cmdlets.Entities.Policy;
21-
using Microsoft.Azure.Commands.ResourceManager.Cmdlets.Extensions;
22-
using Newtonsoft.Json.Linq;
23-
using Policy;
17+
using System;
2418
using System.Collections;
2519
using System.Management.Automation;
20+
21+
using Microsoft.Azure.Commands.ResourceManager.Cmdlets.Components;
22+
using Microsoft.Azure.Commands.ResourceManager.Cmdlets.Entities.Policy;
2623
using Microsoft.Azure.Commands.ResourceManager.Cmdlets.Entities.Resources;
24+
using Microsoft.Azure.Commands.ResourceManager.Cmdlets.Extensions;
2725
using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
26+
using Newtonsoft.Json.Linq;
27+
using Policy;
2828

2929
/// <summary>
3030
/// Sets the policy assignment.

‎src/Resources/Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.PolicyTests/TestGetCmdletFilterParameter.json

Lines changed: 32 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -28,16 +28,16 @@
2828
"Accept-Encoding"
2929
],
3030
"x-ms-ratelimit-remaining-subscription-reads": [
31-
"11995"
31+
"11999"
3232
],
3333
"x-ms-request-id": [
34-
"westus:15a9f1eb-3f9d-40d5-a979-73a9ecacf4dc"
34+
"westus:38cb1a60-a48d-47ea-8666-0a88d7bd35ee"
3535
],
3636
"x-ms-correlation-request-id": [
37-
"d75bfefd-5c54-4c4b-a755-aa1734c069d9"
37+
"1031f4e0-0e10-4a3d-bb7b-1413d2bca62a"
3838
],
3939
"x-ms-routing-request-id": [
40-
"WESTUS:20191031T013500Z:d75bfefd-5c54-4c4b-a755-aa1734c069d9"
40+
"WESTUS:20191101T080058Z:1031f4e0-0e10-4a3d-bb7b-1413d2bca62a"
4141
],
4242
"Strict-Transport-Security": [
4343
"max-age=31536000; includeSubDomains"
@@ -46,7 +46,7 @@
4646
"nosniff"
4747
],
4848
"Date": [
49-
"Thu, 31 Oct 2019 01:34:59 GMT"
49+
"Fri, 01 Nov 2019 08:00:57 GMT"
5050
],
5151
"Content-Length": [
5252
"1043384"
@@ -92,16 +92,16 @@
9292
"Accept-Encoding"
9393
],
9494
"x-ms-ratelimit-remaining-subscription-reads": [
95-
"11992"
95+
"11999"
9696
],
9797
"x-ms-request-id": [
98-
"westus:6b3f2225-c634-4829-ab7d-aa5742930a88"
98+
"westus:0b5ce27f-19e0-4523-ac0c-eb3ee34e6c7f"
9999
],
100100
"x-ms-correlation-request-id": [
101-
"715025bb-5e08-4b93-a121-baf541331de0"
101+
"b213143d-233a-4b9f-94ca-ad1a6e6d9cb1"
102102
],
103103
"x-ms-routing-request-id": [
104-
"WESTUS:20191031T013641Z:715025bb-5e08-4b93-a121-baf541331de0"
104+
"WESTUS:20191101T080101Z:b213143d-233a-4b9f-94ca-ad1a6e6d9cb1"
105105
],
106106
"Strict-Transport-Security": [
107107
"max-age=31536000; includeSubDomains"
@@ -110,7 +110,7 @@
110110
"nosniff"
111111
],
112112
"Date": [
113-
"Thu, 31 Oct 2019 01:36:41 GMT"
113+
"Fri, 01 Nov 2019 08:01:01 GMT"
114114
],
115115
"Content-Length": [
116116
"1043384"
@@ -155,17 +155,17 @@
155155
"Vary": [
156156
"Accept-Encoding"
157157
],
158-
"x-ms-ratelimit-remaining-subscription-reads": [
159-
"11991"
158+
"x-ms-correlation-request-id": [
159+
"37043c53-7046-4acf-8a9b-765bbc7c3033"
160160
],
161161
"x-ms-request-id": [
162-
"westus:da716473-c9ed-430d-860b-ba2049382906"
162+
"westus:16d717f1-8354-4a4b-8fd2-b52ae0d029fb"
163163
],
164-
"x-ms-correlation-request-id": [
165-
"c7a49d4c-7167-4de4-9d10-a644e5fd2732"
164+
"x-ms-ratelimit-remaining-subscription-reads": [
165+
"11998"
166166
],
167167
"x-ms-routing-request-id": [
168-
"WESTUS:20191031T013823Z:c7a49d4c-7167-4de4-9d10-a644e5fd2732"
168+
"WESTUS:20191101T080104Z:37043c53-7046-4acf-8a9b-765bbc7c3033"
169169
],
170170
"Strict-Transport-Security": [
171171
"max-age=31536000; includeSubDomains"
@@ -174,7 +174,7 @@
174174
"nosniff"
175175
],
176176
"Date": [
177-
"Thu, 31 Oct 2019 01:38:23 GMT"
177+
"Fri, 01 Nov 2019 08:01:03 GMT"
178178
],
179179
"Content-Length": [
180180
"1043384"
@@ -220,16 +220,16 @@
220220
"Accept-Encoding"
221221
],
222222
"x-ms-ratelimit-remaining-subscription-reads": [
223-
"11996"
223+
"11999"
224224
],
225225
"x-ms-request-id": [
226-
"westus:9e496e3b-f64b-4d9a-85b2-8249fcb39073"
226+
"westus:0adab5f2-9228-420a-94fd-4dd021a3751f"
227227
],
228228
"x-ms-correlation-request-id": [
229-
"3ec1747a-cecd-4486-8ceb-6710b64de163"
229+
"b6acd5bb-20bb-4a4e-8649-2d2178455101"
230230
],
231231
"x-ms-routing-request-id": [
232-
"WESTUS:20191031T014003Z:3ec1747a-cecd-4486-8ceb-6710b64de163"
232+
"WESTUS:20191101T080106Z:b6acd5bb-20bb-4a4e-8649-2d2178455101"
233233
],
234234
"Strict-Transport-Security": [
235235
"max-age=31536000; includeSubDomains"
@@ -238,7 +238,7 @@
238238
"nosniff"
239239
],
240240
"Date": [
241-
"Thu, 31 Oct 2019 01:40:03 GMT"
241+
"Fri, 01 Nov 2019 08:01:06 GMT"
242242
],
243243
"Content-Length": [
244244
"344235"
@@ -284,16 +284,16 @@
284284
"Accept-Encoding"
285285
],
286286
"x-ms-ratelimit-remaining-subscription-reads": [
287-
"11988"
287+
"11999"
288288
],
289289
"x-ms-request-id": [
290-
"westus:62719919-f26b-48d9-aefb-a758dc322435"
290+
"westus:449a7ac7-223c-45a0-8bb3-b51529adb014"
291291
],
292292
"x-ms-correlation-request-id": [
293-
"fbb4d389-368d-4d99-a329-f69af8fee5aa"
293+
"e79a0866-699f-452b-859a-3b325d2a3d42"
294294
],
295295
"x-ms-routing-request-id": [
296-
"WESTUS:20191031T014014Z:fbb4d389-368d-4d99-a329-f69af8fee5aa"
296+
"WESTUS:20191101T080107Z:e79a0866-699f-452b-859a-3b325d2a3d42"
297297
],
298298
"Strict-Transport-Security": [
299299
"max-age=31536000; includeSubDomains"
@@ -302,7 +302,7 @@
302302
"nosniff"
303303
],
304304
"Date": [
305-
"Thu, 31 Oct 2019 01:40:13 GMT"
305+
"Fri, 01 Nov 2019 08:01:06 GMT"
306306
],
307307
"Content-Length": [
308308
"344235"
@@ -348,16 +348,16 @@
348348
"Accept-Encoding"
349349
],
350350
"x-ms-ratelimit-remaining-subscription-reads": [
351-
"11996"
351+
"11999"
352352
],
353353
"x-ms-request-id": [
354-
"westus:2c78c218-557d-45bb-ad86-08a9a21b6076"
354+
"westus:4c37dc93-747e-4ff2-9865-d22c27734388"
355355
],
356356
"x-ms-correlation-request-id": [
357-
"16a9c30a-bffe-4ac5-9909-9722a9e142f7"
357+
"6e6eb23d-0990-4440-885a-891df64bd317"
358358
],
359359
"x-ms-routing-request-id": [
360-
"WESTUS:20191031T014025Z:16a9c30a-bffe-4ac5-9909-9722a9e142f7"
360+
"WESTUS:20191101T080108Z:6e6eb23d-0990-4440-885a-891df64bd317"
361361
],
362362
"Strict-Transport-Security": [
363363
"max-age=31536000; includeSubDomains"
@@ -366,7 +366,7 @@
366366
"nosniff"
367367
],
368368
"Date": [
369-
"Thu, 31 Oct 2019 01:40:24 GMT"
369+
"Fri, 01 Nov 2019 08:01:08 GMT"
370370
],
371371
"Content-Length": [
372372
"344235"

0 commit comments

Comments
 (0)