Skip to content

Commit 3cf6a30

Browse files
unknownunknown
authored andcommitted
Update according to comments
1 parent 52090d5 commit 3cf6a30

File tree

3 files changed

+9
-24
lines changed

3 files changed

+9
-24
lines changed

src/ResourceManager/Compute/Commands.Compute.Test/ScenarioTests/VirtualMachineProfileTests.ps1

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -82,32 +82,33 @@ function Test-VirtualMachineProfile
8282

8383
$p = Set-AzureVMOperatingSystem -VM $p -Windows -ComputerName $computerName -Credential $cred -CustomData $custom -WinRMHttp -WinRMHttps -WinRMCertUrl $winRMCertUrl -ProvisionVMAgent -EnableAutoUpdate -TimeZone $timeZone;
8484
$p = Set-AzureVMSourceImage -VM $p -Name $img;
85+
$subid = (Get-AzureSubscription -Current).SubscriptionId;
8586

86-
$referenceUri = "/subscriptions/" + (Get-AzureSubscription -Current).SubscriptionId + "/resourceGroups/RgTest1/providers/Microsoft.KeyVault/vaults/TestVault123";
87+
$referenceUri = "/subscriptions/" + $subid + "/resourceGroups/RgTest1/providers/Microsoft.KeyVault/vaults/TestVault123";
8788
$certStore = "My";
8889
$certUrl = "https://testvault123.vault.azure.net/secrets/Test1/514ceb769c984379a7e0230bdd703272";
8990
$p = Add-AzureVMSecretConfig -VM $p -ReferenceUri $referenceUri -CertificateStore $certStore -CertificateUrl $certUrl;
9091

91-
$referenceUri2 = "/subscriptions/" + (Get-AzureSubscription -Current).SubscriptionId + "/resourceGroups/RgTest1/providers/Microsoft.KeyVault/vaults/TestVault456";
92+
$referenceUri2 = "/subscriptions/" + $subid + "/resourceGroups/RgTest1/providers/Microsoft.KeyVault/vaults/TestVault456";
9293
$p = Add-AzureVMSecretConfig -VM $p -ReferenceUri $referenceUri2 -CertificateStore $certStore -CertificateUrl $certUrl;
9394

9495
$certStore2 = "My2";
9596
$certUrl2 = "https://testvault123.vault.azure.net/secrets/Test1/514ceb769c984379a7e0230bddaaaaaa";
9697
$p = Add-AzureVMSecretConfig -VM $p -ReferenceUri $referenceUri -CertificateStore $certStore2 -CertificateUrl $certUrl2;
9798

9899
$aucSetting = "AutoLogon";
99-
$aucContent = "<UserAccounts><AdministratorPassword><Value>p@ssw0rd</Value><PlainText>true</PlainText></AdministratorPassword></UserAccounts>";
100+
$aucContent = "<UserAccounts><AdministratorPassword><Value>" + $password + "</Value><PlainText>true</PlainText></AdministratorPassword></UserAccounts>";
100101
$p = Add-AzureVMAdditionalUnattendContentConfig -VM $p -Content $aucContent -SettingName $aucSetting;
101102
$p = Add-AzureVMAdditionalUnattendContentConfig -VM $p -Content $aucContent -SettingName $aucSetting;
102103

103104
Assert-AreEqual $p.OSProfile.AdminUsername $user;
104105
Assert-AreEqual $p.OSProfile.ComputerName $computerName;
105106
Assert-AreEqual $p.OSProfile.AdminPassword $password;
106-
Assert-AreEqual $p.StorageProfile.SourceImage.ReferenceUri ('/' + (Get-AzureSubscription -Current).SubscriptionId + '/services/images/' + $img);
107+
Assert-AreEqual $p.StorageProfile.SourceImage.ReferenceUri ('/' + $subid + '/services/images/' + $img);
107108
Assert-AreEqual $p.OSProfile.Secrets[0].SourceVault.ReferenceUri $referenceUri;
108109
Assert-AreEqual $p.OSProfile.Secrets[0].VaultCertificates[0].CertificateStore $certStore;
109110
Assert-AreEqual $p.OSProfile.Secrets[0].VaultCertificates[0].CertificateUrl $certUrl;
110-
Assert-AreEqual $p.OSProfile.Secrets[0].SourceVault.ReferenceUri $referenceUri;
111+
Assert-AreEqual $p.OSProfile.Secrets[0].SourceVault.ReferenceUri $referenceUri;
111112
Assert-AreEqual $p.OSProfile.Secrets[0].VaultCertificates[1].CertificateStore $certStore2;
112113
Assert-AreEqual $p.OSProfile.Secrets[0].VaultCertificates[1].CertificateUrl $certUrl2;
113114
Assert-AreEqual $p.OSProfile.Secrets[1].SourceVault.ReferenceUri $referenceUri2;
@@ -151,7 +152,7 @@ function Test-VirtualMachineProfile
151152
Assert-AreEqual $p.OSProfile.AdminUsername $user;
152153
Assert-AreEqual $p.OSProfile.ComputerName $computerName;
153154
Assert-AreEqual $p.OSProfile.AdminPassword $password;
154-
Assert-AreEqual $p.StorageProfile.SourceImage.ReferenceUri ('/' + (Get-AzureSubscription -Current).SubscriptionId + '/services/images/' + $img);
155+
Assert-AreEqual $p.StorageProfile.SourceImage.ReferenceUri ('/' + $subid + '/services/images/' + $img);
155156
Assert-AreEqual $p.OSProfile.Secrets[0].SourceVault.ReferenceUri $referenceUri;
156157
Assert-AreEqual $p.OSProfile.Secrets[0].VaultCertificates[0].CertificateStore $certStore;
157158
Assert-AreEqual $p.OSProfile.Secrets[0].VaultCertificates[0].CertificateUrl $certUrl;

src/ResourceManager/Compute/Commands.Compute/VirtualMachine/Config/AddAzureVMAdditionalUnattendContentConfigCommand.cs

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -46,30 +46,14 @@ public class NewAzureAdditionalUnattendContentCommand : AzurePSCmdlet
4646
public PSVirtualMachine VM { get; set; }
4747

4848
[Parameter(
49-
DontShow = true, // Currently, the only allowable value is 'Microsoft-Windows-Shell-Setup'.
5049
Position = 1,
5150
ValueFromPipelineByPropertyName = true,
52-
HelpMessage = "Component Name.")]
53-
[ValidateNotNullOrEmpty]
54-
public string ComponentName { get; set; }
55-
56-
[Parameter(
57-
Position = 2,
58-
ValueFromPipelineByPropertyName = true,
5951
HelpMessage = "XML Formatted Content.")]
6052
[ValidateNotNullOrEmpty]
6153
public string Content { get; set; }
6254

6355
[Parameter(
64-
DontShow = true, // Currently, the only allowable value is 'oobeSystem'.
65-
Position = 3,
66-
ValueFromPipelineByPropertyName = true,
67-
HelpMessage = "Pass name")]
68-
[ValidateNotNullOrEmpty]
69-
public string PassName { get; set; }
70-
71-
[Parameter(
72-
Position = 4,
56+
Position = 2,
7357
ValueFromPipelineByPropertyName = true,
7458
HelpMessage = "Setting Name.")]
7559
[ValidateNotNullOrEmpty]

src/ResourceManager/Compute/Commands.Compute/VirtualMachine/Config/AddAzureVMSecretConfigCommand.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ public override void ExecuteCmdlet()
103103
break;
104104
}
105105

106-
if (this.VM.OSProfile.Secrets[i].SourceVault != null && this.VM.OSProfile.Secrets[i].SourceVault.ReferenceUri == this.ReferenceUri)
106+
if (this.VM.OSProfile.Secrets[i].SourceVault != null && this.VM.OSProfile.Secrets[i].SourceVault.ReferenceUri.Equals(this.ReferenceUri))
107107
{
108108
if (this.VM.OSProfile.Secrets[i].VaultCertificates == null)
109109
{

0 commit comments

Comments
 (0)