Handle null contexts in profile context operations

Author: markcowl

src/ResourceManager/Common/Commands.Common.Authentication.ResourceManager/AzureRmProfile.cs

@@ -356,55 +356,57 @@ public bool TryFindContext(IAzureContext context, out string name)
         {
             bool result = false;
             name = null;
-            var foundContext = Contexts.FirstOrDefault((c) =>
-                c.Value != null
-                && (
-                    (c.Value.Account != null && context.Account != null && string.Equals(c.Value.Account.Id, context.Account.Id, StringComparison.OrdinalIgnoreCase))
-                    || (c.Value.Account == context.Account))
-                && (
-                    (c.Value.Tenant != null && context.Tenant != null && c.Value.Tenant.GetId() == context.Tenant.GetId())
-                    || (c.Value.Tenant == context.Tenant))
-                && (
-                    (c.Value.Subscription != null && context.Subscription != null && c.Value.Subscription.GetId() == context.Subscription.GetId())
-                    || (c.Value.Subscription == context.Subscription)));
-            if (!string.IsNullOrEmpty(foundContext.Key))
-            {
-                name = foundContext.Key;
-                result = true;
+            if (context != null)
+            {
+                var foundContext = Contexts.FirstOrDefault((c) =>
+                    c.Value != null
+                    && (
+                        (c.Value.Account != null && context.Account != null && string.Equals(c.Value.Account.Id, context.Account.Id, StringComparison.OrdinalIgnoreCase))
+                        || (c.Value.Account == context.Account))
+                    && (
+                        (c.Value.Tenant != null && context.Tenant != null && c.Value.Tenant.GetId() == context.Tenant.GetId())
+                        || (c.Value.Tenant == context.Tenant))
+                    && (
+                        (c.Value.Subscription != null && context.Subscription != null && c.Value.Subscription.GetId() == context.Subscription.GetId())
+                        || (c.Value.Subscription == context.Subscription)));
+                if (!string.IsNullOrEmpty(foundContext.Key))
+                {
+                    name = foundContext.Key;
+                    result = true;
+                }
             }
 
             return result;
         }
 
         public bool TryGetContextName(IAzureContext context, out string name)
         {
-            if (context == null)
-            {
-                throw new ArgumentNullException(nameof(context));
-            }
-
             bool result = false;
             name = null;
-            if ((context.Account != null && !string.IsNullOrWhiteSpace(context.Account.Id)) || context.Subscription != null)
+            if (context != null)
             {
-                List<string> components = new List<string>();
-                if (context.Account != null && !string.IsNullOrWhiteSpace(context.Account.Id))
+
+                if ((context.Account != null && !string.IsNullOrWhiteSpace(context.Account.Id)) || context.Subscription != null)
                 {
-                    components.Add(context.Account.Id);
+                    List<string> components = new List<string>();
+                    if (context.Account != null && !string.IsNullOrWhiteSpace(context.Account.Id))
+                    {
+                        components.Add(context.Account.Id);
+                    }
+
+                    if (context.Subscription != null)
+                    {
+                        components.Add(context.Subscription.GetId().ToString());
+                    }
+
+                    name = string.Format("[{0}]", string.Join(", ", components));
+                    result = true;
                 }
-
-                if (context.Subscription != null)
+                else
                 {
-                    components.Add(context.Subscription.GetId().ToString());
+                    name = "Default";
+                    result = true;
                 }
-
-                name = string.Format("[{0}]", string.Join(", ", components));
-                result = true;
-            }
-            else
-            {
-                name = "Default";
-                result = true;
             }
 
             return result;
@@ -478,7 +480,8 @@ public bool TrySetDefaultContext(IAzureContext context)
         {
             bool result = false;
             string contextName;
-            if (TryFindContext(context, out contextName) || TryAddContext(context, out contextName))
+
+            if (context != null && (TryFindContext(context, out contextName) || TryAddContext(context, out contextName)))
             {
                 result = TrySetDefaultContext(contextName);
             }
@@ -489,13 +492,16 @@ public bool TrySetDefaultContext(IAzureContext context)
         public bool TrySetDefaultContext(string name, IAzureContext context)
         {
             bool result = false;
-            if (string.IsNullOrWhiteSpace(name))
+            if (context != null)
             {
-                result = TrySetDefaultContext(context);
-            }
-            else if (TrySetContext(name, context))
-            {
-                result = TrySetDefaultContext(name);
+                if (string.IsNullOrWhiteSpace(name))
+                {
+                    result = TrySetDefaultContext(context);
+                }
+                else if (TrySetContext(name, context))
+                {
+                    result = TrySetDefaultContext(name);
+                }
             }
 
             return result;
@@ -562,7 +568,11 @@ public bool TryCopyProfile(AzureRmProfile other)
                 TrySetContext(context.Key, context.Value);
             }
 
-            this.TrySetDefaultContext(other.DefaultContext);
+            if (other.DefaultContext != null)
+            {
+                this.TrySetDefaultContext(other.DefaultContext);
+            }
+
             this.CopyPropertiesFrom(other);
             return true;
         }