Resolve PR comments

Author: Mahak Jain

src/AlertsManagement/AlertsManagement/ActionRuleCommands/GetAzureActionRule.cs

@@ -31,7 +31,6 @@ public class GetAzureActionRule : AlertsManagementBaseCmdlet
         private const string ResourceIdParameterSet = "ResourceId";
         private const string ListActionRulesParameterSet = "ListActionRules";
         private const string ListActionRulesByTargetResourceIdParameterSet = "ListActionRulesByTargetResourceId";
-        private const string ListActionRulesByTargetResourceGroupParameterSet = "ListActionRulesByTargetResourceGroup";
         private const string ActionRuleByNameParameterSet = "ActionRuleByName";
 
         #endregion
@@ -59,9 +58,6 @@ public class GetAzureActionRule : AlertsManagementBaseCmdlet
         [Parameter(Mandatory = false,
                    ParameterSetName = ListActionRulesByTargetResourceIdParameterSet,
                    HelpMessage = "Filter on Name of action rule.")]
-        [Parameter(Mandatory = false,
-                   ParameterSetName = ListActionRulesByTargetResourceGroupParameterSet,
-                   HelpMessage = "Filter on Name of action rule.")]
         public string Name { get; set; }
 
         /// <summary>
@@ -76,9 +72,6 @@ public class GetAzureActionRule : AlertsManagementBaseCmdlet
         [Parameter(Mandatory = false,
                    ParameterSetName = ListActionRulesByTargetResourceIdParameterSet,
                    HelpMessage = "Filter on Resource Group Name in which action rule resides.")]
-        [Parameter(Mandatory = false,
-                   ParameterSetName = ListActionRulesByTargetResourceGroupParameterSet,
-                   HelpMessage = "Filter on Resource Group Name in which action rule resides.")]
         public string ResourceGroupName { get; set; }
 
         /// <summary>
@@ -95,17 +88,14 @@ public class GetAzureActionRule : AlertsManagementBaseCmdlet
         [Parameter(Mandatory = false,
                    ParameterSetName = ListActionRulesParameterSet,
                    HelpMessage = "Filter on Resource type of the target resource of alert.")]
-        [Parameter(Mandatory = false,
-                   ParameterSetName = ListActionRulesByTargetResourceGroupParameterSet,
-                   HelpMessage = "Filter on Resource type of the target resource of alert.")]
         [ResourceTypeCompleter]
         public string TargetResourceType { get; set; }
 
         /// <summary>
         /// Resource Group Name
         /// </summary>
         [Parameter(Mandatory = false,
-                   ParameterSetName = ListActionRulesByTargetResourceGroupParameterSet,
+                   ParameterSetName = ListActionRulesParameterSet,
                    HelpMessage = "Filter on Resource group name of the target resource of alert.")]
         [ResourceGroupCompleter]
         public string TargetResourceGroup { get; set; }
@@ -119,9 +109,6 @@ public class GetAzureActionRule : AlertsManagementBaseCmdlet
         [Parameter(Mandatory = false,
                    ParameterSetName = ListActionRulesByTargetResourceIdParameterSet,
                    HelpMessage = "Filter on Moniter Service")]
-        [Parameter(Mandatory = false,
-                   ParameterSetName = ListActionRulesByTargetResourceGroupParameterSet,
-                   HelpMessage = "Filter on Moniter Service")]
         [PSArgumentCompleter("Platform", "Log Analytics", "SCOM", "Activity Log")]
         public string MonitorService { get; set; }
 
@@ -131,9 +118,6 @@ public class GetAzureActionRule : AlertsManagementBaseCmdlet
         [Parameter(Mandatory = false,
                    ParameterSetName = ListActionRulesParameterSet,
                    HelpMessage = "Filter on Severity of alert")]
-        [Parameter(Mandatory = false,
-                   ParameterSetName = ListActionRulesByTargetResourceGroupParameterSet,
-                   HelpMessage = "Filter on Severity of alert")]
         [Parameter(Mandatory = false,
                    ParameterSetName = ListActionRulesByTargetResourceIdParameterSet,
                    HelpMessage = "Filter on Severity of alert")]
@@ -149,9 +133,6 @@ public class GetAzureActionRule : AlertsManagementBaseCmdlet
         [Parameter(Mandatory = false,
                    ParameterSetName = ListActionRulesByTargetResourceIdParameterSet,
                    HelpMessage = "Filter on Impacted scope")]
-        [Parameter(Mandatory = false,
-                   ParameterSetName = ListActionRulesByTargetResourceGroupParameterSet,
-                   HelpMessage = "Filter on Impacted scope")]
         public string ImpactedScope { get; set; }
 
         /// <summary>
@@ -163,9 +144,6 @@ public class GetAzureActionRule : AlertsManagementBaseCmdlet
         [Parameter(Mandatory = false,
                    ParameterSetName = ListActionRulesByTargetResourceIdParameterSet,
                    HelpMessage = "Filter on Alert Rule Id")]
-        [Parameter(Mandatory = false,
-                   ParameterSetName = ListActionRulesByTargetResourceGroupParameterSet,
-                   HelpMessage = "Filter on Alert Rule Id")]
         public string AlertRuleId { get; set; }
 
         /// <summary>
@@ -177,9 +155,6 @@ public class GetAzureActionRule : AlertsManagementBaseCmdlet
         [Parameter(Mandatory = false,
                    ParameterSetName = ListActionRulesByTargetResourceIdParameterSet,
                    HelpMessage = "Filter all the alerts having the Smart Group Id")]
-        [Parameter(Mandatory = false,
-                   ParameterSetName = ListActionRulesByTargetResourceGroupParameterSet,
-                   HelpMessage = "Filter all the alerts having the Smart Group Id")]
         public string Description { get; set; }
 
         /// <summary>
@@ -191,9 +166,6 @@ public class GetAzureActionRule : AlertsManagementBaseCmdlet
         [Parameter(Mandatory = false,
                    ParameterSetName = ListActionRulesByTargetResourceIdParameterSet,
                    HelpMessage = "Action group")]
-        [Parameter(Mandatory = false,
-                   ParameterSetName = ListActionRulesByTargetResourceGroupParameterSet,
-                   HelpMessage = "Action group")]
         public string ActionGroup { get; set; }
 
         #endregion
@@ -204,7 +176,6 @@ protected override void ProcessRecordInternal()
             {
                 case ListActionRulesParameterSet:
                 case ListActionRulesByTargetResourceIdParameterSet:
-                case ListActionRulesByTargetResourceGroupParameterSet:
                     IPage<ActionRule> pageResult = new Page<ActionRule>();
                     List<ActionRule> resultList = new List<ActionRule>();
                     bool listByResourceGroup = false;

src/AlertsManagement/AlertsManagement/ActionRuleCommands/SetAzureActionRule.cs

@@ -405,19 +405,19 @@ protected override void ProcessRecordInternal()
 
                             case "Suppression":
                                 PSSuppressionActionRule suppressionInputObject = (PSSuppressionActionRule)InputObject;
-                                SuppressionConfig configFromInputObject = new SuppressionConfig(recurrenceType: suppressionInputObject.SuppressionConfig.RecurrenceType);
-                                if (suppressionInputObject.SuppressionConfig.RecurrenceType != "Always")
+                                SuppressionConfig configFromInputObject = new SuppressionConfig(recurrenceType: suppressionInputObject.RecurrenceType);
+                                if (suppressionInputObject.RecurrenceType != "Always")
                                 {
                                     configFromInputObject.Schedule = new SuppressionSchedule(
-                                        startDate: suppressionInputObject.SuppressionConfig.StartDate,
-                                        endDate: suppressionInputObject.SuppressionConfig.EndDate,
-                                        startTime: suppressionInputObject.SuppressionConfig.StartTime,
-                                        endTime: suppressionInputObject.SuppressionConfig.EndTime
+                                        startDate: suppressionInputObject.StartDate,
+                                        endDate: suppressionInputObject.EndDate,
+                                        startTime: suppressionInputObject.StartTime,
+                                        endTime: suppressionInputObject.EndTime
                                         );
 
                                     if (ReccurentValue.Length > 0)
                                     {
-                                        configFromInputObject.Schedule.RecurrenceValues = suppressionInputObject.SuppressionConfig.RecurrenceValues;
+                                        configFromInputObject.Schedule.RecurrenceValues = suppressionInputObject.RecurrenceValues;
                                     }
                                 }