Added scenario tests for attaching NSG to VM and to NIC.

Author: Ed Munoz

src/ServiceManagement/Network/Commands.Network.Test/Commands.Network.Test.csproj

@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <Project ToolsVersion="4.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <Import Project="..\..\..\packages\xunit.runner.visualstudio.2.0.0\build\net20\xunit.runner.visualstudio.props" Condition="Exists('..\..\..\packages\xunit.runner.visualstudio.2.0.0\build\net20\xunit.runner.visualstudio.props')" />
   <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
@@ -204,6 +204,12 @@
     <None Include="SessionRecords\Microsoft.Azure.Commands.Network.Test.ScenarioTests.IPForwardingScenarioTests\SetIPForwardingOnVMAndUpdateVM.json">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </None>
+    <None Include="SessionRecords\Microsoft.Azure.Commands.Network.Test.ScenarioTests.NSGScenarioTests\SetNSGOnNICAndUpdateVM.json">
+      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+    </None>
+    <None Include="SessionRecords\Microsoft.Azure.Commands.Network.Test.ScenarioTests.NSGScenarioTests\SetNSGOnRoleAndUpdateVM.json">
+      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+    </None>
     <None Include="SessionRecords\Microsoft.Azure.Commands.Network.Test.ScenarioTests.NSGScenarioTests\TestCreateAndRemoveNSG.json">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </None>

src/ServiceManagement/Network/Commands.Network.Test/ScenarioTests/NetworkSecurityGroup/NSGScenarioTests.cs

@@ -106,7 +106,23 @@ public void TestSetNSGToSubnetInDiffRegion()
         {
             this.RunPowerShellTest("Test-SetNetworkSecurityGroupToSubnetInDifferentRegion");
         }
-        
+
+        [Fact]
+        [Trait(Category.Service, Category.Network)]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void SetNSGOnRoleAndUpdateVM()
+        {
+            this.RunPowerShellTest("Test-SetNSGOnRoleAndUpdateVM");
+        }
+
+        [Fact]
+        [Trait(Category.Service, Category.Network)]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void SetNSGOnNICAndUpdateVM()
+        {
+            this.RunPowerShellTest("Test-SetNSGOnNICAndUpdateVM");
+        }
+
         #region Test setup
         protected void SetupManagementClients()
         {

src/ServiceManagement/Network/Commands.Network.Test/ScenarioTests/NetworkSecurityGroup/NetworkSecurityGroupTests.ps1

@@ -192,7 +192,7 @@ function Test-SetNetworkSecurityGroupToSubnetInDifferentRegion
     Assert-Throws { Set-AzureNetworkSecurityGroupToSubnet -Name $securityGroupName -VirtualNetwork $VirtualNetworkName -Subnet $SubnetName -Force } $expectedMessage
 }
 
-########################## Remove Network Security Group for Subnet Tests #############################
+########################## Remove Network Security Group from Subnet Tests #############################
 
 <#
 .SYNOPSIS
@@ -214,3 +214,72 @@ function Test-RemoveNetworkSecurityGroupFromSubnet
     $expectedMessage = "ResourceNotFound: The virtual network name $VirtualNetworkName and subnet $SubnetName does not have any network security group assigned."
     Assert-Throws { Get-AzureNetworkSecurityGroupForSubnet -VirtualNetwork $VirtualNetworkName -Subnet $SubnetName } $expectedMessage
 }
+
+########################## Update-AzureVM keeps NSG on Role and on NIC #############################
+
+<#
+.SYNOPSIS
+Tests Update-AzureVM after a VM has NSG on Role
+#>
+function Test-SetNSGOnRoleAndUpdateVM
+{
+    # Setup
+    Set-AzureVNetConfig ($(Get-Location).Path +  "\TestData\SimpleNetworkConfiguration.xml")
+    $VMName = getAssetName
+    $image = get-azurevmimage | Where-Object {$_.OS -eq 'Windows'} | Select-Object -First 1 -ExpandProperty ImageName
+    $image = "b9a55fa61dad4dd88bab1b26ca2ed075__Test-Win2K8R2SP1-Datacenter-201401.01-en.us-127GB.vhd"
+
+    # Test
+    New-AzureVMConfig -ImageName $image -Name $VMName -InstanceSize Small |
+    Add-AzureProvisioningConfig -Windows -AdminUsername azuretest -Password "Pa@!!w0rd" |
+    Set-AzureSubnet -SubnetNames $SubnetName |
+    New-AzureVM -VNetName $VirtualNetworkName -ServiceName $VMName -Location $Location
+
+    $securityGroupName = Get-SecurityGroupName
+    $securityRuleName = Get-SecurityRuleName
+    $createdSecurityGroup = New-NetworkSecurityGroup $securityGroupName
+
+    # Test
+    Get-AzureVM $VMName | Set-AzureNetworkSecurityGroupAssociation $securityGroupName
+    Get-AzureVM $VMName |
+    Add-AzureEndpoint -Name "http" -Protocol tcp -LocalPort 80 -PublicPort 80 |
+    Update-AzureVM
+
+    # Assert
+    $retrievedNSG = Get-AzureVM $VMName | Get-AzureNetworkSecurityGroupAssociation
+    Assert-AreEqual $securityGroupName $retrievedNSG.Name
+}
+<#
+.SYNOPSIS
+Tests Update-AzureVM after a VM has NSG on Role
+#>
+function Test-SetNSGOnNICAndUpdateVM
+{
+    # Setup
+    Set-AzureVNetConfig ($(Get-Location).Path +  "\TestData\SimpleNetworkConfiguration.xml")
+    $VMName = getAssetName
+    $nicName = getAssetName
+    $image = get-azurevmimage | Where-Object {$_.OS -eq 'Windows'} | Select-Object -First 1 -ExpandProperty ImageName
+    $image = "b9a55fa61dad4dd88bab1b26ca2ed075__Test-Win2K8R2SP1-Datacenter-201401.01-en.us-127GB.vhd"
+
+    # Test
+    New-AzureVMConfig -ImageName $image -Name $VMName -InstanceSize Large |
+    Add-AzureProvisioningConfig -Windows -AdminUsername azuretest -Password "Pa@!!w0rd" |
+    Set-AzureSubnet -SubnetNames $SubnetName |
+    Add-AzureNetworkInterfaceConfig -Name $nicName -SubnetName $SubnetName |
+    New-AzureVM -VNetName $VirtualNetworkName -ServiceName $VMName -Location $Location
+
+    $securityGroupName = Get-SecurityGroupName
+    $securityRuleName = Get-SecurityRuleName
+    $createdSecurityGroup = New-NetworkSecurityGroup $securityGroupName
+
+    # Test
+    Get-AzureVM $VMName | Set-AzureNetworkSecurityGroupAssociation -Name $securityGroupName -NetworkInterfaceName $nicName
+    Get-AzureVM $VMName |
+    Add-AzureEndpoint -Name "http" -Protocol tcp -LocalPort 80 -PublicPort 80 |
+    Update-AzureVM
+
+    # Assert
+    $retrievedNSG = Get-AzureVM $VMName | Get-AzureNetworkSecurityGroupAssociation -NetworkInterfaceName $nicName
+    Assert-AreEqual $securityGroupName $retrievedNSG.Name
+}