[GuestConfiguration] Fix help docs for real

Author: viveklingaiah

src/GuestConfiguration/GuestConfiguration.Test/ScenarioTests/GetVmGuestPolicyStatusTests.cs

@@ -55,9 +55,9 @@ public void InitiativeNameScope()
 
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
-        public void IdScope()
+        public void ReportIdScope()
         {
-            TestController.NewInstance.RunPowerShellTest(_logger, "Get-AzVMGuestPolicyStatus-IdScope");
+            TestController.NewInstance.RunPowerShellTest(_logger, "Get-AzVMGuestPolicyStatus-ReportIdScope");
         }
     }
 }

src/GuestConfiguration/GuestConfiguration.Test/ScenarioTests/GetVmGuestPolicyStatusTests.ps1

@@ -58,9 +58,9 @@ function Get-AzVMGuestPolicyStatus-InitiativeNameScope
 
 <#
 .SYNOPSIS
-Get guest configuration policy by Id scope
+Get guest configuration policy by ReportId scope
 #>
-function Get-AzVMGuestPolicyStatus-IdScope
+function Get-AzVMGuestPolicyStatus-ReportIdScope
 {
 	$rgName = "vivga"
 	$vmName = "Viv1809SDDC"
@@ -69,8 +69,8 @@ function Get-AzVMGuestPolicyStatus-IdScope
 	Assert-NotNull $reports
 	Assert-True { $reports.Count -gt 0 }
 
-	$Id= $reports[0].Id;
+	$Id= $reports[0].ReportId;
 
-    $report = Get-AzVMGuestPolicyStatus -Id $Id
+    $report = Get-AzVMGuestPolicyStatus -ReportId $Id
 	Assert-NotNull $report
 }

src/GuestConfiguration/GuestConfiguration.Test/SessionRecords/Microsoft.Azure.Commands.GuestConfiguration.Test.ScenarioTests.GetVmGuestPolicyStatusHistoryTests/InitiativeIdScope.json

@@ -49,9 +49,9 @@ public class GetAzVMGuestPolicyStatus : GuestConfigurationCmdletBase
         [ValidateNotNullOrEmpty]
         public string InitiativeId { get; set; }
 
-        [Parameter(ParameterSetName = ParameterSetNames.IdScope, Mandatory = true, Position = 0, HelpMessage = ParameterHelpMessages.Id)]
+        [Parameter(ParameterSetName = ParameterSetNames.ReportIdScope, Mandatory = true, Position = 0, HelpMessage = ParameterHelpMessages.ReportId)]
         [ValidateNotNullOrEmpty]
-        public string Id { get; set; }
+        public string ReportId { get; set; }
 
         /// <summary>
         /// Executes the cmdlet
@@ -85,8 +85,8 @@ public override void ExecuteCmdlet()
                     }                   
                     break;
 
-                case ParameterSetNames.IdScope:
-                    var policyReport = GetPolicyStatusDetailedByReportId(Id);
+                case ParameterSetNames.ReportIdScope:
+                    var policyReport = GetPolicyStatusDetailedByReportId(ReportId);
                     if (policyReport != null)
                     {
                         WriteObject(policyReport);

src/GuestConfiguration/GuestConfiguration.Test/SessionRecords/Microsoft.Azure.Commands.GuestConfiguration.Test.ScenarioTests.GetVmGuestPolicyStatusHistoryTests/InitiativeNameScope.json

@@ -23,7 +23,7 @@ public static class ParameterHelpMessages
         public const string VMName = "VM name.";
         public const string InitiativeName = "Name of a policy where definition type is Initiative and category is Guest Configuration";
         public const string InitiativeId = "Definition Id of a policy where definition type is Initiative and category is Guest Configuration";
-        public const string Id = "Id of a Guest Configuration policy status. A policy where definition type is Initiative and category is Guest Configuration must be assigned to a scope to get statuses.";
+        public const string ReportId = "Id of a Guest Configuration policy status. A policy where definition type is Initiative and category is Guest Configuration must be assigned to a scope to get statuses.";
         public const string ShowOnlyChange = "Shows historical status changes only for guest configuration policies. Skips statuses that have not changed between two compliance status audit runs.";
     }
 }

src/GuestConfiguration/GuestConfiguration.Test/SessionRecords/Microsoft.Azure.Commands.GuestConfiguration.Test.ScenarioTests.GetVmGuestPolicyStatusHistoryTests/ShowOnlyChangeSwitchVmNameScope.json

@@ -22,6 +22,6 @@ public static class ParameterSetNames
         public const string VmNameScope = "VmScope";
         public const string InitiativeNameScope = "InitiativeNameScope";
         public const string InitiativeIdScope = "InitiativeIdScope";
-        public const string IdScope = "IdScope";
+        public const string ReportIdScope = "ReportIdScope";
     }
 }

src/GuestConfiguration/GuestConfiguration.Test/SessionRecords/Microsoft.Azure.Commands.GuestConfiguration.Test.ScenarioTests.GetVmGuestPolicyStatusHistoryTests/VmNameScope.json

@@ -14,7 +14,7 @@
                     <TableColumnHeader><Label>StartTime</Label><Width>10</Width></TableColumnHeader>
                     <TableColumnHeader><Label>EndTime</Label><Width>10</Width></TableColumnHeader>
                     <TableColumnHeader><Label>VMName</Label><Width>10</Width></TableColumnHeader>
-                    <TableColumnHeader><Label>Id</Label><Width>10</Width></TableColumnHeader>
+                    <TableColumnHeader><Label>ReportId</Label><Width>10</Width></TableColumnHeader>
                 </TableHeaders>
                 <TableRowEntries>
                     <TableRowEntry>
@@ -36,7 +36,7 @@
                             <TableColumnItem><ScriptBlock>$_.StartTime.ToString("MM/dd/yyyy hh:mm:ss tt")</ScriptBlock></TableColumnItem>
                             <TableColumnItem><ScriptBlock>$_.EndTime.ToString("MM/dd/yyyy hh:mm:ss tt")</ScriptBlock></TableColumnItem>
                             <TableColumnItem><ScriptBlock>$_.VM.ResourceId.Substring($_.VM.ResourceId.LastIndexOf("/")+1)</ScriptBlock></TableColumnItem>
-                            <TableColumnItem><ScriptBlock>".." + $_.Id.Substring($_.Id.LastIndexOf("/"), 37)</ScriptBlock></TableColumnItem>
+                            <TableColumnItem><ScriptBlock>".." + $_.ReportId.Substring($_.ReportId.LastIndexOf("/"), 37)</ScriptBlock></TableColumnItem>
                         </TableColumnItems>
                     </TableRowEntry>
                 </TableRowEntries>
@@ -54,7 +54,7 @@
                     <TableColumnHeader><Label>StartTime</Label><Width>10</Width></TableColumnHeader>
                     <TableColumnHeader><Label>EndTime</Label><Width>10</Width></TableColumnHeader>
                     <TableColumnHeader><Label>VMName</Label><Width>10</Width></TableColumnHeader>
-                    <TableColumnHeader><Label>Id</Label><Width>10</Width></TableColumnHeader>
+                    <TableColumnHeader><Label>ReportId</Label><Width>10</Width></TableColumnHeader>
                 </TableHeaders>
                 <TableRowEntries>
                     <TableRowEntry>
@@ -64,7 +64,7 @@
                             <TableColumnItem><ScriptBlock>$_.StartTime.ToString("MM/dd/yyyy hh:mm:ss tt")</ScriptBlock></TableColumnItem>
                             <TableColumnItem><ScriptBlock>$_.EndTime.ToString("MM/dd/yyyy hh:mm:ss tt")</ScriptBlock></TableColumnItem>
                             <TableColumnItem><ScriptBlock>$_.VM.ResourceId.Substring($_.VM.ResourceId.LastIndexOf("/")+1)</ScriptBlock></TableColumnItem>
-                            <TableColumnItem><ScriptBlock>".." + $_.Id.Substring($_.Id.LastIndexOf("/"), 37)</ScriptBlock></TableColumnItem>
+                            <TableColumnItem><ScriptBlock>".." + $_.ReportId.Substring($_.ReportId.LastIndexOf("/"), 37)</ScriptBlock></TableColumnItem>
                         </TableColumnItems>
                     </TableRowEntry>
                 </TableRowEntries>

src/GuestConfiguration/GuestConfiguration.Test/SessionRecords/Microsoft.Azure.Commands.GuestConfiguration.Test.ScenarioTests.GetVmGuestPolicyStatusTests/IdScope.json

@@ -37,7 +37,7 @@ public PolicyStatus(GuestConfigurationAssignmentReport gcrpReport, PolicyData gc
 
             if (gcrpReport != null && gcrpReport.Properties != null)
             {
-                this.Id = gcrpReport.Id;
+                this.ReportId = gcrpReport.Id;
                 this.StartTime = gcrpReport.Properties.StartTime;
                 this.EndTime = gcrpReport.Properties.EndTime;
                 this.ComplianceStatus = gcrpReport.Properties.ComplianceStatus;
@@ -61,7 +61,7 @@ public PolicyStatus(GuestConfigurationAssignmentReport gcrpReport, PolicyData gc
 
         public DateTime? EndTime { get; set; }
 
-        public string Id { get; set; }
+        public string ReportId { get; set; }
 
         public VMInfo VM { get; set; }
 

src/GuestConfiguration/GuestConfiguration.Test/SessionRecords/Microsoft.Azure.Commands.GuestConfiguration.Test.ScenarioTests.GetVmGuestPolicyStatusTests/InitiativeIdScope.json

@@ -30,9 +30,9 @@ Get-AzVMGuestPolicyStatus [-ResourceGroupName] <String> [-VMName] <String> [-Ini
  [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
 ```
 
-### IdScope
+### ReportIdScope
 ```
-Get-AzVMGuestPolicyStatus [-Id] <String> [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
+Get-AzVMGuestPolicyStatus [-ReportId] <String> [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
 ```
 
 ## DESCRIPTION
@@ -63,10 +63,10 @@ Get the latest guest configuration policy statuses by initiative name. The statu
 
 ### Example 4
 ```powershell
-PS C:\> Get-AzVMGuestPolicyStatus -Id "/subscriptions/4e6c6ed2-0bf6-41d7-9d21-a452c2cc7920/resourceGroups/MyResourceGroupName/providers/Microsoft.Compute/virtualMachines/MyVMName/providers/Microsoft.GuestConfiguration/guestConfigurationAssignments/MaximumPasswordAge/reports/c271f845-2c0a-4456-a441-e48fc332d0ac"
+PS C:\> Get-AzVMGuestPolicyStatus -ReportId "/subscriptions/4e6c6ed2-0bf6-41d7-9d21-a452c2cc7920/resourceGroups/MyResourceGroupName/providers/Microsoft.Compute/virtualMachines/MyVMName/providers/Microsoft.GuestConfiguration/guestConfigurationAssignments/MaximumPasswordAge/reports/c271f845-2c0a-4456-a441-e48fc332d0ac"
 ```
 
-Get guest configuration policy status by Id. The Id is the Id property that can be found in the results of Get-AzVMGuestPolicyStatus by initiativeId or Initiative name (please refer other examples)
+Get guest configuration policy status by ReportId. The ReportId is the ReportId property that can be found in the results of Get-AzVMGuestPolicyStatus by initiativeId or Initiative name (please refer other examples)
 
 ## PARAMETERS
 
@@ -115,13 +115,12 @@ Accept pipeline input: False
 Accept wildcard characters: False
 ```
 
-### -Id
-Id of a Guest Configuration policy status. 
-A policy where definition type is Initiative and category is Guest Configuration must be assigned to a scope to get statuses.
+### -ReportId
+ReportId of a Guest Configuration policy status. A policy where definition type is Initiative and category is Guest Configuration must be assigned to a scope to get statuses.
 
 ```yaml
 Type: System.String
-Parameter Sets: IdScope
+Parameter Sets: ReportIdScope
 Aliases:
 
 Required: True

src/GuestConfiguration/GuestConfiguration.Test/SessionRecords/Microsoft.Azure.Commands.GuestConfiguration.Test.ScenarioTests.GetVmGuestPolicyStatusTests/InitiativeNameScope.json

@@ -15,8 +15,8 @@ An initiative is a policy of definition type "Initiative".
 
 ### VmScope (Default)
 ```
-Get-AzVMGuestPolicyStatusHistory [-ResourceGroupName] <String> [-VMName] <String>
- [-ShowOnlyChange] [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
+Get-AzVMGuestPolicyStatusHistory [-ResourceGroupName] <String> [-VMName] <String> [-ShowOnlyChange]
+ [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
 ```
 
 ### InitiativeIdScope
@@ -34,7 +34,7 @@ Get-AzVMGuestPolicyStatusHistory [-ResourceGroupName] <String> [-VMName] <String
 ## DESCRIPTION
 The Get-AzVMGuestPolicyStatusHistory cmdlet gets compliance status history of guest configuration policies for an initiative of type "Guest Configuration" that is assigned to a VM.
 An initiative is a policy of definition type "Initiative".
-Use Get-AzVMGuestPolicyStatus cmdlet to get details of a single compliance status using Id that can be found in output of Get-AzVMGuestPolicyStatusHistory cmdlet.
+Use Get-AzVMGuestPolicyStatus cmdlet to get details of a single compliance status using ReportId that can be found in output of Get-AzVMGuestPolicyStatusHistory cmdlet.
 
 ## EXAMPLES
 
@@ -67,27 +67,19 @@ Skips statuses that have not changed between two compliance checks.
 
 ### Example 4
 ```
-PS C:\> Get-AzVMGuestPolicyStatus -Id "/subscriptions/4e6c6ed2-0bf6-41d7-9d21-a452c2cc7920/resourceGroups/MyResourceGroupName/providers/Microsoft.Compute/virtualMachines/MyVMName/providers/Microsoft.GuestConfiguration/guestConfigurationAssignments/MaximumPasswordAge/reports/c271f845-2c0a-4456-a441-e48fc332d0ac"
-```
-
-Get detailed guest configuration policy status by Id.
-The Id is the Id property that can be found in the results of Get-AzVMGuestPolicyStatusHistory by initiativeId or Initiative name (please refer other examples)
-
-### Example 5
-```
 PS C:\> Get-AzVMGuestPolicyStatusHistory -ResourceGroupName "MyResourceGroupName" -VMName "MyVMName" -InitiativeId "/providers/Microsoft.Authorization/policySetDefinitions/3fa7cbf5-c0a4-4a59-85a5-cca4d996d5af"
 ```
 
 Gets compliance status history by initiative Id.
 
-### Example 6
+### Example 5
 ```
 PS C:\> Get-AzVMGuestPolicyStatusHistory -ResourceGroupName "MyResourceGroupName" -VMName "MyVMName" -InitiativeName "b5a822e0-ba98-4e54-9278-5d9833aa9b17"
 ```
 
 Gets compliance status history by initiative name.
 
-### Example 7
+### Example 6
 ```
 PS C:\> Get-AzVMGuestPolicyStatusHistory -ResourceGroupName "MyResourceGroupName" -VMName "MyVMName"
 ```