Resolve PR comments

Author: Mahak Jain

src/AlertsManagement/AlertsManagement.Test/ScenarioTests/SmartGroupTests.ps1

@@ -18,7 +18,9 @@ Test Smart Group change state
 #>
 function Test-SmartGroupChangeState
 {
-	$smartGroupId = "f52ed8ac-fe87-4234-8134-782825645204"
+	# Get latest smart group
+	$smartGroups = Get-AzSmartGroup -TimeRange 1h
+	$smartGroupId = $smartGroups[0].Id
 
 	$oldSmartGroup = Get-AzSmartGroup -SmartGroupId $smartGroupId
 	$newState = "Acknowledged"

src/AlertsManagement/AlertsManagement/ActionRuleCommands/SetAzureActionRule.cs

@@ -13,6 +13,7 @@
 // ----------------------------------------------------------------------------------
 
 using System.Collections.Generic;
+using System.Linq;
 using System.Management.Automation;
 using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
 using Microsoft.Rest.Azure;
@@ -288,7 +289,7 @@ public class SetAzureActionRule : AlertsManagementBaseCmdlet
                  HelpMessage = "Reccurent values, if applicable." +
                     "In case of Weekly - 1,3,5 \n" +
                     "In case of Monthly - 16,24,28 \n")]
-        public List<int?> ReccurentValue { get; set; }
+        public int[] ReccurentValue { get; set; }
 
         /// <summary>
         /// Action rule simplified format : Action Group Id
@@ -347,9 +348,9 @@ protected override void ProcessRecordInternal()
                             endTime: SuppressionEndTime.Split(' ')[1]
                             );
 
-                        if (ReccurentValue.Count > 0)
+                        if (ReccurentValue.Length > 0)
                         {
-                            config.Schedule.RecurrenceValues = ReccurentValue;
+                            //config.Schedule.RecurrenceValues = new List<int?>(ReccurentValue.ToList<int?>());
                         }
                     }
 
@@ -394,7 +395,6 @@ protected override void ProcessRecordInternal()
 
                     break;
                 case ByInputObjectParameterSet:
-                    // TODO: Implement from InputObject
                     break;
             }
 

src/AlertsManagement/AlertsManagement/AlertCommands/MeasureAzureAlertStatistic.cs

@@ -140,10 +140,7 @@ protected override void ProcessRecordInternal()
                 includeSmartGroupsCount: IncludeSmartGroupsCount
                 ).Result.Body);
 
-            // TODO: How to directly call overriden ToString() functions for custom output classes
-            // Defined PSAggregatedCounts in PSSummary
-            WriteObject(summary);
-            WriteObject(summary.AggregatedCounts.ToString());
+            WriteObject(summary.ToString());
         }
     }
 }

src/AlertsManagement/AlertsManagement/AlertsManagementBaseCmdlet.cs

@@ -29,7 +29,6 @@ namespace Microsoft.Azure.Commands.AlertsManagement
     public abstract class AlertsManagementBaseCmdlet : AzureRMCmdlet
     {
         #region Client Declaration
-        // TODO: Uncomment once SDK is published
         private IAlertsManagementClient alertsManagementClient;
 
         /// <summary>

src/AlertsManagement/AlertsManagement/OutputModels/PSAlertsSummary.cs

@@ -38,5 +38,20 @@ public PSAlertsSummary(AlertsSummary summary)
         public int? TotalSmartGroups { get; }
 
         public PSAggregatedCounts AggregatedCounts { get; }
+
+        public override string ToString()
+        {
+            var output = new StringBuilder();
+            output.AppendLine();
+            output.Append(string.Format("GroupBy           : {0}", GroupBy));
+            output.AppendLine();
+            output.Append(string.Format("TotalAlerts       : {0}", TotalAlerts));
+            output.AppendLine();
+            output.Append(string.Format("TotalSmartGroups  : {0}", TotalSmartGroups));
+            output.AppendLine();
+            output.Append(string.Format("Summarization     : {0}", AggregatedCounts.ToString()));
+            output.AppendLine();
+            return output.ToString();
+        }
     }
 }