Skip to content

Commit ecc8fa7

Browse files
Add warning for private zones created with .local suffix
1 parent 3efc6ad commit ecc8fa7

File tree

4 files changed

+35
-0
lines changed

4 files changed

+35
-0
lines changed

src/PrivateDns/PrivateDns/Properties/Resources.Designer.cs

Lines changed: 9 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/PrivateDns/PrivateDns/Properties/Resources.resx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -228,4 +228,7 @@
228228
<data name="Error_RecordSetIsAutoRegistered" xml:space="preserve">
229229
<value>The input provided belongs to an auto registered Record Set. Manual operations on this type of record set is not allowed.</value>
230230
</data>
231+
<data name="Warning_ZoneNameEndsWithLocal" xml:space="preserve">
232+
<value>Please be aware that DNS names ending with .local are reserved for use with multicast DNS and may not work as expected with some operating systems. For details refer to your operating systems documentation.</value>
233+
</data>
231234
</root>

src/PrivateDns/PrivateDns/Zones/NewAzurePrivateDnsZone.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,10 @@ public class NewAzurePrivateDnsZone : PrivateDnsBaseCmdlet
4141
public override void ExecuteCmdlet()
4242
{
4343
this.Name = TrimTrailingDotInZoneName(this.Name);
44+
if (this.Name.EndsWith(".local"))
45+
{
46+
this.WriteWarning(ProjectResources.Warning_ZoneNameEndsWithLocal);
47+
}
4448

4549
ConfirmAction(
4650
ProjectResources.Progress_CreatingNewZone,

vim.exe.stackdump

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
Stack trace:
2+
Frame Function Args
3+
00180000000 0018005E0DE (00180230639, 00180230C39, 001802412F0, 000FFFFB740)
4+
00180000000 001800468F9 (CCCCCC00009CC1, FF783B00767676, D6D661000CC616, 000002CCE40)
5+
00180000000 00180046932 (00180230616, 000000001E7, 001802412F0, 76767600CCCCCC)
6+
00180000000 00180043543 (00000000000, 00180000000, 7FF9CEC14E4E, 001800004EC)
7+
00180000000 0018006BF01 (CCCCCC00009CC1, FF783B00767676, D6D661000CC616, 9E00B4005648E7)
8+
00180000000 0018006CD8E (00000000000, 00000000000, 00000000000, 00000000000)
9+
00180000000 0018006ED24 (00000000000, 00000000008, 0006C31E290, 00000000000)
10+
00000000001 00180137221 (0010065D540, 00000000008, 00000000000, 00000000000)
11+
00000000001 0018011DDBB (0010065D540, 00000000008, 00000000000, 00000000000)
12+
00000000001 001004F77E4 (00100575E0A, 00100663D08, 00000000000, 00100663D0C)
13+
00000000001 001005820F3 (00000000008, 00100664140, 00000000000, 00000000000)
14+
00000000001 00100576D86 (00000000000, 0005B4E506C, 0002A688268, 00000010000)
15+
00000000001 001005D4CEB (000FFFFCCD0, 00000000000, 0018011DDBB, 00000000001)
16+
00600049250 001005E218A (00000000020, 001802F7920, 00180047EB8, 00180046E80)
17+
000FFFFCCD0 00180047F24 (00000000000, 00000000000, 00000000000, 00000000000)
18+
00000000000 00180045A03 (00000000000, 00000000000, 00000000000, 00000000000)
19+
End of stack trace (more stack frames may be present)

0 commit comments

Comments
 (0)