Merge pull request Azure#9999 from aim-for-better/CallOutBreakingChange

erich-wang · web-flow · commit ef3f6bfa5cfb · 2019-09-17T14:46:46.000+08:00
[HDInsight] Call out breaking changes
diff --git a/src/HDInsight/HDInsight/ManagementCommands/DisableAzureHDInsightOMSCommand.cs b/src/HDInsight/HDInsight/ManagementCommands/DisableAzureHDInsightOMSCommand.cs
@@ -15,10 +15,12 @@
 using Microsoft.Azure.Commands.HDInsight.Commands;
 using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
 using Microsoft.Azure.Management.HDInsight.Models;
+using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
 using System.Management.Automation;
 
 namespace Microsoft.Azure.Commands.HDInsight
 {
+    [CmdletDeprecation(ReplacementCmdletName = "Disable-AzHDInsightMonitoring")]
     [Cmdlet("Disable", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "HDInsightOperationsManagementSuite",SupportsShouldProcess = true)]
     [Alias("Disable-" + ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "HDInsightOMS")]
     [OutputType(typeof(OperationResource))]
diff --git a/src/HDInsight/HDInsight/ManagementCommands/EnableAzureHDInsightOMSCommand.cs b/src/HDInsight/HDInsight/ManagementCommands/EnableAzureHDInsightOMSCommand.cs
@@ -20,9 +20,11 @@
 using System.Reflection;
 using Microsoft.Azure.Commands.Common.Authentication.Abstractions;
 using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
+using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
 
 namespace Microsoft.Azure.Commands.HDInsight
 {
+    [CmdletDeprecation(ReplacementCmdletName = "Enable-AzHDInsightMonitoring")]
     [Cmdlet("Enable", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "HDInsightOperationsManagementSuite",SupportsShouldProcess = true)]
     [Alias("Enable-" + ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "HDInsightOMS")]
     [OutputType(typeof(OperationResource))]
diff --git a/src/HDInsight/HDInsight/ManagementCommands/GetAzureHDInsightOMSCommand.cs b/src/HDInsight/HDInsight/ManagementCommands/GetAzureHDInsightOMSCommand.cs
@@ -15,10 +15,12 @@
 using Microsoft.Azure.Commands.HDInsight.Commands;
 using Microsoft.Azure.Commands.HDInsight.Models.Management;
 using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
+using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
 using System.Management.Automation;
 
 namespace Microsoft.Azure.Commands.HDInsight
 {
+    [CmdletDeprecation(ReplacementCmdletName = "Get-AzHDInsightMonitoring")]
     [Cmdlet("Get", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "HDInsightOperationsManagementSuite")]
     [Alias("Get-" + ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "HDInsightOMS")]
     [OutputType(typeof(AzureHDInsightOMS))]
diff --git a/src/HDInsight/HDInsight/ManagementCommands/GrantAzureHDInsightRdpServicesAccessCommand.cs b/src/HDInsight/HDInsight/ManagementCommands/GrantAzureHDInsightRdpServicesAccessCommand.cs
@@ -16,11 +16,13 @@
 using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
 using Microsoft.Azure.Management.HDInsight.Models;
 using Microsoft.WindowsAzure.Commands.Common;
+using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
 using System;
 using System.Management.Automation;
 
 namespace Microsoft.Azure.Commands.HDInsight
 {
+    [CmdletDeprecation("Clusters using Windows Os Type will not be supported in the future, this cmdlet will be deprecated in an upcoming breaking change release with no replacement. Please create a cluster using Linux Os Type instead.")]
     [Cmdlet("Grant", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "HDInsightRdpServicesAccess"),OutputType(typeof(void))]
     public class GrantAzureHDInsightRdpServicesAccessCommand : HDInsightCmdletBase
     {
diff --git a/src/HDInsight/HDInsight/ManagementCommands/RemoveAzureHDInsightClusterCommand.cs b/src/HDInsight/HDInsight/ManagementCommands/RemoveAzureHDInsightClusterCommand.cs
@@ -15,10 +15,12 @@
 using Microsoft.Azure.Commands.HDInsight.Commands;
 using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
 using Microsoft.Azure.Management.HDInsight.Models;
+using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
 using System.Management.Automation;
 
 namespace Microsoft.Azure.Commands.HDInsight
 {
+    [CmdletOutputBreakingChange(typeof(ClusterGetResponse))]
     [Cmdlet("Remove", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "HDInsightCluster"),OutputType(typeof(ClusterGetResponse))]
     public class RemoveAzureHDInsightCommand : HDInsightCmdletBase
     {
diff --git a/src/HDInsight/HDInsight/ManagementCommands/RevokeAzureHDInsightRdpServicesAccessCommand.cs b/src/HDInsight/HDInsight/ManagementCommands/RevokeAzureHDInsightRdpServicesAccessCommand.cs
@@ -15,10 +15,12 @@
 using Microsoft.Azure.Commands.HDInsight.Commands;
 using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
 using Microsoft.Azure.Management.HDInsight.Models;
+using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
 using System.Management.Automation;
 
 namespace Microsoft.Azure.Commands.HDInsight
 {
+    [CmdletDeprecation("Clusters using Windows Os Type will not be supported in the future, this cmdlet will be deprecated in an upcoming breaking change release with no replacement. Please create a cluster using Linux Os Type instead.")]
     [Cmdlet("Revoke", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "HDInsightRdpServicesAccess"),OutputType(typeof(void))]
     public class RevokeAzureHDInsightRdpServicesAccessCommand : HDInsightCmdletBase
     {
diff --git a/src/HDInsight/HDInsight/ManagementCommands/SetAzureHDInsightGatewayCredentialCommand.cs b/src/HDInsight/HDInsight/ManagementCommands/SetAzureHDInsightGatewayCredentialCommand.cs
@@ -19,12 +19,14 @@
 using Microsoft.Azure.Management.HDInsight.Models;
 using Microsoft.Azure.Management.Internal.Resources.Utilities.Models;
 using Microsoft.WindowsAzure.Commands.Common;
+using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
 using Microsoft.WindowsAzure.Commands.Utilities.Common;
 using System;
 using System.Management.Automation;
 
 namespace Microsoft.Azure.Commands.HDInsight
 {
+    [CmdletOutputBreakingChange(typeof(HttpConnectivitySettings), ReplacementCmdletOutputTypeName = "AzureHDInsightGatewaySettings")]
     [Cmdlet(VerbsCommon.Set, ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "HDInsightGatewayCredential", DefaultParameterSetName = SetByNameParameterSet, SupportsShouldProcess = true), OutputType(typeof(HttpConnectivitySettings))]
     public class SetAzureHDInsightGatewayCredentialCommand : HDInsightCmdletBase
     {

Original file line number	Diff line number	Diff line change
`@@ -16,11 +16,13 @@`
`16`	`16`	`using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;`
`17`	`17`	`using Microsoft.Azure.Management.HDInsight.Models;`
`18`	`18`	`using Microsoft.WindowsAzure.Commands.Common;`
	`19`	`+using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;`
`19`	`20`	`using System;`
`20`	`21`	`using System.Management.Automation;`
`21`	`22`
`22`	`23`	`namespace Microsoft.Azure.Commands.HDInsight`
`23`	`24`	`{`
	`25`	`+ [CmdletDeprecation("Clusters using Windows Os Type will not be supported in the future, this cmdlet will be deprecated in an upcoming breaking change release with no replacement. Please create a cluster using Linux Os Type instead.")]`
`24`	`26`	`[Cmdlet("Grant", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "HDInsightRdpServicesAccess"),OutputType(typeof(void))]`
`25`	`27`	`public class GrantAzureHDInsightRdpServicesAccessCommand : HDInsightCmdletBase`
`26`	`28`	`{`
Original file line number	Diff line number	Diff line change
`@@ -15,10 +15,12 @@`
`15`	`15`	`using Microsoft.Azure.Commands.HDInsight.Commands;`
`16`	`16`	`using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;`
`17`	`17`	`using Microsoft.Azure.Management.HDInsight.Models;`
	`18`	`+using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;`
`18`	`19`	`using System.Management.Automation;`
`19`	`20`
`20`	`21`	`namespace Microsoft.Azure.Commands.HDInsight`
`21`	`22`	`{`
	`23`	`+ [CmdletOutputBreakingChange(typeof(ClusterGetResponse))]`
`22`	`24`	`[Cmdlet("Remove", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "HDInsightCluster"),OutputType(typeof(ClusterGetResponse))]`
`23`	`25`	`public class RemoveAzureHDInsightCommand : HDInsightCmdletBase`
`24`	`26`	`{`
Original file line number	Diff line number	Diff line change
`@@ -19,12 +19,14 @@`
`19`	`19`	`using Microsoft.Azure.Management.HDInsight.Models;`
`20`	`20`	`using Microsoft.Azure.Management.Internal.Resources.Utilities.Models;`
`21`	`21`	`using Microsoft.WindowsAzure.Commands.Common;`
	`22`	`+using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;`
`22`	`23`	`using Microsoft.WindowsAzure.Commands.Utilities.Common;`
`23`	`24`	`using System;`
`24`	`25`	`using System.Management.Automation;`
`25`	`26`
`26`	`27`	`namespace Microsoft.Azure.Commands.HDInsight`
`27`	`28`	`{`
	`29`	`+ [CmdletOutputBreakingChange(typeof(HttpConnectivitySettings), ReplacementCmdletOutputTypeName = "AzureHDInsightGatewaySettings")]`
`28`	`30`	`[Cmdlet(VerbsCommon.Set, ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "HDInsightGatewayCredential", DefaultParameterSetName = SetByNameParameterSet, SupportsShouldProcess = true), OutputType(typeof(HttpConnectivitySettings))]`
`29`	`31`	`public class SetAzureHDInsightGatewayCredentialCommand : HDInsightCmdletBase`
`30`	`32`	`{`