Address PR comments

azdevxps · azdevxps · commit f4634bb78490 · 2017-12-18T14:47:25.000-08:00
diff --git a/src/ResourceManager/ApplicationInsights/Commands.ApplicationInsights/ApplicationInsights/ApplicationInsightsBaseCmdlet.cs b/src/ResourceManager/ApplicationInsights/Commands.ApplicationInsights/ApplicationInsights/ApplicationInsightsBaseCmdlet.cs
@@ -99,8 +99,7 @@ public IApplicationInsightsManagementClient AppInsightsManagementClient
             {
                 if (appInsightsManagementClientWrapper == null)
                 {
-                    appInsightsManagementClientWrapper = new ApplicationInsightsManagementClientWrapper(DefaultProfile.DefaultContext)
-                    {};
+                    appInsightsManagementClientWrapper = new ApplicationInsightsManagementClientWrapper(DefaultProfile.DefaultContext);
                 }
 
                 this.appInsightsManagementClientWrapper.VerboseLogger = WriteVerboseWithTimestamp;
diff --git a/src/ResourceManager/CognitiveServices/Commands.Management.CognitiveServices/CognitiveServicesAccount/CognitiveServicesAccountBaseCmdlet.cs b/src/ResourceManager/CognitiveServices/Commands.Management.CognitiveServices/CognitiveServicesAccount/CognitiveServicesAccountBaseCmdlet.cs
@@ -85,8 +85,7 @@ public ICognitiveServicesManagementClient CognitiveServicesClient
             {
                 if (cognitiveServicesClientWrapper == null)
                 {
-                    cognitiveServicesClientWrapper = new CognitiveServicesManagementClientWrapper(DefaultProfile.DefaultContext)
-                    {};
+                    cognitiveServicesClientWrapper = new CognitiveServicesManagementClientWrapper(DefaultProfile.DefaultContext);
                 }
 
                 this.cognitiveServicesClientWrapper.VerboseLogger = WriteVerboseWithTimestamp;
diff --git a/src/ResourceManager/Compute/Commands.Compute/Common/ComputeClientBaseCmdlet.cs b/src/ResourceManager/Compute/Commands.Compute/Common/ComputeClientBaseCmdlet.cs
@@ -32,8 +32,7 @@ public ComputeClient ComputeClient
             {
                 if (computeClient == null)
                 {
-                    computeClient = new ComputeClient(DefaultProfile.DefaultContext)
-                    {};
+                    computeClient = new ComputeClient(DefaultProfile.DefaultContext);
                 }
 
                 this.computeClient.VerboseLogger = WriteVerboseWithTimestamp;
diff --git a/src/ResourceManager/Compute/Commands.Compute/RemoteDesktop/VirtualMachineRemoteDesktopBaseCmdlet.cs b/src/ResourceManager/Compute/Commands.Compute/RemoteDesktop/VirtualMachineRemoteDesktopBaseCmdlet.cs
@@ -26,8 +26,7 @@ public NetworkClient NetworkClient
             {
                 if (networkClient == null)
                 {
-                    networkClient = new NetworkClient(DefaultProfile.DefaultContext)
-                    {};
+                    networkClient = new NetworkClient(DefaultProfile.DefaultContext);
                 }
 
                 this.networkClient.VerboseLogger = WriteVerboseWithTimestamp;
diff --git a/src/ResourceManager/Compute/Stack/Commands.Compute/Common/ComputeClientBaseCmdlet.cs b/src/ResourceManager/Compute/Stack/Commands.Compute/Common/ComputeClientBaseCmdlet.cs
@@ -34,8 +34,7 @@ public ComputeClient ComputeClient
             {
                 if (computeClient == null)
                 {
-                    computeClient = new ComputeClient(DefaultProfile.DefaultContext)
-                    {};
+                    computeClient = new ComputeClient(DefaultProfile.DefaultContext);
                 }
 
                 this.computeClient.VerboseLogger = WriteVerboseWithTimestamp;
diff --git a/src/ResourceManager/Compute/Stack/Commands.Compute/RemoteDesktop/VirtualMachineRemoteDesktopBaseCmdlet.cs b/src/ResourceManager/Compute/Stack/Commands.Compute/RemoteDesktop/VirtualMachineRemoteDesktopBaseCmdlet.cs
@@ -27,8 +27,7 @@ public NetworkClient NetworkClient
             {
                 if (networkClient == null)
                 {
-                    networkClient = new NetworkClient(DefaultProfile.DefaultContext)
-                    {};
+                    networkClient = new NetworkClient(DefaultProfile.DefaultContext);
                 }
 
                 this.networkClient.VerboseLogger = WriteVerboseWithTimestamp;
diff --git a/src/ResourceManager/ContainerRegistry/Commands.ContainerRegistry/Models/ContainerRegistryCmdletBase.cs b/src/ResourceManager/ContainerRegistry/Commands.ContainerRegistry/Models/ContainerRegistryCmdletBase.cs
@@ -90,8 +90,7 @@ public ContainerRegistryClient RegistryClient
             {
                 if (_RegistryClient == null)
                 {
-                    _RegistryClient = new ContainerRegistryClient(DefaultContext)
-                    {};
+                    _RegistryClient = new ContainerRegistryClient(DefaultContext);
                 }
 
                 this._RegistryClient.VerboseLogger = WriteVerboseWithTimestamp;
diff --git a/src/ResourceManager/LogicApp/Commands.LogicApp/Utilities/LogicAppBaseCmdlet.cs b/src/ResourceManager/LogicApp/Commands.LogicApp/Utilities/LogicAppBaseCmdlet.cs
@@ -35,8 +35,7 @@ public IntegrationAccountClient IntegrationAccountClient
         {
             get
             {
-                this._integartionAccountClient = new IntegrationAccountClient(DefaultProfile.DefaultContext)
-                {};
+                this._integartionAccountClient = new IntegrationAccountClient(DefaultProfile.DefaultContext);
 
                 this._integartionAccountClient.VerboseLogger = WriteVerboseWithTimestamp;
                 this._integartionAccountClient.ErrorLogger = WriteErrorWithTimestamp;
diff --git a/src/ResourceManager/MachineLearning/Commands.MachineLearning/Cmdlets/CommitmentPlans/CommitmentPlansCmdletBase.cs b/src/ResourceManager/MachineLearning/Commands.MachineLearning/Cmdlets/CommitmentPlans/CommitmentPlansCmdletBase.cs
@@ -32,8 +32,7 @@ public CommitmentPlansClient CommitmentPlansClient
             {
                 if (this.commitmentPlansClient == null)
                 {
-                    this.commitmentPlansClient = new CommitmentPlansClient(DefaultProfile.DefaultContext)
-                    {};
+                    this.commitmentPlansClient = new CommitmentPlansClient(DefaultProfile.DefaultContext);
                 }
 
                 this.commitmentPlansClient.VerboseLogger = WriteVerboseWithTimestamp;
diff --git a/src/ResourceManager/MachineLearning/Commands.MachineLearning/Cmdlets/WebServices/WebServicesCmdletBase.cs b/src/ResourceManager/MachineLearning/Commands.MachineLearning/Cmdlets/WebServices/WebServicesCmdletBase.cs
@@ -28,8 +28,7 @@ public WebServicesClient WebServicesClient
             {
                 if (this.webServicesClient == null)
                 {
-                    this.webServicesClient = new WebServicesClient(DefaultProfile.DefaultContext)
-                    {};
+                    this.webServicesClient = new WebServicesClient(DefaultProfile.DefaultContext);
                 }
 
                 this.webServicesClient.VerboseLogger = WriteVerboseWithTimestamp;
diff --git a/src/ResourceManager/Network/Commands.Network/Common/NetworkBaseCmdlet.cs b/src/ResourceManager/Network/Commands.Network/Common/NetworkBaseCmdlet.cs
@@ -30,8 +30,7 @@ public NetworkClient NetworkClient
             {
                 if (_networkClient == null)
                 {
-                    _networkClient = new NetworkClient(DefaultProfile.DefaultContext)
-                    {};
+                    _networkClient = new NetworkClient(DefaultProfile.DefaultContext);
                 }
 
                 this._networkClient.VerboseLogger = WriteVerboseWithTimestamp;
diff --git a/src/ResourceManager/Network/Stack/Commands.Network/Common/NetworkBaseCmdlet.cs b/src/ResourceManager/Network/Stack/Commands.Network/Common/NetworkBaseCmdlet.cs
@@ -29,8 +29,7 @@ public NetworkClient NetworkClient
             {
                 if (_networkClient == null)
                 {
-                    _networkClient = new NetworkClient(DefaultProfile.DefaultContext)
-                    {};
+                    _networkClient = new NetworkClient(DefaultProfile.DefaultContext);
                 }
 
                 this._networkClient.VerboseLogger = WriteVerboseWithTimestamp;
diff --git a/src/ResourceManager/Resources/Commands.ResourceManager/Cmdlets/Implementation/CmdletBase/ResourceManagerCmdletBase.cs b/src/ResourceManager/Resources/Commands.ResourceManager/Cmdlets/Implementation/CmdletBase/ResourceManagerCmdletBase.cs
@@ -293,8 +293,7 @@ public ResourceManagerSdkClient ResourceManagerSdkClient
             {
                 if (this.resourceManagerSdkClient == null)
                 {
-                    this.resourceManagerSdkClient = new ResourceManagerSdkClient(DefaultContext)
-                    {};
+                    this.resourceManagerSdkClient = new ResourceManagerSdkClient(DefaultContext);
                 }
 
                 this.resourceManagerSdkClient.VerboseLogger = WriteVerboseWithTimestamp;
diff --git a/src/ResourceManager/Resources/Commands.Resources.Test/ScenarioTests/ResourceGroupTests.ps1 b/src/ResourceManager/Resources/Commands.Resources.Test/ScenarioTests/ResourceGroupTests.ps1
@@ -88,8 +88,8 @@ function Test-CreatesAndRemoveResourceGroupViaPiping
     New-AzureRmResourceGroup -Name $rgname1 -Location $location
     New-AzureRmResourceGroup -Name $rgname2 -Location $location
 
-    Get-AzureRmResourceGroup | where {$_.ResourceGroupName -eq $rgname1 -or $_.ResourceGroupName -eq $rgname2} | Remove-AzureRmResourceGroup -Force -AsJob
-	Get-Job | Wait-Job
+    $job = Get-AzureRmResourceGroup | where {$_.ResourceGroupName -eq $rgname1 -or $_.ResourceGroupName -eq $rgname2} | Remove-AzureRmResourceGroup -Force -AsJob
+	Wait-Job $job
 
     # Assert
     Get-AzureRmResourceGroup -Name $rgname1 -ErrorAction SilentlyContinue
@@ -250,9 +250,9 @@ function Test-RemoveDeployment
     {
         # Test
         New-AzureRmResourceGroup -Name $rgName -Location "East US"
-        New-AzureRmResourceGroupDeployment -ResourceGroupName $rgName -Name $deploymentName -TemplateUri $templateUri -AsJob
-		Get-Job | Wait-Job
-		$deployment = Get-Job | Receive-Job
+        $job = New-AzureRmResourceGroupDeployment -ResourceGroupName $rgName -Name $deploymentName -TemplateUri $templateUri -AsJob
+		Wait-Job $job
+		$deployment = Receive-Job $job
         Assert-True { Remove-AzureRmResourceGroupDeployment -ResourceGroupName $deployment.ResourceGroupName -Name $deployment.DeploymentName }
     }
     finally
diff --git a/src/ResourceManager/Storage/Commands.Management.Storage/StorageAccount/StorageAccountBaseCmdlet.cs b/src/ResourceManager/Storage/Commands.Management.Storage/StorageAccount/StorageAccountBaseCmdlet.cs
@@ -80,8 +80,7 @@ public IStorageManagementClient StorageClient
             {
                 if (storageClientWrapper == null)
                 {
-                    storageClientWrapper = new StorageManagementClientWrapper(DefaultProfile.DefaultContext)
-                    {};
+                    storageClientWrapper = new StorageManagementClientWrapper(DefaultProfile.DefaultContext);
                 }
 
                 this.storageClientWrapper.VerboseLogger = WriteVerboseWithTimestamp;
diff --git a/src/ResourceManager/Storage/Stack/Commands.Management.Storage/StorageAccount/StorageAccountBaseCmdlet.cs b/src/ResourceManager/Storage/Stack/Commands.Management.Storage/StorageAccount/StorageAccountBaseCmdlet.cs
@@ -57,8 +57,7 @@ public IStorageManagementClient StorageClient
             {
                 if (storageClientWrapper == null)
                 {
-                    storageClientWrapper = new StorageManagementClientWrapper(DefaultProfile.DefaultContext)
-                    {};
+                    storageClientWrapper = new StorageManagementClientWrapper(DefaultProfile.DefaultContext);
                 }
 
                 this.storageClientWrapper.VerboseLogger = WriteVerboseWithTimestamp;
diff --git a/src/ResourceManager/Tags/Commands.Tags/Model/TagBaseCmdlet.cs b/src/ResourceManager/Tags/Commands.Tags/Model/TagBaseCmdlet.cs
@@ -26,11 +26,7 @@ public TagsClient TagsClient
             {
                 if (tagsClient == null)
                 {
-                    tagsClient = new TagsClient(DefaultContext)
-                    {
-                        VerboseLogger = WriteVerboseWithTimestamp,
-                        ErrorLogger = WriteErrorWithTimestamp
-                    };
+                    tagsClient = new TagsClient(DefaultContext);
                 }
 
                 this.tagsClient.VerboseLogger = WriteVerboseWithTimestamp;
diff --git a/src/ResourceManager/TrafficManager/Commands.TrafficManager2/Utilities/TrafficManagerBaseCmdlet.cs b/src/ResourceManager/TrafficManager/Commands.TrafficManager2/Utilities/TrafficManagerBaseCmdlet.cs
@@ -26,8 +26,7 @@ public TrafficManagerClient TrafficManagerClient
             {
                 if (this.trafficManagerClient == null)
                 {
-                    this.trafficManagerClient = new TrafficManagerClient(DefaultProfile.DefaultContext)
-                    {};
+                    this.trafficManagerClient = new TrafficManagerClient(DefaultProfile.DefaultContext);
                 }
 
                 this.trafficManagerClient.VerboseLogger = WriteVerboseWithTimestamp;
diff --git a/src/ResourceManager/Websites/Commands.Websites/Models.WebApp/WebAppBaseClient.cs b/src/ResourceManager/Websites/Commands.Websites/Models.WebApp/WebAppBaseClient.cs
@@ -28,8 +28,7 @@ public ResourceClient ResourcesClient
             {
                 if (_resourcesClient == null)
                 {
-                    _resourcesClient = new ResourceClient(DefaultProfile.DefaultContext)
-                    {};
+                    _resourcesClient = new ResourceClient(DefaultProfile.DefaultContext);
                 }
 
                 this._resourcesClient.VerboseLogger = WriteVerboseWithTimestamp;

Original file line number	Diff line number	Diff line change
`@@ -99,8 +99,7 @@ public IApplicationInsightsManagementClient AppInsightsManagementClient`
`99`	`99`	`{`
`100`	`100`	`if (appInsightsManagementClientWrapper == null)`
`101`	`101`	`{`
`102`		`- appInsightsManagementClientWrapper = new ApplicationInsightsManagementClientWrapper(DefaultProfile.DefaultContext)`
`103`		`- {};`
	`102`	`+ appInsightsManagementClientWrapper = new ApplicationInsightsManagementClientWrapper(DefaultProfile.DefaultContext);`
`104`	`103`	`}`
`105`	`104`
`106`	`105`	`this.appInsightsManagementClientWrapper.VerboseLogger = WriteVerboseWithTimestamp;`
Original file line number	Diff line number	Diff line change
`@@ -85,8 +85,7 @@ public ICognitiveServicesManagementClient CognitiveServicesClient`
`85`	`85`	`{`
`86`	`86`	`if (cognitiveServicesClientWrapper == null)`
`87`	`87`	`{`
`88`		`- cognitiveServicesClientWrapper = new CognitiveServicesManagementClientWrapper(DefaultProfile.DefaultContext)`
`89`		`- {};`
	`88`	`+ cognitiveServicesClientWrapper = new CognitiveServicesManagementClientWrapper(DefaultProfile.DefaultContext);`
`90`	`89`	`}`
`91`	`90`
`92`	`91`	`this.cognitiveServicesClientWrapper.VerboseLogger = WriteVerboseWithTimestamp;`
Original file line number	Diff line number	Diff line change
`@@ -32,8 +32,7 @@ public ComputeClient ComputeClient`
`32`	`32`	`{`
`33`	`33`	`if (computeClient == null)`
`34`	`34`	`{`
`35`		`- computeClient = new ComputeClient(DefaultProfile.DefaultContext)`
`36`		`- {};`
	`35`	`+ computeClient = new ComputeClient(DefaultProfile.DefaultContext);`
`37`	`36`	`}`
`38`	`37`
`39`	`38`	`this.computeClient.VerboseLogger = WriteVerboseWithTimestamp;`
Original file line number	Diff line number	Diff line change
`@@ -26,8 +26,7 @@ public NetworkClient NetworkClient`
`26`	`26`	`{`
`27`	`27`	`if (networkClient == null)`
`28`	`28`	`{`
`29`		`- networkClient = new NetworkClient(DefaultProfile.DefaultContext)`
`30`		`- {};`
	`29`	`+ networkClient = new NetworkClient(DefaultProfile.DefaultContext);`
`31`	`30`	`}`
`32`	`31`
`33`	`32`	`this.networkClient.VerboseLogger = WriteVerboseWithTimestamp;`
Original file line number	Diff line number	Diff line change
`@@ -34,8 +34,7 @@ public ComputeClient ComputeClient`
`34`	`34`	`{`
`35`	`35`	`if (computeClient == null)`
`36`	`36`	`{`
`37`		`- computeClient = new ComputeClient(DefaultProfile.DefaultContext)`
`38`		`- {};`
	`37`	`+ computeClient = new ComputeClient(DefaultProfile.DefaultContext);`
`39`	`38`	`}`
`40`	`39`
`41`	`40`	`this.computeClient.VerboseLogger = WriteVerboseWithTimestamp;`
Original file line number	Diff line number	Diff line change
`@@ -27,8 +27,7 @@ public NetworkClient NetworkClient`
`27`	`27`	`{`
`28`	`28`	`if (networkClient == null)`
`29`	`29`	`{`
`30`		`- networkClient = new NetworkClient(DefaultProfile.DefaultContext)`
`31`		`- {};`
	`30`	`+ networkClient = new NetworkClient(DefaultProfile.DefaultContext);`
`32`	`31`	`}`
`33`	`32`
`34`	`33`	`this.networkClient.VerboseLogger = WriteVerboseWithTimestamp;`
Original file line number	Diff line number	Diff line change
`@@ -90,8 +90,7 @@ public ContainerRegistryClient RegistryClient`
`90`	`90`	`{`
`91`	`91`	`if (_RegistryClient == null)`
`92`	`92`	`{`
`93`		`- _RegistryClient = new ContainerRegistryClient(DefaultContext)`
`94`		`- {};`
	`93`	`+ _RegistryClient = new ContainerRegistryClient(DefaultContext);`
`95`	`94`	`}`
`96`	`95`
`97`	`96`	`this._RegistryClient.VerboseLogger = WriteVerboseWithTimestamp;`
Original file line number	Diff line number	Diff line change
`@@ -35,8 +35,7 @@ public IntegrationAccountClient IntegrationAccountClient`
`35`	`35`	`{`
`36`	`36`	`get`
`37`	`37`	`{`
`38`		`- this._integartionAccountClient = new IntegrationAccountClient(DefaultProfile.DefaultContext)`
`39`		`- {};`
	`38`	`+ this._integartionAccountClient = new IntegrationAccountClient(DefaultProfile.DefaultContext);`
`40`	`39`
`41`	`40`	`this._integartionAccountClient.VerboseLogger = WriteVerboseWithTimestamp;`
`42`	`41`	`this._integartionAccountClient.ErrorLogger = WriteErrorWithTimestamp;`
Original file line number	Diff line number	Diff line change
`@@ -32,8 +32,7 @@ public CommitmentPlansClient CommitmentPlansClient`
`32`	`32`	`{`
`33`	`33`	`if (this.commitmentPlansClient == null)`
`34`	`34`	`{`
`35`		`- this.commitmentPlansClient = new CommitmentPlansClient(DefaultProfile.DefaultContext)`
`36`		`- {};`
	`35`	`+ this.commitmentPlansClient = new CommitmentPlansClient(DefaultProfile.DefaultContext);`
`37`	`36`	`}`
`38`	`37`
`39`	`38`	`this.commitmentPlansClient.VerboseLogger = WriteVerboseWithTimestamp;`
Original file line number	Diff line number	Diff line change
`@@ -28,8 +28,7 @@ public WebServicesClient WebServicesClient`
`28`	`28`	`{`
`29`	`29`	`if (this.webServicesClient == null)`
`30`	`30`	`{`
`31`		`- this.webServicesClient = new WebServicesClient(DefaultProfile.DefaultContext)`
`32`		`- {};`
	`31`	`+ this.webServicesClient = new WebServicesClient(DefaultProfile.DefaultContext);`
`33`	`32`	`}`
`34`	`33`
`35`	`34`	`this.webServicesClient.VerboseLogger = WriteVerboseWithTimestamp;`