Fix build (awslabs#6)

Revert some of the changes I made regarding code style that were a little bit too agressive. We can bring it back to 0 warnings incrementally.

Signed-off-by: David Calavera <[email protected]>

Author: calavera

.github/workflows/build.yml

@@ -64,11 +64,7 @@ jobs:
       - uses: actions-rs/toolchain@v1
         with:
           toolchain: stable
-          components:
-            - rustfmt
-            - clippy
+          components: rustfmt
           override: true
       - name: Run fmt check
         run: cargo fmt --all -- --check
-      - name: Run clippy check
-        run: cargo clippy --all-targets --all-features -- -D warnings

lambda-attributes/src/lib.rs

@@ -1,19 +1,31 @@
-#![deny(clippy::all)]
+#![deny(missing_docs)]
+
+//! The official Rust runtime for AWS Lambda.
+//!
+//! This package contains macro definitions to work with lambda.
+//!
+//! An asynchronous function annotated with the `#[lambda]` attribute must
+//! accept an argument of type `A` which implements [`serde::Deserialize`], a [`lambda::Context`] and
+//! return a `Result<B, E>`, where `B` implements [`serde::Serializable`]. `E` is
+//! any type that implements `Into<Box<dyn std::error::Error + Send + Sync + 'static>>`.
+//! ```
+
 extern crate proc_macro;
 
 use proc_macro::TokenStream;
 use quote::quote_spanned;
 use syn::{spanned::Spanned, AttributeArgs, FnArg, ItemFn, Meta, NestedMeta};
 
 /// Return true if attribute macro args declares http flavor in the form `#[lambda(http)]`
-fn is_http(args: &AttributeArgs) -> bool {
+fn is_http(args: AttributeArgs) -> bool {
     args.iter().any(|arg| match arg {
         NestedMeta::Meta(Meta::Path(path)) => path.is_ident("http"),
         _ => false,
     })
 }
 
 #[proc_macro_attribute]
+/// Wrap an async function into the lambda constructs
 pub fn lambda(attr: TokenStream, item: TokenStream) -> TokenStream {
     let input = syn::parse_macro_input!(item as ItemFn);
     let args = syn::parse_macro_input!(attr as AttributeArgs);
@@ -63,7 +75,7 @@ pub fn lambda(attr: TokenStream, item: TokenStream) -> TokenStream {
             let context_name = &context.pat;
             let context_type = &context.ty;
 
-            if is_http(&args) {
+            if is_http(args) {
                 quote_spanned! { input.span() =>
 
                     #(#attrs)*

lambda-http/src/lib.rs

@@ -1,4 +1,5 @@
-#![deny(clippy::all)]
+#![deny(missing_docs)]
+
 //! Enriches the `lambda` crate with [`http`](https://github.com/hyperium/http)
 //! types targeting AWS [ALB](https://docs.aws.amazon.com/elasticloadbalancing/latest/application/introduction.html), [API Gateway](https://docs.aws.amazon.com/apigateway/latest/developerguide/welcome.html) REST and HTTP API lambda integrations.
 //!

lambda-http/src/request.rs

@@ -156,16 +156,10 @@ pub struct ApiGatewayRequestContext {
     pub resource_id: String,
     /// The deployment stage of the API request (for example, Beta or Prod).
     pub stage: String,
-    /// The domain name of the API Gateway.
-    pub domain_name: String,
-    /// The domain prefix of the API Gateway.
-    pub domain_prefix: String,
     /// The ID that API Gateway assigns to the API request.
     pub request_id: String,
     /// The path to your resource. For example, for the non-proxy request URI of `https://{rest-api-id.execute-api.{region}.amazonaws.com/{stage}/root/child`, The $context.resourcePath value is /root/child.
     pub resource_path: String,
-    /// The HTTP protocol used for this request.
-    pub protocol: String,
     /// The HTTP method used. Valid values include: DELETE, GET, HEAD, OPTIONS, PATCH, POST, and PUT.
     pub http_method: String,
     /// The stringified value of the specified key-value pair of the context map returned from an API Gateway Lambda authorizer function.
@@ -175,11 +169,6 @@ pub struct ApiGatewayRequestContext {
     pub api_id: String,
     /// Cofnito identity information
     pub identity: Identity,
-    /// The time of the request in String format.
-    pub request_time: String,
-    /// The epoch of the request.
-    pub request_time_epoch: i64,
-    pub operation_name: Option<String>,
 }
 
 /// Elastic load balancer context information
@@ -255,6 +244,7 @@ pub struct Identity {
     /// For API methods that require an API key, this variable is the API key associated with the method request.
     /// For methods that don't require an API key, this variable is null.
     pub api_key: Option<String>,
+    /// The identifier of an ApiKey used in a UsagePlan.
     pub api_key_id: Option<String>,
     /// Undocumented. Can be the API key ID associated with an API request that requires an API key.
     /// The description of `api_key` and `access_key` may actually be reversed.
@@ -790,7 +780,7 @@ mod tests {
                 "user": ""
               },
               "resourcePath": "",
-              "authorizer": null,
+              "authorizer": {},
               "httpMethod": "",
               "requestTime": "",
               "requestTimeEpoch": 0,

lambda/src/lib.rs

@@ -1,4 +1,5 @@
-#![deny(clippy::all)]
+#![deny(clippy::all, clippy::cargo)]
+#![warn(missing_docs, nonstandard_style, rust_2018_idioms)]
 
 //! The official Rust runtime for AWS Lambda.
 //!