Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

Commit 251ac04

Browse files
Shi Shucopybara-github
authored andcommitted
fix(tooltip): Fix rich tooltip tests to not use aria-describedby to associate rich tooltips with their anchor elements. This is because interactive rich tooltips should not be used with aria-describedby per a11y guidance.
PiperOrigin-RevId: 351416228
1 parent 7584267 commit 251ac04

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

packages/mdc-tooltip/test/component.test.ts

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ describe('MDCTooltip', () => {
297297
describe('default interactive rich tooltip tests', () => {
298298
beforeEach(() => {
299299
fixture = getFixture(`<div>
300-
<button aria-describedby="tt0" aria-haspopup="dialog" aria-expanded="false">
300+
<button data-tooltip-id="tt0" aria-haspopup="dialog" aria-expanded="false">
301301
anchor
302302
</button>
303303
<div id="tt0" class="mdc-tooltip mdc-tooltip--rich" aria-hidden="true" role="dialog">
@@ -329,7 +329,7 @@ describe('MDCTooltip', () => {
329329
it('sets aria-expanded on anchor to true when showing rich tooltip', () => {
330330
const tooltipElem = fixture.querySelector<HTMLElement>('#tt0')!;
331331
const anchorElem =
332-
fixture.querySelector<HTMLElement>('[aria-describedby]')!;
332+
fixture.querySelector<HTMLElement>('[data-tooltip-id]')!;
333333
MDCTooltip.attachTo(tooltipElem);
334334

335335
emitEvent(anchorElem, 'mouseenter');
@@ -342,7 +342,7 @@ describe('MDCTooltip', () => {
342342
() => {
343343
const tooltipElem = fixture.querySelector<HTMLElement>('#tt0')!;
344344
const anchorElem =
345-
fixture.querySelector<HTMLElement>('[aria-describedby]')!;
345+
fixture.querySelector<HTMLElement>('[data-tooltip-id]')!;
346346
MDCTooltip.attachTo(tooltipElem);
347347

348348
emitEvent(anchorElem, 'mouseenter');
@@ -357,7 +357,7 @@ describe('MDCTooltip', () => {
357357
() => {
358358
const tooltipElem = fixture.querySelector<HTMLElement>('#tt0')!;
359359
const anchorElem =
360-
fixture.querySelector<HTMLElement>('[aria-describedby]')!;
360+
fixture.querySelector<HTMLElement>('[data-tooltip-id]')!;
361361
MDCTooltip.attachTo(tooltipElem);
362362

363363
emitEvent(anchorElem, 'mouseenter');
@@ -371,7 +371,7 @@ describe('MDCTooltip', () => {
371371
it('aria-expanded becomes true on anchor when anchor is focused', () => {
372372
const tooltipElem = fixture.querySelector<HTMLElement>('#tt0')!;
373373
const anchorElem =
374-
fixture.querySelector<HTMLElement>('[aria-describedby]')!;
374+
fixture.querySelector<HTMLElement>('[data-tooltip-id]')!;
375375
MDCTooltip.attachTo(tooltipElem);
376376

377377
emitEvent(anchorElem, 'focus');
@@ -384,7 +384,7 @@ describe('MDCTooltip', () => {
384384
() => {
385385
const tooltipElem = fixture.querySelector<HTMLElement>('#tt0')!;
386386
const anchorElem =
387-
fixture.querySelector<HTMLElement>('[aria-describedby]')!;
387+
fixture.querySelector<HTMLElement>('[data-tooltip-id]')!;
388388
MDCTooltip.attachTo(tooltipElem);
389389

390390
emitEvent(anchorElem, 'focus');
@@ -400,7 +400,7 @@ describe('MDCTooltip', () => {
400400
() => {
401401
const tooltipElem = fixture.querySelector<HTMLElement>('#tt0')!;
402402
const anchorElem =
403-
fixture.querySelector<HTMLElement>('[aria-describedby]')!;
403+
fixture.querySelector<HTMLElement>('[data-tooltip-id]')!;
404404
const tooltipActionButton =
405405
fixture.querySelector<HTMLElement>('.mdc-tooltip__action')!;
406406
MDCTooltip.attachTo(tooltipElem);
@@ -423,7 +423,7 @@ describe('MDCTooltip', () => {
423423
}
424424
const tooltipElem = fixture.querySelector<HTMLElement>('#tt0')!;
425425
const anchorElem =
426-
fixture.querySelector<HTMLElement>('[aria-describedby]')!;
426+
fixture.querySelector<HTMLElement>('[data-tooltip-id]')!;
427427
MDCTooltip.attachTo(tooltipElem);
428428

429429
emitEvent(anchorElem, 'focus');
@@ -444,7 +444,7 @@ describe('MDCTooltip', () => {
444444
}
445445
const tooltipElem = fixture.querySelector<HTMLElement>('#tt0')!;
446446
const anchorElem =
447-
fixture.querySelector<HTMLElement>('[aria-describedby]')!;
447+
fixture.querySelector<HTMLElement>('[data-tooltip-id]')!;
448448
MDCTooltip.attachTo(tooltipElem);
449449

450450
emitEvent(anchorElem, 'focus');
@@ -465,7 +465,7 @@ describe('MDCTooltip', () => {
465465
}
466466
const tooltipElem = fixture.querySelector<HTMLElement>('#tt0')!;
467467
const anchorElem =
468-
fixture.querySelector<HTMLElement>('[aria-describedby]')!;
468+
fixture.querySelector<HTMLElement>('[data-tooltip-id]')!;
469469
MDCTooltip.attachTo(tooltipElem);
470470

471471
emitEvent(anchorElem, 'focus');
@@ -485,7 +485,7 @@ describe('MDCTooltip', () => {
485485
}
486486
const tooltipElem = fixture.querySelector<HTMLElement>('#tt0')!;
487487
const anchorElem =
488-
fixture.querySelector<HTMLElement>('[aria-describedby]')!;
488+
fixture.querySelector<HTMLElement>('[data-tooltip-id]')!;
489489
MDCTooltip.attachTo(tooltipElem);
490490

491491
emitEvent(anchorElem, 'focus');
@@ -508,7 +508,7 @@ describe('MDCTooltip', () => {
508508
const tooltipContent =
509509
fixture.querySelector<HTMLElement>('.mdc-tooltip__content')!;
510510
const anchorElem =
511-
fixture.querySelector<HTMLElement>('[aria-describedby]')!;
511+
fixture.querySelector<HTMLElement>('[data-tooltip-id]')!;
512512
MDCTooltip.attachTo(tooltipElem);
513513

514514
emitEvent(anchorElem, 'focus');

0 commit comments

Comments
 (0)