Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

Commit 9687353

Browse files
joyzhongcopybara-github
authored andcommitted
fix(slider): Add aria-hidden to value indicator container, to avoid duplicate value announcements for screenreader users.
PiperOrigin-RevId: 350350886
1 parent b28c576 commit 9687353

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

packages/mdc-slider/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ To create a discrete slider, add the following:
153153
</div>
154154
</div>
155155
<div class="mdc-slider__thumb">
156-
<div class="mdc-slider__value-indicator-container">
156+
<div class="mdc-slider__value-indicator-container" aria-hidden="true">
157157
<div class="mdc-slider__value-indicator">
158158
<span class="mdc-slider__value-indicator-text">
159159
50
@@ -203,7 +203,7 @@ To add tick marks to a discrete slider, add the following:
203203
</div>
204204
</div>
205205
<div class="mdc-slider__thumb">
206-
<div class="mdc-slider__value-indicator-container">
206+
<div class="mdc-slider__value-indicator-container" aria-hidden="true">
207207
<div class="mdc-slider__value-indicator">
208208
<span class="mdc-slider__value-indicator-text">
209209
50
@@ -228,7 +228,7 @@ To add tick marks to a discrete slider, add the following:
228228
</div>
229229
</div>
230230
<div class="mdc-slider__thumb">
231-
<div class="mdc-slider__value-indicator-container">
231+
<div class="mdc-slider__value-indicator-container" aria-hidden="true">
232232
<div class="mdc-slider__value-indicator">
233233
<span class="mdc-slider__value-indicator-text">
234234
20
@@ -238,7 +238,7 @@ To add tick marks to a discrete slider, add the following:
238238
<div class="mdc-slider__thumb-knob"></div>
239239
</div>
240240
<div class="mdc-slider__thumb">
241-
<div class="mdc-slider__value-indicator-container">
241+
<div class="mdc-slider__value-indicator-container" aria-hidden="true">
242242
<div class="mdc-slider__value-indicator">
243243
<span class="mdc-slider__value-indicator-text">
244244
50

packages/mdc-slider/test/component.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -539,7 +539,7 @@ describe('MDCSlider', () => {
539539
</div>
540540
<div class="mdc-slider__thumb" tabindex="0" role="slider" aria-valuemin="0"
541541
aria-valuemax="100" aria-valuenow="70" style="left:calc(70% - 24px)">
542-
<div class="mdc-slider__value-indicator-container">
542+
<div class="mdc-slider__value-indicator-container" aria-hidden="true">
543543
<div class="mdc-slider__value-indicator">
544544
<span class="mdc-slider__value-indicator-text">70</span>
545545
</div>
@@ -634,7 +634,7 @@ function setUpTest(
634634
{min: isRange ? valueStart || 0 : 0, max: 100, value: value || 0, step});
635635

636636
const valueIndicator = (valueNum: number) => html`
637-
<div class="mdc-slider__value-indicator-container">
637+
<div class="mdc-slider__value-indicator-container" aria-hidden="true">
638638
<div class="mdc-slider__value-indicator">
639639
<span class="mdc-slider__value-indicator-text">
640640
${valueNum}

0 commit comments

Comments
 (0)