Skip to content

Commit 2dcc3d8

Browse files
authored
Merge pull request #132 from basemate/add_sub_tag
add sub tag
2 parents 368b478 + d3f38c4 commit 2dcc3d8

File tree

4 files changed

+123
-0
lines changed

4 files changed

+123
-0
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
%sub{@tag_attributes}
2+
- if options[:text].nil? && block_given?
3+
= yield
4+
- else
5+
= options[:text]
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
module Matestack::Ui::Core::Sub
2+
class Sub < Matestack::Ui::Core::Component::Static
3+
4+
end
5+
end

docs/components/sub.md

Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
# matestack core component: Sub
2+
3+
Show [specs](../../spec/usage/components/sub_spec.rb)
4+
5+
The HTML sub tag implemented in ruby.
6+
7+
## Parameters
8+
9+
This component can take 2 optional configuration params and either yield content or display what gets passed to the `text` configuration param.
10+
11+
#### # id (optional)
12+
Expects a string with all ids the sub should have.
13+
14+
#### # class (optional)
15+
Expects a string with all classes the sub should have.
16+
17+
#### # text (optional)
18+
Expects a string with the text that should go into the `<sub>` tag.
19+
20+
## Example 1: Yield a given block
21+
22+
```ruby
23+
sub id: "foo", class: "bar" do
24+
plain 'Hello World' # optional content
25+
end
26+
```
27+
28+
returns
29+
30+
```html
31+
<sub id="foo" class="bar">
32+
Hello World
33+
</sub>
34+
```
35+
36+
## Example 2: Render options[:text] param
37+
38+
```ruby
39+
sub id: "foo", class: "bar", text: 'Hello World'
40+
```
41+
42+
returns
43+
44+
```html
45+
<sub id="foo" class="bar">
46+
Hello World
47+
</sub>

spec/usage/components/sub_spec.rb

Lines changed: 66 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,66 @@
1+
require_relative "../../support/utils"
2+
include Utils
3+
4+
describe 'Sub Component', type: :feature, js: true do
5+
6+
it 'Example 1 - yield, no options[:text]' do
7+
8+
class ExamplePage < Matestack::Ui::Page
9+
10+
def response
11+
components {
12+
# simple sub
13+
sub do
14+
plain 'I am simple'
15+
end
16+
17+
# enhanced sub
18+
sub id: 'my-id', class: 'my-class' do
19+
plain 'I am enhanced'
20+
end
21+
}
22+
end
23+
24+
end
25+
26+
visit '/example'
27+
28+
static_output = page.html
29+
30+
expected_static_output = <<~HTML
31+
<sub>I am simple</sub>
32+
<sub id="my-id" class="my-class">I am enhanced</sub>
33+
HTML
34+
35+
expect(stripped(static_output)).to include(stripped(expected_static_output))
36+
end
37+
38+
it 'Example 2 - render options[:text]' do
39+
40+
class ExamplePage < Matestack::Ui::Page
41+
42+
def response
43+
components {
44+
# simple sub
45+
sub text: 'I am simple'
46+
47+
# enhanced sub
48+
sub id: 'my-id', class: 'my-class',text: 'I am enhanced'
49+
}
50+
end
51+
52+
end
53+
54+
visit '/example'
55+
56+
static_output = page.html
57+
58+
expected_static_output = <<~HTML
59+
<sub>I am simple</sub>
60+
<sub id="my-id" class="my-class">I am enhanced</sub>
61+
HTML
62+
63+
expect(stripped(static_output)).to include(stripped(expected_static_output))
64+
end
65+
66+
end

0 commit comments

Comments
 (0)