Skip to content

Commit 3ca0bce

Browse files
committed
Implement PR comments
1 parent a1bb875 commit 3ca0bce

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

app/concepts/matestack/ui/core/abbr/abbr.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,6 @@ def setup
77
"title": options[:title]
88
})
99
end
10+
1011
end
1112
end

docs/components/abbr.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ The HTML `abbr` tag implemented in ruby.
88

99
This component expects 1 required param, 2 optional configuration params and either yield content or display what gets passed to the `text` configuration param.
1010

11-
#### # title
11+
#### # title - required
1212
Expects a string with the meaning of the abbreviation contained within the tag.
1313

1414
#### # id - optional
@@ -17,6 +17,8 @@ Expects a string with all ids the `abbr` should have.
1717
#### # class - optional
1818
Expects a string with all classes the `abbr` should have.
1919

20+
#### # text - optional
21+
Expects a string which will be displayed as the content inside the `abbr`. If this is not passed, a block must be passed instead.
2022

2123
## Example 1 - render options[:text] param
2224

@@ -35,9 +37,7 @@ returns
3537

3638
```ruby
3739
abbr title: 'Cascading Style Sheets' do
38-
span do
39-
plain 'CSS'
40-
end
40+
span text: 'CSS'
4141
end
4242
```
4343

spec/usage/components/abbr_spec.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,7 @@ class ExamplePage < Matestack::Ui::Page
3333
def response
3434
components {
3535
abbr title: 'Cascading Style Sheets' do
36-
span do
37-
plain 'CSS'
38-
end
36+
span text: 'CSS'
3937
end
4038
}
4139
end

0 commit comments

Comments
 (0)