Merge branch 'develop' into 232

Author: jonasjabari

Gemfile

@@ -26,7 +26,6 @@ group :development, :test do
   gem 'puma'
   gem 'simplecov', require: false, group: :test
   gem 'byebug'
-  gem 'pry-byebug'
   gem 'webmock'
   gem 'pry-rails'
   gem 'pry-byebug'

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    matestack-ui-core (0.7.3)
+    matestack-ui-core (0.7.4)
       cells-haml
       cells-rails
       haml
@@ -121,7 +121,7 @@ GEM
     mini_portile2 (2.4.0)
     minitest (5.14.0)
     nio4r (2.5.2)
-    nokogiri (1.10.7)
+    nokogiri (1.10.8)
       mini_portile2 (~> 2.4.0)
     pipetree (0.1.1)
     pry (0.12.2)
@@ -133,7 +133,7 @@ GEM
     pry-rails (0.3.9)
       pry (>= 0.10.4)
     public_suffix (4.0.3)
-    puma (4.3.1)
+    puma (4.3.3)
       nio4r (~> 2.0)
     rack (2.2.1)
     rack-proxy (0.6.5)

app/concepts/matestack/ui/core/app/app.js

@@ -10,12 +10,20 @@ const componentDef = {
   },
   computed: Vuex.mapState({
     asyncTemplate: state => state.pageTemplate,
+    currentPathName: state => state.currentPathName,
+    currentSearch: state => state.currentSearch,
+    currentOrigin: state => state.currentOrigin,
   }),
   mounted: function(){
+    const self = this;
     window.onpopstate = (event) => {
-      if (isNavigatingToAnotherPage(document.location, event)) {
-        this.$store.dispatch("navigateTo", {url: document.location.pathname, backwards: true} );
-      };
+      if (isNavigatingToAnotherPage({
+          origin: self.currentOrigin,
+          pathName: self.currentPathName,
+          search: self.currentSearch
+        }, document.location)){
+        self.$store.dispatch("navigateTo", {url: document.location.pathname, backwards: true} );
+      }
     }
   },
   components: {

app/concepts/matestack/ui/core/app/location.js

@@ -1,8 +1,7 @@
-const isNavigatingToAnotherPage = function(currentLocation, popstateEvent) {
-  const targetLocation = popstateEvent.target.location;
+const isNavigatingToAnotherPage = function(currentLocation, targetLocation) {
 
   // omits hash by design
-  return currentLocation.pathname !== targetLocation.pathname ||
+  return currentLocation.pathName !== targetLocation.pathname ||
     currentLocation.origin !== targetLocation.origin ||
     currentLocation.search !== targetLocation.search
 }

app/concepts/matestack/ui/core/app/store.js

@@ -8,14 +8,18 @@ Vue.use(Vuex)
 const store = new Vuex.Store({
   state: {
     pageTemplate: null,
-    currentPath: document.location.pathname
+    currentPathName: document.location.pathname,
+    currentSearch: document.location.search,
+    currentOrigin: document.location.origin
   },
   mutations: {
     setPageTemplate (state, serverResponse){
       state.pageTemplate = serverResponse
     },
-    setCurrentPath (state, path){
-      state.currentPath = path
+    setCurrentLocation (state, current){
+      state.currentPathName = current.path
+      state.currentSearch = current.search
+      state.currentOrigin = current.origin
     }
   },
   actions: {
@@ -46,7 +50,7 @@ const store = new Vuex.Store({
           setTimeout(function () {
             resolve(response["data"])
             commit('setPageTemplate', response["data"])
-            commit('setCurrentPath', url)
+            commit('setCurrentLocation', { path: url, search: document.location.search, origin: document.location.origin })
             matestackEventHub.$emit("page_loaded", url);
             if (typeof matestackUiCoreTransitionSuccess !== 'undefined') {
               matestackUiCoreTransitionSuccess(url);

app/concepts/matestack/ui/core/form/form.js

@@ -137,7 +137,7 @@ const componentDef = {
           && self.componentConfig["success"]["transition"]["follow_response"] === true
           && self.$store != undefined
         ) {
-          let path = response.data["transition_to"]
+          let path = response.data["transition_to"] || response.request.responseURL
           self.$store.dispatch('navigateTo', {url: path, backwards: false})
           return;
         }

app/lib/matestack/ui/core/has_view_context.rb

@@ -5,6 +5,10 @@ def initialize(model = nil, options = {})
   end
 
   def method_missing(*args, &block)
-    @view_context.send(*args, &block)
+    if @view_context.respond_to? args.first
+      @view_context.send(*args, &block)
+    else
+      super
+    end
   end
 end

builder/Gemfile

@@ -6,7 +6,7 @@ ruby '2.6.5'
 # Bundle edge Rails instead: gem 'rails', github: 'rails/rails'
 gem 'rails', '~> 5.2.0'
 # Use Puma as the app server
-gem 'puma', '~> 3.11'
+gem 'puma', '~> 3.12'
 # Use SCSS for stylesheets
 gem 'sass-rails', '~> 5.0'
 # Use Uglifier as compressor for JavaScript assets

builder/Gemfile.lock

@@ -84,9 +84,9 @@ GEM
     minitest (5.14.0)
     msgpack (1.3.1)
     nio4r (2.5.2)
-    nokogiri (1.10.7)
+    nokogiri (1.10.8)
       mini_portile2 (~> 2.4.0)
-    puma (3.12.2)
+    puma (3.12.4)
     rack (2.1.2)
     rack-proxy (0.6.5)
       rack
@@ -168,7 +168,7 @@ DEPENDENCIES
   coffee-rails (~> 4.2)
   jbuilder (~> 2.5)
   listen (>= 3.0.5, < 3.2)
-  puma (~> 3.11)
+  puma (~> 3.12)
   rails (~> 5.2.0)
   sass-rails (~> 5.0)
   tzinfo-data

package.json

@@ -9,7 +9,7 @@
     "v-runtime-template": "^1.5.2",
     "vue": "^2.5.17",
     "vuex": "^3.0.1",
-    "yarn": "^1.17.3"
+    "yarn": "^1.22.0"
   },
   "exports": {
     "./concepts/": "./app/concepts/matestack/ui/core/"

spec/dummy/yarn.lock

@@ -4023,22 +4023,14 @@ js-base64@^2.1.8:
   resolved "https://registry.yarnpkg.com/js-tokens/-/js-tokens-4.0.0.tgz#19203fb59991df98e3a287050d4647cdeaf32499"
   integrity sha512-RdJUflcE3cUzKiMqQgsCu06FPu9UdIJO0beYbPhHN4k6apgJtifcoCtT9bcxOpYBtpD2kCM6Sbzg4CausW/PKQ==
 
-js-yaml@^3.13.1:
+js-yaml@^3.13.1, js-yaml@^3.9.0:
   version "3.13.1"
   resolved "https://registry.yarnpkg.com/js-yaml/-/js-yaml-3.13.1.tgz#aff151b30bfdfa8e49e05da22e7415e9dfa37847"
   integrity sha512-YfbcO7jXDdyj0DGxYVSlSeQNHbD7XPWvrVWeVUujrQEoZzWJIRrCPoyk6kL6IAjAG2IolMK4T0hNUe0HOUs5Jw==
   dependencies:
     argparse "^1.0.7"
     esprima "^4.0.0"
 
-js-yaml@^3.9.0:
-  version "3.12.0"
-  resolved "https://registry.yarnpkg.com/js-yaml/-/js-yaml-3.12.0.tgz#eaed656ec8344f10f527c6bfa1b6e2244de167d1"
-  integrity sha512-PIt2cnwmPfL4hKNwqeiuz4bKfnzHTBv6HyVgjahA6mPLwPDzjDWrplJBMjHUFxku/N3FlmrbyPclad+I+4mJ3A==
-  dependencies:
-    argparse "^1.0.7"
-    esprima "^4.0.0"
-
 jsbn@~0.1.0:
   version "0.1.1"
   resolved "https://registry.yarnpkg.com/jsbn/-/jsbn-0.1.1.tgz#a5e654c2e5a2deb5f201d96cefbca80c0ef2f513"
@@ -4372,7 +4364,7 @@ map-visit@^1.0.0:
     object-visit "^1.0.0"
 
 matestack-ui-core@../../:
-  version "0.7.3"
+  version "0.7.4"
   dependencies:
     axios "^0.18.1"
     link-module-alias "^1.2.0"

spec/usage/components/transition_spec.rb

@@ -3,7 +3,7 @@
 
 describe "Transition Component", type: :feature, js: true do
 
-  it "Example 1 - Perform transition from one page to another without page reload if related to app" do
+  before :all do
 
     class Apps::ExampleApp < Matestack::Ui::App
 
@@ -78,6 +78,10 @@ def page2
     end
     Rails.application.reload_routes!
 
+  end
+
+  it "Example 1 - Perform transition from one page to another without page reload if related to app" do
+
     visit "/my_example_app/page1"
 
     expect(page).to have_content("My Example App Layout")
@@ -113,6 +117,46 @@ def page2
     expect(first_content_on_page_1).not_to eq(refreshed_content_on_page_1)
   end
 
+  it "Example 2 - Perform transition from one page to another without page reload when using page history buttons" do
+
+    visit "/my_example_app/page1"
+
+    expect(page).to have_content("My Example App Layout")
+    expect(page).to have_button("Page 1")
+    expect(page).to have_button("Page 2")
+
+    expect(page).to have_content("This is Page 1")
+    expect(page).not_to have_content("This is Page 2")
+
+    element = page.find("#my-div-on-page-1")
+    first_content_on_page_1 = element.text
+
+    page.evaluate_script('document.body.classList.add("not-reloaded")')
+    expect(page).to have_selector("body.not-reloaded")
+
+    click_button("Page 2")
+
+    expect(page).to have_content("My Example App Layout")
+    expect(page).not_to have_content("This is Page 1")
+    expect(page).to have_content("This is Page 2")
+    expect(page).to have_selector("body.not-reloaded")
+
+    page.go_back
+
+    expect(page).to have_content("My Example App Layout")
+    expect(page).to have_content("This is Page 1")
+    expect(page).not_to have_content("This is Page 2")
+    expect(page).to have_selector("body.not-reloaded")
+    expect(page).to have_no_content(first_content_on_page_1)
+
+    page.go_forward
+
+    expect(page).to have_content("My Example App Layout")
+    expect(page).not_to have_content("This is Page 1")
+    expect(page).to have_content("This is Page 2")
+    expect(page).to have_selector("body.not-reloaded")
+  end
+
   # supposed to work, but doesn't. Suspect Vue is the culprint here
   # it "Example 2 - Perform transition from one page to another by providing route as string (not recommended)" do
   #

vendor/assets/javascripts/dist/manifest.json

@@ -2,17 +2,21 @@
   "entrypoints": {
     "matestack-ui-core": {
       "css": [
-        "/dist/matestack-ui-core.min.css"
+        "/dist/matestack-ui-core.css"
       ],
       "js": [
-        "/dist/matestack-ui-core.min.js"
+        "/dist/matestack-ui-core.js"
+      ],
+      "css.map": [
+        "/dist/matestack-ui-core.css.map"
       ],
       "js.map": [
-        "/dist/matestack-ui-core.min.js.map"
+        "/dist/matestack-ui-core.js.map"
       ]
     }
   },
-  "matestack-ui-core.css": "/dist/matestack-ui-core.min.css",
-  "matestack-ui-core.js": "/dist/matestack-ui-core.min.js",
-  "matestack-ui-core.js.map": "/dist/matestack-ui-core.min.js.map"
+  "matestack-ui-core.css": "/dist/matestack-ui-core.css",
+  "matestack-ui-core.css.map": "/dist/matestack-ui-core.css.map",
+  "matestack-ui-core.js": "/dist/matestack-ui-core.js",
+  "matestack-ui-core.js.map": "/dist/matestack-ui-core.js.map"
 }

vendor/assets/javascripts/dist/matestack-ui-core.js

@@ -101,7 +101,7 @@ vuex@^3.0.1:
   resolved "https://registry.yarnpkg.com/vuex/-/vuex-3.1.1.tgz#0c264bfe30cdbccf96ab9db3177d211828a5910e"
   integrity sha512-ER5moSbLZuNSMBFnEBVGhQ1uCBNJslH9W/Dw2W7GZN23UQA69uapP5GTT9Vm8Trc0PzBSVt6LzF3hGjmv41xcg==
 
-yarn@^1.17.3:
-  version "1.19.1"
-  resolved "https://registry.yarnpkg.com/yarn/-/yarn-1.19.1.tgz#14b92410dd1ba5bab87a12b4a3d807f4569bea97"
-  integrity sha512-gBnfbL9rYY05Gt0cjJhs/siqQXHYlZalTjK3nXn2QO20xbkIFPob+LlH44ML47GcR4VU9/2dYck1BWFM0Javxw==
+yarn@^1.22.0:
+  version "1.22.0"
+  resolved "https://registry.yarnpkg.com/yarn/-/yarn-1.22.0.tgz#acf82906e36bcccd1ccab1cfb73b87509667c881"
+  integrity sha512-KMHP/Jq53jZKTY9iTUt3dIVl/be6UPs2INo96+BnZHLKxYNTfwMmlgHTaMWyGZoO74RI4AIFvnWhYrXq2USJkg==