Skip to content

Commit 9c5d740

Browse files
committed
Merge branch 'develop' into isolate_component_drafting
2 parents 8bb3d1c + 43237d6 commit 9c5d740

File tree

200 files changed

+7615
-2229
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

200 files changed

+7615
-2229
lines changed

.github/issue_template.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
<!-- This is a template only, remove/add sections below as appropriate (e.g. for a new feature, there might be no 'current behaviour'.) -->
2+
3+
<!-- First indicate whether you want to request an ENHANCEMENT or report a BUG by using the correct Github label in the side panel* -->
4+
5+
**What is the current behaviour?**
6+
7+
<!-- add current behaviour here -->
8+
9+
**If the current behaviour is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug might get fixed faster if we can run your code and it doesn't have extra dependencies. Add a link to a sample repo and/or any relevant code below:**
10+
11+
<!-- add additional links/info here -->
12+
13+
**What is the expected behaviour?**
14+
15+
<!-- add expected behaviour here -->
16+
17+
**Which versions of Matestack, and which browser/OS are affected by this issue? Did this work in previous versions of Matestack?**
18+
19+
<!-- add version and browser(s) affected, where relevant -->

.github/pull_request_template.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
## Issue https://github.com/basemate/matestack-ui-core/issues/XXX: Short description here
2+
3+
### Changes
4+
5+
- [x] Describe the changes in one or more bulletpoints
6+
7+
### Notes
8+
9+
- Let the reviewers know something special

CHANGELOG.md

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,28 @@
11
# Changelog
22

3+
## v0.7.1
4+
5+
[Merged PRs](https://github.com/basemate/matestack-ui-core/milestone/3?closed=1)
6+
7+
### Improvements
8+
9+
- Introduce scaffolder #72 by PasWen
10+
- Make buttons disableable enhancement by PasWen
11+
- Collection Component #98 by jonasjabari
12+
- Added Async Defer Feature #100 by jonasjabari
13+
- Added blockquote tag to main component #88 by cameronnorman
14+
- Added small tags #87 by cameronnorman
15+
- Added strong tag #93 by cameronnorman
16+
- Added Infos that async component can currently only be used on page leve #85 by jonasjabari was merged 10
17+
- Update span component in 0.7.0 #74 by PasWen
18+
- Add documented, untested video component #70 by PasWen
19+
- Added summary details components #76 by bdlb77
20+
- Add caption with doc and specs enhancement #68 by michaelrevans
21+
22+
### Bugfixes
23+
24+
- Fixed Link Component #84 by jonasjabari
25+
326
## v0.7.0
427

528
### Breaking changes for users

Gemfile

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,3 +32,7 @@ group :development, :test do
3232
gem 'byebug'
3333
gem 'webmock'
3434
end
35+
36+
group :test do
37+
gem "generator_spec"
38+
end

Gemfile.lock

Lines changed: 55 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
PATH
22
remote: .
33
specs:
4-
matestack-ui-core (0.6.0)
4+
matestack-ui-core (0.7.1)
55
cells-haml
66
cells-rails
77
haml
@@ -13,43 +13,43 @@ PATH
1313
GEM
1414
remote: https://rubygems.org/
1515
specs:
16-
actioncable (5.2.1)
17-
actionpack (= 5.2.1)
16+
actioncable (5.2.3)
17+
actionpack (= 5.2.3)
1818
nio4r (~> 2.0)
1919
websocket-driver (>= 0.6.1)
20-
actionmailer (5.2.1)
21-
actionpack (= 5.2.1)
22-
actionview (= 5.2.1)
23-
activejob (= 5.2.1)
20+
actionmailer (5.2.3)
21+
actionpack (= 5.2.3)
22+
actionview (= 5.2.3)
23+
activejob (= 5.2.3)
2424
mail (~> 2.5, >= 2.5.4)
2525
rails-dom-testing (~> 2.0)
26-
actionpack (5.2.1)
27-
actionview (= 5.2.1)
28-
activesupport (= 5.2.1)
26+
actionpack (5.2.3)
27+
actionview (= 5.2.3)
28+
activesupport (= 5.2.3)
2929
rack (~> 2.0)
3030
rack-test (>= 0.6.3)
3131
rails-dom-testing (~> 2.0)
3232
rails-html-sanitizer (~> 1.0, >= 1.0.2)
33-
actionview (5.2.1)
34-
activesupport (= 5.2.1)
33+
actionview (5.2.3)
34+
activesupport (= 5.2.3)
3535
builder (~> 3.1)
3636
erubi (~> 1.4)
3737
rails-dom-testing (~> 2.0)
3838
rails-html-sanitizer (~> 1.0, >= 1.0.3)
39-
activejob (5.2.1)
40-
activesupport (= 5.2.1)
39+
activejob (5.2.3)
40+
activesupport (= 5.2.3)
4141
globalid (>= 0.3.6)
42-
activemodel (5.2.1)
43-
activesupport (= 5.2.1)
44-
activerecord (5.2.1)
45-
activemodel (= 5.2.1)
46-
activesupport (= 5.2.1)
42+
activemodel (5.2.3)
43+
activesupport (= 5.2.3)
44+
activerecord (5.2.3)
45+
activemodel (= 5.2.3)
46+
activesupport (= 5.2.3)
4747
arel (>= 9.0)
48-
activestorage (5.2.1)
49-
actionpack (= 5.2.1)
50-
activerecord (= 5.2.1)
48+
activestorage (5.2.3)
49+
actionpack (= 5.2.3)
50+
activerecord (= 5.2.3)
5151
marcel (~> 0.3.1)
52-
activesupport (5.2.1)
52+
activesupport (5.2.3)
5353
concurrent-ruby (~> 1.0, >= 1.0.2)
5454
i18n (>= 0.7, < 2)
5555
minitest (~> 5.1)
@@ -81,7 +81,7 @@ GEM
8181
childprocess (0.9.0)
8282
ffi (~> 1.0, >= 1.0.11)
8383
cliver (0.3.2)
84-
concurrent-ruby (1.0.5)
84+
concurrent-ruby (1.1.5)
8585
crack (0.4.3)
8686
safe_yaml (~> 1.0.0)
8787
crass (1.0.4)
@@ -97,69 +97,72 @@ GEM
9797
representable (>= 2.4.0, <= 3.1.0)
9898
uber (< 0.2.0)
9999
docile (1.3.1)
100-
erubi (1.7.1)
100+
erubi (1.8.0)
101101
ffi (1.9.25)
102+
generator_spec (0.9.4)
103+
activesupport (>= 3.0.0)
104+
railties (>= 3.0.0)
102105
globalid (0.4.2)
103106
activesupport (>= 4.2.0)
104107
haml (5.0.4)
105108
temple (>= 0.8.0)
106109
tilt
107110
hashdiff (0.3.8)
108-
i18n (1.1.0)
111+
i18n (1.6.0)
109112
concurrent-ruby (~> 1.0)
110113
json (2.1.0)
111-
loofah (2.2.2)
114+
loofah (2.2.3)
112115
crass (~> 1.0.2)
113116
nokogiri (>= 1.5.9)
114117
mail (2.7.1)
115118
mini_mime (>= 0.1.1)
116119
marcel (0.3.3)
117120
mimemagic (~> 0.3.2)
118-
method_source (0.9.0)
121+
method_source (0.9.2)
119122
mimemagic (0.3.3)
120123
mini_mime (1.0.1)
121-
mini_portile2 (2.3.0)
124+
mini_portile2 (2.4.0)
122125
minitest (5.11.3)
123-
nio4r (2.3.1)
124-
nokogiri (1.8.4)
125-
mini_portile2 (~> 2.3.0)
126+
nio4r (2.4.0)
127+
nokogiri (1.10.3)
128+
mini_portile2 (~> 2.4.0)
126129
pipetree (0.1.1)
127130
poltergeist (1.18.1)
128131
capybara (>= 2.1, < 4)
129132
cliver (~> 0.3.1)
130133
websocket-driver (>= 0.2.0)
131134
public_suffix (3.0.3)
132135
puma (3.12.0)
133-
rack (2.0.5)
136+
rack (2.0.7)
134137
rack-proxy (0.6.5)
135138
rack
136139
rack-test (1.1.0)
137140
rack (>= 1.0, < 3)
138-
rails (5.2.1)
139-
actioncable (= 5.2.1)
140-
actionmailer (= 5.2.1)
141-
actionpack (= 5.2.1)
142-
actionview (= 5.2.1)
143-
activejob (= 5.2.1)
144-
activemodel (= 5.2.1)
145-
activerecord (= 5.2.1)
146-
activestorage (= 5.2.1)
147-
activesupport (= 5.2.1)
141+
rails (5.2.3)
142+
actioncable (= 5.2.3)
143+
actionmailer (= 5.2.3)
144+
actionpack (= 5.2.3)
145+
actionview (= 5.2.3)
146+
activejob (= 5.2.3)
147+
activemodel (= 5.2.3)
148+
activerecord (= 5.2.3)
149+
activestorage (= 5.2.3)
150+
activesupport (= 5.2.3)
148151
bundler (>= 1.3.0)
149-
railties (= 5.2.1)
152+
railties (= 5.2.3)
150153
sprockets-rails (>= 2.0.0)
151154
rails-dom-testing (2.0.3)
152155
activesupport (>= 4.2.0)
153156
nokogiri (>= 1.6)
154157
rails-html-sanitizer (1.0.4)
155158
loofah (~> 2.2, >= 2.2.2)
156-
railties (5.2.1)
157-
actionpack (= 5.2.1)
158-
activesupport (= 5.2.1)
159+
railties (5.2.3)
160+
actionpack (= 5.2.3)
161+
activesupport (= 5.2.3)
159162
method_source
160163
rake (>= 0.8.7)
161164
thor (>= 0.19.0, < 2.0)
162-
rake (12.3.2)
165+
rake (12.3.3)
163166
reform (2.2.4)
164167
disposable (>= 0.4.1)
165168
representable (>= 2.4.0, < 3.1.0)
@@ -207,7 +210,7 @@ GEM
207210
sprockets (>= 3.0.0)
208211
sqlite3 (1.3.13)
209212
temple (0.8.0)
210-
thor (0.20.0)
213+
thor (0.20.3)
211214
thread_safe (0.3.6)
212215
tilt (2.0.8)
213216
trailblazer (2.0.7)
@@ -236,9 +239,9 @@ GEM
236239
activesupport (>= 4.2)
237240
rack-proxy (>= 0.6.1)
238241
railties (>= 4.2)
239-
websocket-driver (0.7.0)
242+
websocket-driver (0.7.1)
240243
websocket-extensions (>= 0.1.0)
241-
websocket-extensions (0.1.3)
244+
websocket-extensions (0.1.4)
242245
xpath (3.2.0)
243246
nokogiri (~> 1.8)
244247

@@ -250,6 +253,7 @@ DEPENDENCIES
250253
capybara
251254
cells-haml
252255
cells-rails
256+
generator_spec
253257
matestack-ui-core!
254258
poltergeist
255259
puma

README.md

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -213,15 +213,7 @@ Changelog can be found [here](./CHANGELOG.md)
213213

214214
### Roadmap
215215

216-
Scheduled for 0.7.0:
217-
- Better naming conventions
218-
- Webpacker/Yarn Integration
219-
- Advanced Websockets Integration
220-
- 1:n Relations in Form components
221-
- More Form Components (Multi Select Components)
222-
- Component Based Caching
223-
- Rails View Integration
224-
- Dockerized Core Development
216+
We're currently finalizing the roadmap towards to a stable 1.0 release, supposed to happen towards the end of the year! For details make sure to check the [release management project](https://github.com/basemate/matestack-ui-core/projects/2) and get in touch via our [chat](https://gitter.im/basemate/community) for feedback!
225217

226218
### Community
227219

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
%abbr{@tag_attributes}
2+
- if options[:text].blank? && block_given?
3+
= yield
4+
- else
5+
= options[:text]
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
module Matestack::Ui::Core::Abbr
2+
class Abbr < Matestack::Ui::Core::Component::Static
3+
REQUIRED_KEYS = [:title]
4+
5+
def setup
6+
@tag_attributes.merge!({
7+
"title": options[:title]
8+
})
9+
end
10+
11+
end
12+
end

app/concepts/matestack/ui/core/app/app.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ def self.views_dir
5353
return ""
5454
end
5555

56-
5756
def initialize(model=nil, options={})
5857
super
5958
@nodes = {}

app/concepts/matestack/ui/core/app/store.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import Vue from 'vue/dist/vue.esm'
22
import Vuex from 'vuex'
33
import axios from 'axios'
4-
54
import matestackEventHub from 'js/event-hub'
65

76
Vue.use(Vuex)
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
%article{@tag_attributes}
2+
- if options[:text].nil? && block_given?
3+
= yield
4+
- else
5+
= options[:text]
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
module Matestack::Ui::Core::Article
2+
class Article < Matestack::Ui::Core::Component::Static
3+
4+
end
5+
end
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
%div{"v-if": "showing"}
1+
%div{@tag_attributes}
22
= yield

app/concepts/matestack/ui/core/async/async.js

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
import Vue from 'vue/dist/vue.esm'
2-
32
import matestackEventHub from 'js/event-hub'
4-
53
import componentMixin from 'component/component'
64

75
const componentDef = {
@@ -18,8 +16,16 @@ const componentDef = {
1816
methods: {
1917
show: function(event_data){
2018
const self = this
19+
if (this.showing === true){
20+
return
21+
}
2122
this.showing = true
2223
this.event.data = event_data
24+
if(this.componentConfig["defer"] != undefined){
25+
if(!isNaN(this.componentConfig["defer"])){
26+
this.startDefer()
27+
}
28+
}
2329
if(this.componentConfig["hide_after"] != undefined){
2430
self.hide_after_timeout = setTimeout(function () {
2531
self.hide()
@@ -29,6 +35,12 @@ const componentDef = {
2935
hide: function(){
3036
this.showing = false
3137
this.event.data = {}
38+
},
39+
startDefer: function(){
40+
const self = this
41+
setTimeout(function () {
42+
self.rerender()
43+
}, parseInt(this.componentConfig["defer"]));
3244
}
3345
},
3446
created: function () {
@@ -39,8 +51,12 @@ const componentDef = {
3951
if(this.componentConfig["show_on"] != undefined){
4052
this.showing = false
4153
}
42-
if(this.componentConfig["hide_on"] != undefined){
43-
this.showing = true
54+
if(this.componentConfig["defer"] != undefined){
55+
if(!isNaN(this.componentConfig["defer"])){
56+
if (this.componentConfig["show_on"] == undefined){
57+
this.startDefer()
58+
}
59+
}
4460
}
4561
},
4662
beforeDestroy: function() {

0 commit comments

Comments
 (0)