Fixes bug that always built the same (default) image for all prebuilt GHCR images.

Author: prabhakk-mw

.github/workflows/build-and-publish-docker-image.yml

@@ -31,7 +31,7 @@ on:
         description: 'If true, then an additional tag without OS information is generated.'
         required: true
         type: boolean
-      build_args:
+      build_args_csv:
         description: 'String Array of comma separated build-args. Ex ["val1=1", "val2=2", "val3=3"] '
         required: false
         type: string
@@ -53,19 +53,13 @@ jobs:
           && echo "TAG_RELEASE_AND_OS_CAMEL_CASE=${LOWER_CASE_MATLAB_RELEASE}-${{ inputs.os_info_tag }}" >> "$GITHUB_OUTPUT" \
           && echo "TAG_RELEASE_AND_OS_PASCAL_CASE=${LOWER_CASE_MATLAB_RELEASE^}-${{ inputs.os_info_tag }}" >> "$GITHUB_OUTPUT"
 
-      - name: Create list of build args from array of strings
-        id: build-args-as-list
-        uses: lucaspinheirogit/[email protected]
+      # List is defined as a New Line Separated set of values. See: https://github.com/docker/build-push-action?tab=readme-ov-file#inputs
+      - name: Create New Line separated from Comma Separated
+        id: convert-build-args-csv-to-list
+        uses: actions/github-script@v7
         with:
-              stringArray: ${{ inputs.build_args }}
-
-      # See here for example: https://docs.docker.com/build/ci/github-actions/push-multi-registries/
-      # -
-      #   name: Login to Docker Hub
-      #   uses: docker/login-action@v2
-      #   with:
-      #     username: ${{ secrets.DOCKERHUB_USERNAME }}
-      #     password: ${{ secrets.DOCKERHUB_TOKEN }}
+          script: |
+            core.setOutput('build-args-as-list', `${{ inputs.build_args_csv }}`.split(",").join("\n"))
 
       - name: Login to GitHub Container Registry
         uses: docker/login-action@v2
@@ -82,21 +76,22 @@ jobs:
         if: ${{ inputs.is_default_os == false }}
         uses: docker/build-push-action@v4
         with:
-          build-args: ${{ steps.build-args-as-list.outputs.stringList }}
+          build-args: |
+            ${{ steps.convert-build-args-csv-to-list.outputs.build-args-as-list }}
           context: ${{ inputs.docker_build_context }}
           platforms: linux/amd64
           push: true
           tags: |
             ${{ inputs.base_image_name }}:${{ steps.setup_image_tags.outputs.TAG_RELEASE_AND_OS_CAMEL_CASE }}
             ${{ inputs.base_image_name }}:${{ steps.setup_image_tags.outputs.TAG_RELEASE_AND_OS_PASCAL_CASE }}
-
           
       # Example tags: r2023a-ubuntu20.04, R2023a-ubuntu20.04, r2023a, R2023a
       - name: Build & Push Image for latest OS
         if: ${{ inputs.is_default_os == true }}
         uses: docker/build-push-action@v4
         with:
-          build-args: ${{ steps.build-args-as-list.outputs.stringList }}
+          build-args: |
+            ${{ steps.convert-build-args-csv-to-list.outputs.build-args-as-list }}
           context: ${{ inputs.docker_build_context }}
           platforms: linux/amd64
           push: true

.github/workflows/jupyter-matlab-notebook.yaml

@@ -32,4 +32,4 @@ jobs:
         os_info_tag: 'ubuntu22.04'
         matlab_release_tag: ${{ matrix.matlab_release_tag }}
         is_default_os: true
-        build_args: '["MATLAB_RELEASE=${{ matrix.matlab_release_tag }}", "INSTALL_VNC=1", "INSTALL_MATLABENGINE=1", "MOUNT_MATLAB=1"]'
+        build_args_csv: MATLAB_RELEASE=${{ matrix.matlab_release_tag }},INSTALL_VNC=1,INSTALL_MATLABENGINE=1

.github/workflows/jupyter-mounted-matlab-notebook.yml

@@ -32,4 +32,4 @@ jobs:
         os_info_tag: 'ubuntu22.04'
         matlab_release_tag: ${{ matrix.matlab_release_tag }}
         is_default_os: true
-        build_args: '["MATLAB_RELEASE=${{ matrix.matlab_release_tag }}", "INSTALL_VNC=1", "INSTALL_MATLABENGINE=1", "MOUNT_MATLAB=1"]'
+        build_args_csv: MATLAB_RELEASE=${{ matrix.matlab_release_tag }},INSTALL_VNC=1,INSTALL_MATLABENGINE=1,MOUNT_MATLAB=1