Skip to content

Commit 47ea538

Browse files
authored
Merge branch 'master' into see
2 parents 7c9aedc + a72efd6 commit 47ea538

14 files changed

+18198
-8832
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ This package can be installed with the go get command:
2020

2121
_go-sqlite3_ is *cgo* package.
2222
If you want to build your app using go-sqlite3, you need gcc.
23-
However, if you install _go-sqlite3_ with `go install github.com/mattn/go-sqlite3`, you don't need gcc to build your app anymore.
23+
However, after you have built and installed _go-sqlite3_ with `go install github.com/mattn/go-sqlite3` (which requires gcc), you can build your app without relying on gcc in future.
2424

2525
Documentation
2626
-------------
@@ -69,7 +69,7 @@ FAQ
6969

7070
* Can I use this in multiple routines concurrently?
7171

72-
Yes for readonly. But, No for writable. See [#50](https://github.com/mattn/go-sqlite3/issues/50), [#51](https://github.com/mattn/go-sqlite3/issues/51), [#209](https://github.com/mattn/go-sqlite3/issues/209).
72+
Yes for readonly. But, No for writable. See [#50](https://github.com/mattn/go-sqlite3/issues/50), [#51](https://github.com/mattn/go-sqlite3/issues/51), [#209](https://github.com/mattn/go-sqlite3/issues/209), [#274](https://github.com/mattn/go-sqlite3/issues/274).
7373

7474
* Why is it racy if I use a `sql.Open("sqlite3", ":memory:")` database?
7575

_example/trace/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ func main() {
9595
ConnectHook: func(conn *sqlite3.SQLiteConn) error {
9696
err := conn.SetTrace(&sqlite3.TraceConfig{
9797
Callback: traceCallback,
98-
EventMask: uint(eventMask),
98+
EventMask: eventMask,
9999
WantExpandedSQL: true,
100100
})
101101
return err

error_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ import (
1515

1616
func TestSimpleError(t *testing.T) {
1717
e := ErrError.Error()
18-
if e != "SQL logic error or missing database" {
19-
t.Error("wrong error code:" + e)
18+
if e != "SQL logic error or missing database" && e != "SQL logic error" {
19+
t.Error("wrong error code: " + e)
2020
}
2121
}
2222

0 commit comments

Comments
 (0)