Refactor MIMXRT105x target labels and linker script, locate general data in DTCM memory instead of OCRAM for improved performance (#157)

Author: Jamie Smith

targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/CMakeLists.txt

@@ -5,7 +5,7 @@ add_subdirectory(TARGET_IMX EXCLUDE_FROM_ALL)
 add_subdirectory(TARGET_LPC EXCLUDE_FROM_ALL)
 add_subdirectory(TARGET_LPC54114 EXCLUDE_FROM_ALL)
 add_subdirectory(TARGET_MCU_LPC546XX EXCLUDE_FROM_ALL)
-add_subdirectory(TARGET_MIMXRT1050 EXCLUDE_FROM_ALL)
+add_subdirectory(TARGET_MIMXRT105x EXCLUDE_FROM_ALL)
 add_subdirectory(TARGET_MIMXRT1170 EXCLUDE_FROM_ALL)
 add_subdirectory(middleware/TARGET_USB EXCLUDE_FROM_ALL)
 

targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_MIMXRT1050/CMakeLists.txt renamed to targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_MIMXRT105x/CMakeLists.txt

@@ -34,7 +34,6 @@ target_include_directories(mbed-mimxrt1060-evk
 
 target_sources(mbed-mimxrt1060-evk
     INTERFACE
-        fsl_phy.c
 		fsl_flexspi_nor_boot.c
 
         TARGET_1060_EVK/xip/evkbmimxrt1060_flexspi_nor_config.c

targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_MIMXRT1050/PeripheralNames.h renamed to targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_MIMXRT105x/PeripheralNames.h

@@ -63,13 +63,38 @@ MEMORY
 #if MIMXRT105X_BOARD_HAS_EXTERNAL_RAM
   /* Use the external RAM as main memory */
   m_data                (RW)  : ORIGIN = 0x80000000, LENGTH = MIMXRT105X_EXTERNAL_RAM_SIZE
+
+  /* DTCM memory.
+     Startup code configures size to 256k (stealing space from OCRAM). */
+  m_dtcm                (RW)  : ORIGIN = 0x20000000, LENGTH = 0x00040000
 #else
-  /* Use OCRAM as main memory. */
-  m_data                (RW)  : ORIGIN = 0x20200000, LENGTH = 0x00040000
+  /* Use DTCM as main memory (significantly faster than OCRAM).
+     Startup code configures size to 256k (stealing space from OCRAM). */
+  m_dtcm                (RW)  : ORIGIN = 0x20000000, LENGTH = 0x00040000
+
+  /* No external data memory, store data in DTCM */
+#define m_data m_dtcm
+
 #endif
 
+  /* ITCM bank -- used for functions that need to execute from RAM
+     (which is faster than having to load them from flash).
+     Startup code configures size to 128k. */
   m_itcm               (RX)  : ORIGIN = 0x00000000, LENGTH = 0x00020000
-  m_dtcm               (RW)  : ORIGIN = 0x20000000, LENGTH = 0x00020000
+
+  /* OCRAM bank -- extra RAM, available for misc storage but slower to access.
+     Startup code configures size to 128k.
+     Note that address is different on the 105x and the 106x. */
+#if MBED_TARGET_MIMXRT1050
+  m_ocram              (RW)  : ORIGIN = 0x20200000, LENGTH = 0x00020000
+#else /* MIMXRT1060 */
+  m_ocram              (RW)  : ORIGIN = 0x20280000, LENGTH = 0x00020000
+#endif
+
+#if MBED_TARGET_MIMXRT1060
+  /* OCRAM2 bank -- extra RAM, available on MIMXRT106x only. */
+  m_ocram2             (RW)  : ORIGIN = 0x20200000, LENGTH = 0x00080000
+#endif
 }
 
 /* Define output sections */
@@ -234,6 +259,8 @@ SECTIONS
 
   __NDATA_ROM = __ram_function_flash_start + SIZEOF(.ram_function);
 
+  /* Always store noncacheable data (e.g. DMA descriptors) in DTCM, since this memory
+     does not use a cache. */
   .ncache.init :
   {
     __noncachedata_start__ = .;   /* create a global symbol at ncache data start */
@@ -298,14 +325,16 @@ SECTIONS
     __heap_limit = .; /* Add for _sbrk */
   } > m_data
 
+  /* Reserve space for stack (even though stack is always at the end of DTCM regardless
+     of where this section is located) */
   .stack :
   {
     . = ALIGN(8);
     . += STACK_SIZE;
-  } > m_data
+  } > m_dtcm
 
   /* Initializes stack on the end of block */
-  __StackTop   = ORIGIN(m_data) + LENGTH(m_data);
+  __StackTop   = ORIGIN(m_dtcm) + LENGTH(m_dtcm);
   __StackLimit = __StackTop - STACK_SIZE;
   PROVIDE(__stack = __StackTop);
 
@@ -318,7 +347,5 @@ SECTIONS
 #elif defined(TARGET_TEENSY_41)
 	_teensy_model_identifier = 0x25;
 #endif
-
-  ASSERT(__StackLimit >= __HeapLimit, "Stack, heap, and globals exceed main RAM size!")
 }
 

targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_MIMXRT1050/PeripheralPins.c renamed to targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_MIMXRT105x/PeripheralPins.c

@@ -295,6 +295,27 @@ __isr_vector:
     .type    Reset_Handler, %function
 Reset_Handler:
     cpsid   i               /* Mask interrupts */
+
+    /* Update FlexRAM configuration to:
+       - 128kiB OCRAM
+       - 256kiB DTCM
+       - 128kiB ITCM
+       See AN12077 from NXP for info about this register value. */
+    .equ IOMUXC_GPR16_ADDR, 0x400AC040
+    .equ GPR16_LOAD_VALUE, 0x00200007
+    .equ IOMUXC_GPR17_ADDR, 0x400AC044
+    .equ GPR17_LOAD_VALUE, 0x5AAFFAA5
+
+    /* First, update FlexRAM configuration in GPR17 */
+    ldr   r0, =IOMUXC_GPR17_ADDR
+    ldr   r1, =GPR17_LOAD_VALUE
+    str   r1, [r0]
+
+    /* Now, use GPR16 to select the configuration in GPR17 instead of the one in the fuses */
+    ldr   r0, =IOMUXC_GPR16_ADDR
+    ldr   r1, =GPR16_LOAD_VALUE
+    str   r1, [r0]
+
     .equ    VTOR, 0xE000ED08
     ldr     r0, =VTOR
     ldr     r1, =__isr_vector

targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_MIMXRT1050/TARGET_EVK/CMakeLists.txt renamed to targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_MIMXRT105x/TARGET_EVK/CMakeLists.txt

@@ -93,30 +93,44 @@ void BOARD_ConfigMPU(void)
     MPU->RBAR = ARM_MPU_RBAR(3, 0x00000000U);
     MPU->RASR = ARM_MPU_RASR(0, ARM_MPU_AP_FULL, 2, 0, 0, 0, 0, ARM_MPU_REGION_SIZE_1GB);
 
-    /* Region 4 setting: Memory with Normal type, not shareable, outer/inner write back */
+    /* Region 4 setting: Memory with Normal type, not shareable, outer/inner write back [ITCM] */
     MPU->RBAR = ARM_MPU_RBAR(4, 0x00000000U);
     MPU->RASR = ARM_MPU_RASR(0, ARM_MPU_AP_FULL, 0, 0, 1, 1, 0, ARM_MPU_REGION_SIZE_128KB);
 
-    /* Region 5 setting: Memory with Normal type, not shareable, not cacheable */
-    /* DTCM is set to non-cacheable so that we can use it for things like Ethernet and
-     * USB DMA buffers which will not work if they are cached. */
+    /* Region 5 setting: Memory with Normal type, not shareable, outer/inner write back [DTCM] */
     MPU->RBAR = ARM_MPU_RBAR(5, 0x20000000U);
-    MPU->RASR = ARM_MPU_RASR(0, ARM_MPU_AP_FULL, 0, 0, 0, 0, 0, ARM_MPU_REGION_SIZE_128KB);
+    MPU->RASR = ARM_MPU_RASR(0, ARM_MPU_AP_FULL, 0, 0, 1, 1, 0, ARM_MPU_REGION_SIZE_256KB);
+
+#if MBED_TARGET_MIMXRT1050
 
-    /* Region 6 setting: Memory with Normal type, not shareable, outer/inner write back */
+    /* Region 6 setting: Memory with Normal type, not shareable, outer/inner write back [OCRAM] */
     MPU->RBAR = ARM_MPU_RBAR(6, 0x20200000U);
-    MPU->RASR = ARM_MPU_RASR(0, ARM_MPU_AP_FULL, 0, 0, 1, 1, 0, ARM_MPU_REGION_SIZE_256KB);
+    MPU->RASR = ARM_MPU_RASR(0, ARM_MPU_AP_FULL, 0, 0, 1, 1, 0, ARM_MPU_REGION_SIZE_128KB);
+
+#else // MIMXRT1060
+
+    /* Region 6 setting: Memory with Normal type, not shareable, outer/inner write back [OCRAM] */
+    MPU->RBAR = ARM_MPU_RBAR(6, 0x20280000U);
+    MPU->RASR = ARM_MPU_RASR(0, ARM_MPU_AP_FULL, 0, 0, 1, 1, 0, ARM_MPU_REGION_SIZE_128KB);
+
+    /* Region 7 setting: Memory with Normal type, not shareable, outer/inner write back [OCRAM2] */
+    MPU->RBAR = ARM_MPU_RBAR(7, 0x20200000U);
+    MPU->RASR = ARM_MPU_RASR(0, ARM_MPU_AP_FULL, 0, 0, 1, 1, 0, ARM_MPU_REGION_SIZE_512KB);
+
+#endif
+
+
 
 /* The define sets the cacheable memory to shareable,
  * this suggestion is referred from chapter 2.2.1 Memory regions,
  * types and attributes in Cortex-M7 Devices, Generic User Guide */
 #if defined(SDRAM_IS_SHAREABLE)
-    /* Region 7 setting: Memory with Normal type, shareable, outer/inner write back, write/read allocate */
-    MPU->RBAR = ARM_MPU_RBAR(7, 0x80000000U);
+    /* Region 8 setting: Memory with Normal type, shareable, outer/inner write back, write/read allocate */
+    MPU->RBAR = ARM_MPU_RBAR(8, 0x80000000U);
     MPU->RASR = ARM_MPU_RASR(0, ARM_MPU_AP_FULL, 1, 1, 1, 1, 0, ARM_MPU_REGION_SIZE_32MB);
 #else
-    /* Region 7 setting: Memory with Normal type, not shareable, outer/inner write back, write/read allocate */
-    MPU->RBAR = ARM_MPU_RBAR(7, 0x80000000U);
+    /* Region 8 setting: Memory with Normal type, not shareable, outer/inner write back, write/read allocate */
+    MPU->RBAR = ARM_MPU_RBAR(8, 0x80000000U);
     MPU->RASR = ARM_MPU_RASR(0, ARM_MPU_AP_FULL, 1, 0, 1, 1, 0, ARM_MPU_REGION_SIZE_32MB);
 #endif
 

targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_MIMXRT1050/TARGET_EVK/PinNames.h renamed to targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_MIMXRT105x/TARGET_EVK/PinNames.h

@@ -5090,10 +5090,10 @@
         "extra_labels": [
             "NXP",
             "MCUXpresso_MCUS",
-            "MIMXRT1050",
             "IMX",
             "NXP_EMAC",
-	        "USB"
+	        "USB",
+            "MIMXRT105X"
         ],
         "macros": [
             "CPU_MIMXRT1052DVL6B",
@@ -5158,7 +5158,8 @@
         ],
         "extra_labels_add": [
             "EVK",
-            "1050_EVK"
+            "1050_EVK",
+            "MIMXRT1050"
         ],
         "supported_form_factors": [
             "ARDUINO_UNO"
@@ -5186,7 +5187,8 @@
         ],
         "extra_labels_add": [
             "EVK",
-            "1060_EVK"
+            "1060_EVK",
+            "MIMXRT1060"
         ],
         "supported_form_factors": [
             "ARDUINO_UNO"
@@ -5208,7 +5210,8 @@
         ],
         "extra_labels_add": [
             "TEENSY_4X",
-            "TEENSY_40"
+            "TEENSY_40",
+            "MIMXRT1060"
         ],
         "macros_add": [
             "MIMXRT105X_BOARD_HAS_EXTERNAL_RAM=0",
@@ -5228,7 +5231,8 @@
         ],
         "extra_labels_add": [
             "TEENSY_4X",
-            "TEENSY_41"
+            "TEENSY_41",
+            "MIMXRT1060"
         ],
         "macros_add": [
             "MIMXRT105X_BOARD_HAS_EXTERNAL_RAM=0",

targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_MIMXRT1050/TARGET_EVK/TARGET_1050_EVK/flash_api.c renamed to targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_MIMXRT105x/TARGET_EVK/TARGET_1050_EVK/flash_api.c

@@ -58,8 +58,8 @@ if(MBED_GENERATE_CLION_DEBUG_CFGS)
 			endif()
 
 			# Escape quotes and ampersands
-			string(REPLACE "\"" """ ELEMENT "${ELEMENT}")
 			string(REPLACE "&" "&" ELEMENT "${ELEMENT}")
+			string(REPLACE "\"" """ ELEMENT "${ELEMENT}")
 
 			if("${ELEMENT}" MATCHES " ")
 				string(APPEND GDBSERVER_ARGS_STR ""${ELEMENT}"")

targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_MIMXRT1050/TARGET_EVK/TARGET_1050_EVK/flash_defines.h renamed to targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_MIMXRT105x/TARGET_EVK/TARGET_1050_EVK/flash_defines.h

@@ -61,7 +61,7 @@ exit
 		COMMAND ${JLINK}
 		${JLINK_SELECT_ARG}
 		${JLINK_NOGUI_ARG}
-		-Device ${JLINK_CPU_NAME}
+		-Device \"${JLINK_CPU_NAME}\"
 		-Speed ${JLINK_CLOCK_SPEED}
 		-if ${JLINK_UPLOAD_INTERFACE}
 		-JTAGConf -1,-1
@@ -81,7 +81,7 @@ set(UPLOAD_GDBSERVER_DEBUG_COMMAND
 	"${JLINK_GDBSERVER}"
 	${JLINK_SELECT_ARG}
 	${JLINK_NOGUI_ARG}
-	-Device ${JLINK_CPU_NAME}
+	-Device \"${JLINK_CPU_NAME}\"
 	-Speed ${JLINK_CLOCK_SPEED}
 	-endian little
 	-if ${JLINK_UPLOAD_INTERFACE}