Skip to content

Commit 12472f8

Browse files
committed
Remove support for node 10
1 parent 0316f4a commit 12472f8

File tree

5 files changed

+25
-20
lines changed

5 files changed

+25
-20
lines changed

.github/workflows/tests.yml

Lines changed: 15 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -11,25 +11,23 @@ on:
1111

1212
jobs:
1313
tests:
14-
name: tests
1514
runs-on: ubuntu-latest
15+
strategy:
16+
matrix:
17+
node: [ '12', '14', '16' ]
18+
name: playground-build (Node.js ${{ matrix.node }})
1619
steps:
17-
- uses: actions/checkout@v2
18-
- name: Read .nvmrc
19-
run: echo "##[set-output name=NVMRC;]$(cat .nvmrc)"
20-
id: nvm
21-
- name: Use Node.js (.nvmrc)
22-
uses: actions/setup-node@v1
23-
with:
24-
node-version: "${{ steps.nvm.outputs.NVMRC }}"
25-
- name: Display node version (from .nvmrc)
26-
run: echo "Using ${{ steps.nvm.outputs.NVMRC }}"
27-
- name: Install dependencies
28-
run: yarn install
29-
- name: Build
30-
run: yarn run build
31-
- name: Run tests
32-
run: yarn run test
20+
- uses: actions/checkout@v2
21+
- name: Setup node
22+
uses: actions/setup-node@v1
23+
with:
24+
node-version: ${{ matrix.node }}
25+
- name: Install dependencies
26+
run: yarn install
27+
- name: Build
28+
run: yarn run build
29+
- name: Run tests
30+
run: yarn run test
3331

3432
linter:
3533
name: linter-check

.nvmrc

Lines changed: 0 additions & 1 deletion
This file was deleted.

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ First of all, thank you for contributing to MeiliSearch! The goal of this docume
3030

3131
To run this project, you will need:
3232

33-
- Node.js >= v8.7.0, use nvm - [installation instructions](https://github.com/creationix/nvm#install-script)
33+
- Node.js >= v12 (use [nvm](https://github.com/creationix/nvm#install-script)) if you need to change your node version)
3434
- Yarn
3535

3636
### Install <!-- omit in TOC -->

bors.toml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1-
status = ['tests', 'linter-check']
1+
status = [
2+
'tests',
3+
'linter-check',
4+
'Tests (Node.js 12)',
5+
'Tests (Node.js 14)'
6+
]
27
# 1 hour timeout
38
timeout-sec = 3600

package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,9 @@
2323
"test": "./scripts/test",
2424
"test:watch": "./scripts/test-watch"
2525
},
26+
"engines": {
27+
"node": ">=12"
28+
},
2629
"files": [
2730
"dist/"
2831
],

0 commit comments

Comments
 (0)