Skip to content

Commit 88fce3a

Browse files
bidoubiwacurquiza
andcommitted
Remove support for node 10
Remove node 16 tests Stop compatibility at under node 15 Don't make it impossible to use the build of the package unsuported node versions Apply suggestions from code review Co-authored-by: Clémentine Urquizar <[email protected]>
1 parent 03c4a3e commit 88fce3a

File tree

4 files changed

+22
-20
lines changed

4 files changed

+22
-20
lines changed

.github/workflows/tests.yml

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -11,25 +11,24 @@ on:
1111

1212
jobs:
1313
tests:
14-
name: tests
1514
runs-on: ubuntu-latest
15+
strategy:
16+
fail-fast: false
17+
matrix:
18+
node: [ '12', '14' ]
19+
name: Tests (Node.js ${{ matrix.node }})
1620
steps:
17-
- uses: actions/checkout@v2
18-
- name: Read .nvmrc
19-
run: echo "##[set-output name=NVMRC;]$(cat .nvmrc)"
20-
id: nvm
21-
- name: Use Node.js (.nvmrc)
22-
uses: actions/setup-node@v1
23-
with:
24-
node-version: "${{ steps.nvm.outputs.NVMRC }}"
25-
- name: Display node version (from .nvmrc)
26-
run: echo "Using ${{ steps.nvm.outputs.NVMRC }}"
27-
- name: Install dependencies
28-
run: yarn install
29-
- name: Build
30-
run: yarn run build
31-
- name: Run tests
32-
run: yarn run test
21+
- uses: actions/checkout@v2
22+
- name: Setup node
23+
uses: actions/setup-node@v1
24+
with:
25+
node-version: ${{ matrix.node }}
26+
- name: Install dependencies
27+
run: yarn install
28+
- name: Build
29+
run: yarn run build
30+
- name: Run tests
31+
run: yarn run test
3332

3433
linter:
3534
name: linter-check

.nvmrc

Lines changed: 0 additions & 1 deletion
This file was deleted.

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ First of all, thank you for contributing to MeiliSearch! The goal of this docume
3030

3131
To run this project, you will need:
3232

33-
- Node.js >= v8.7.0, use nvm - [installation instructions](https://github.com/creationix/nvm#install-script)
33+
- Node.js >= v12 and node < 15
3434
- Yarn
3535

3636
### Install <!-- omit in TOC -->

bors.toml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1-
status = ['tests', 'linter-check']
1+
status = [
2+
'linter-check',
3+
'Tests (Node.js 12)',
4+
'Tests (Node.js 14)'
5+
]
26
# 1 hour timeout
37
timeout-sec = 3600

0 commit comments

Comments
 (0)