Skip to content

Update enableDarkMode to auto in playground #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2022
Merged

Update enableDarkMode to auto in playground #585

merged 1 commit into from
Apr 26, 2022

Conversation

mdubus
Copy link
Member

@mdubus mdubus commented Apr 26, 2022

Problem

enableDarkMode is still in true, causing the dark mode to be displayed even if the system is in light mode.

Solution

Set enableDarkMode to auto to let the system decide which theme to display

@mdubus mdubus requested a review from bidoubiwa April 26, 2022 09:02
@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Apr 26, 2022
bidoubiwa
bidoubiwa approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Apr 26, 2022

Build succeeded:

@meili-bors meili-bors bot merged commit 8f795a5 into main Apr 26, 2022
@meili-bors meili-bors bot deleted the set_enableDarkMode_to_auto_in_playgrounds branch April 26, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidoubiwa bidoubiwa bidoubiwa approved these changes

Assignees
No one assigned
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdubus @bidoubiwa